Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (88 w, 5 d)

Recent Activity

Wed, Jan 13

Xiangling_L committed rGf0abe2aeaca7: [Frontend] Add pragma align natural and sort out pragma pack stack effect (authored by Xiangling_L).
[Frontend] Add pragma align natural and sort out pragma pack stack effect
Wed, Jan 13, 7:54 AM
Xiangling_L closed D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Wed, Jan 13, 7:53 AM · Restricted Project
Xiangling_L added a reviewer for D89049: [AIX][XCOFF] print out the traceback info : Xiangling_L.
Wed, Jan 13, 6:36 AM · Restricted Project

Tue, Jan 12

Xiangling_L added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Tue, Jan 12, 2:18 PM · Restricted Project

Mon, Jan 11

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Rebased on latest master;
Addressed the comments;

Mon, Jan 11, 10:31 AM · Restricted Project

Fri, Jan 8

Xiangling_L committed rGe97071d79520: [NFC] Renaming PackStack to AlignPackStack (authored by Xiangling_L).
[NFC] Renaming PackStack to AlignPackStack
Fri, Jan 8, 6:15 AM
Xiangling_L closed D93901: [NFC] Renaming PackStack to AlignPackStack.
Fri, Jan 8, 6:15 AM · Restricted Project

Thu, Jan 7

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Addressed the comments;
Rebased the patch on latest master;

Thu, Jan 7, 6:42 AM · Restricted Project

Wed, Jan 6

Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Wed, Jan 6, 1:30 PM · Restricted Project
Xiangling_L updated the diff for D93901: [NFC] Renaming PackStack to AlignPackStack.

Add pre-committing tests with the incorrect behaviour as part of the NFC patch.

Wed, Jan 6, 8:52 AM · Restricted Project

Fri, Jan 1

Xiangling_L added a comment to rGd1fd72343c6f: Refactor how -fno-semantic-interposition sets dso_local on default visibility….

Hi, you commit failed clang-ppc64le-rhel buildbot: http://lab.llvm.org:8011/#/builders/57/builds/2938. Please take a look.

Fri, Jan 1, 7:07 AM

Wed, Dec 30

Xiangling_L updated the summary of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Wed, Dec 30, 12:39 PM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
  • used memcpy to burn AlignPackInfo into uint32_t and vice versa;
  • named XL on AIX stack effect and related options after "xl" instead of "aix"
  • adjusted natural align related code
Wed, Dec 30, 12:38 PM · Restricted Project

Tue, Dec 29

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Rebase on renaming NFC patch

Tue, Dec 29, 10:53 AM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Tue, Dec 29, 7:43 AM · Restricted Project
Xiangling_L requested review of D93901: [NFC] Renaming PackStack to AlignPackStack.
Tue, Dec 29, 7:41 AM · Restricted Project

Dec 11 2020

Xiangling_L accepted D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.

LGTM. Thanks!

Dec 11 2020, 11:08 AM · Restricted Project
Xiangling_L added a reviewer for D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors: Xiangling_L.
Dec 11 2020, 7:55 AM · Restricted Project
Xiangling_L added inline comments to D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.
Dec 11 2020, 7:55 AM · Restricted Project

Dec 10 2020

Xiangling_L added inline comments to D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.
Dec 10 2020, 2:20 PM · Restricted Project

Dec 1 2020

Xiangling_L added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Dec 1 2020, 7:04 AM · Restricted Project
Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Split testcases;
Simplified code;
Don't need to respect attribute align within typedef when the alignment value is less than bitcontainer size;

Dec 1 2020, 7:04 AM · Restricted Project

Nov 27 2020

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Adjusted the logic of operator == for class AlignPackInfo;
Removed mac68k sentinel;

Nov 27 2020, 8:31 AM · Restricted Project

Nov 25 2020

Xiangling_L abandoned D89044: [FE][AIX] Emit error for oversized long long bitfield under 32bit mode.

As we discussed offline, the strategy to handle long long type bitfield under 32bit mode would be the bitcontainer shall be 32-bits unless if a single long long bitfield has length greater than 32 bits (what would have been a diagnostic in xlc/xlclang/xlclang++), then the bitcontainer shall be 64-bits.

Nov 25 2020, 1:52 PM
Xiangling_L accepted D92117: [AIX] Enabling vector type arguments and return for AIX.

Just a minor suggestion: Maybe Enabling return and argument vector types for AIX is more accurate. Otherwise, LGTM.

Nov 25 2020, 1:44 PM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Update the logic to tell if two AlignPackInfo are equal;

Nov 25 2020, 12:34 PM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Nov 25 2020, 7:51 AM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Addressed the comments;
Handle PCH for AIX;

Nov 25 2020, 7:51 AM · Restricted Project

Nov 24 2020

Xiangling_L accepted D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

LGTM. Thanks!

Nov 24 2020, 2:10 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Nov 24 2020, 1:01 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Nov 24 2020, 7:40 AM · Restricted Project, Restricted Project

Nov 23 2020

Xiangling_L committed rG01b3e6e02633: [AIX] Support init priority (authored by Xiangling_L).
[AIX] Support init priority
Nov 23 2020, 11:51 AM
Xiangling_L closed D91272: [AIX] Support init priority.
Nov 23 2020, 11:51 AM · Restricted Project
Xiangling_L updated the diff for D91272: [AIX] Support init priority.

Addressed comments;

Nov 23 2020, 9:57 AM · Restricted Project

Nov 20 2020

Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Nov 20 2020, 12:52 PM · Restricted Project, Restricted Project

Nov 19 2020

Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Nov 19 2020, 5:43 PM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D91272: [AIX] Support init priority.

Addressed the comments;

Nov 19 2020, 9:07 AM · Restricted Project
Xiangling_L committed rG17497ec514f7: [AIX][FE] Support constructor/destructor attribute (authored by Xiangling_L).
[AIX][FE] Support constructor/destructor attribute
Nov 19 2020, 6:25 AM
Xiangling_L closed D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 19 2020, 6:25 AM · Restricted Project

Nov 18 2020

Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Nov 18 2020, 2:52 PM · Restricted Project, Restricted Project

Nov 16 2020

Xiangling_L updated the diff for D90892: [AIX][FE] Support constructor/destructor attribute.

Update testcases;

Nov 16 2020, 8:28 AM · Restricted Project
Xiangling_L added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 16 2020, 8:25 AM · Restricted Project
Xiangling_L committed rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link… (authored by Xiangling_L).
[AIX][driver] Include crti[_64].o and -bcdtors also for C language link…
Nov 16 2020, 7:08 AM
Xiangling_L closed D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.
Nov 16 2020, 7:08 AM · Restricted Project

Nov 13 2020

Xiangling_L updated the diff for D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.

Remove the if condition and tweak the comments;

Nov 13 2020, 8:26 AM · Restricted Project

Nov 12 2020

Xiangling_L updated the diff for D91272: [AIX] Support init priority.

Fix wrong sinit/sterm function formatting issue;

Nov 12 2020, 2:19 PM · Restricted Project
Xiangling_L added inline comments to D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.
Nov 12 2020, 1:59 PM · Restricted Project
Xiangling_L updated the diff for D90892: [AIX][FE] Support constructor/destructor attribute.

Fix minor issues in the testcase;

Nov 12 2020, 10:29 AM · Restricted Project
Xiangling_L requested review of D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default.
Nov 12 2020, 8:18 AM · Restricted Project

Nov 11 2020

Xiangling_L updated the diff for D90892: [AIX][FE] Support constructor/destructor attribute.

Add testcases to both CodeGen and CodeGenCXX folder;

Nov 11 2020, 11:56 AM · Restricted Project
Xiangling_L added a comment to D90892: [AIX][FE] Support constructor/destructor attribute.

I think this generally seems reasonable, but I'm far from an AIX expert so you should wait a few days in case other reviewers have feedback.

Nov 11 2020, 11:30 AM · Restricted Project
Xiangling_L updated the summary of D91272: [AIX] Support init priority.
Nov 11 2020, 9:01 AM · Restricted Project
Xiangling_L requested review of D91272: [AIX] Support init priority.
Nov 11 2020, 9:00 AM · Restricted Project

Nov 10 2020

Xiangling_L updated the diff for D90892: [AIX][FE] Support constructor/destructor attribute.

Address comments;
Move testcases to CodeGen folder instead of CodeGenCXX since ctor/dtor attribute should work in both C&C++ mode;

Nov 10 2020, 11:13 AM · Restricted Project
Xiangling_L added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 10 2020, 11:13 AM · Restricted Project
Xiangling_L added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 10 2020, 10:37 AM · Restricted Project
Xiangling_L added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 10 2020, 8:19 AM · Restricted Project

Nov 5 2020

Xiangling_L updated the diff for D90892: [AIX][FE] Support constructor/destructor attribute.

Remove unused function parameters;
Move testcases to CodeGenCXX folder;

Nov 5 2020, 3:16 PM · Restricted Project
Xiangling_L requested review of D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 5 2020, 3:02 PM · Restricted Project

Oct 26 2020

Xiangling_L committed rG357715ce97d0: [NFC] Remove max_align.c LIT testcase (authored by Xiangling_L).
[NFC] Remove max_align.c LIT testcase
Oct 26 2020, 2:15 PM
Xiangling_L closed D90187: [NFC] Remove max_align.c LIT testcase.
Oct 26 2020, 2:15 PM · Restricted Project
Xiangling_L committed rG3d4aebbb9d99: [AIX] Also error on -G for link-only step (authored by Xiangling_L).
[AIX] Also error on -G for link-only step
Oct 26 2020, 1:52 PM
Xiangling_L closed D90063: [AIX] Also error on -G for link-only step.
Oct 26 2020, 1:52 PM · Restricted Project
Xiangling_L requested review of D90187: [NFC] Remove max_align.c LIT testcase.
Oct 26 2020, 1:10 PM · Restricted Project

Oct 23 2020

Xiangling_L updated the diff for D90063: [AIX] Also error on -G for link-only step.

Fixed the duplication in the testcase;

Oct 23 2020, 1:07 PM · Restricted Project
Xiangling_L committed rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment (authored by Xiangling_L).
[AIX] Let alloca return 16 bytes alignment
Oct 23 2020, 11:42 AM
Xiangling_L closed D89910: [AIX] Let alloca return 16 bytes alignment.
Oct 23 2020, 11:42 AM · Restricted Project
Xiangling_L requested review of D90063: [AIX] Also error on -G for link-only step.
Oct 23 2020, 11:06 AM · Restricted Project

Oct 22 2020

Xiangling_L committed rG0ba98433971f: [AIX] Emit error for -G option on AIX (authored by Xiangling_L).
[AIX] Emit error for -G option on AIX
Oct 22 2020, 1:22 PM
Xiangling_L closed D89897: [AIX] Emit error for -G option on AIX.
Oct 22 2020, 1:21 PM · Restricted Project, Restricted Project
Xiangling_L closed D88659: [NFC] Fix the definition of SuitableAlign.

Manually close the revision after landing it upstream.

Oct 22 2020, 1:13 PM · Restricted Project
Xiangling_L updated the diff for D89910: [AIX] Let alloca return 16 bytes alignment.

Add one case to the test;

Oct 22 2020, 10:46 AM · Restricted Project
Xiangling_L added inline comments to D89910: [AIX] Let alloca return 16 bytes alignment.
Oct 22 2020, 10:43 AM · Restricted Project
Xiangling_L updated the diff for D89897: [AIX] Emit error for -G option on AIX.

Fix the formatting issues;

Oct 22 2020, 8:38 AM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Oct 22 2020, 8:37 AM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D89910: [AIX] Let alloca return 16 bytes alignment.

Fixed the testcase formatting issues;
Fixed the BIGGEST_ALIGNMENT value in testcases;

Oct 22 2020, 7:53 AM · Restricted Project

Oct 21 2020

Xiangling_L updated the summary of D89897: [AIX] Emit error for -G option on AIX.
Oct 21 2020, 2:08 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Oct 21 2020, 2:02 PM · Restricted Project, Restricted Project
Xiangling_L requested review of D89910: [AIX] Let alloca return 16 bytes alignment.
Oct 21 2020, 1:45 PM · Restricted Project
Xiangling_L committed rGcf11f017af32: [NFC] Fix the definition of SuitableAlign (authored by Xiangling_L).
[NFC] Fix the definition of SuitableAlign
Oct 21 2020, 10:36 AM
Xiangling_L requested review of D89897: [AIX] Emit error for -G option on AIX.
Oct 21 2020, 10:29 AM · Restricted Project, Restricted Project

Oct 20 2020

Xiangling_L retitled D88659: [NFC] Fix the definition of SuitableAlign from [FE]Split SuitableAlign into two parts to [NFC] Fix the definition of SuitableAlign.
Oct 20 2020, 10:24 AM · Restricted Project
Xiangling_L updated the diff for D88659: [NFC] Fix the definition of SuitableAlign.

Edit the definition of SuitableAlign;

Oct 20 2020, 10:22 AM · Restricted Project

Oct 19 2020

Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Oct 19 2020, 1:03 PM · Restricted Project, Restricted Project
Xiangling_L added a comment to D88659: [NFC] Fix the definition of SuitableAlign.

Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list?

Oct 19 2020, 10:54 AM · Restricted Project
Xiangling_L added inline comments to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .
Oct 19 2020, 9:01 AM · Restricted Project, Restricted Project

Oct 15 2020

Xiangling_L added a comment to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces.

Oct 15 2020, 2:22 PM · Restricted Project, Restricted Project
Xiangling_L added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Hi Zarko, the patch is out of sync with master branch, could you update it?

Oct 15 2020, 10:55 AM · Restricted Project
Xiangling_L added a comment to D88659: [NFC] Fix the definition of SuitableAlign.

ping.

Oct 15 2020, 9:18 AM · Restricted Project

Oct 14 2020

Xiangling_L added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 14 2020, 3:01 PM · Restricted Project, Restricted Project

Oct 13 2020

Xiangling_L planned changes to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Oct 13 2020, 1:49 PM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Oct 13 2020, 1:49 PM · Restricted Project
Xiangling_L committed rG4c10d6508f54: [AIX] Support two itanium alignment LIT testcases for AIX using regex (authored by Xiangling_L).
[AIX] Support two itanium alignment LIT testcases for AIX using regex
Oct 13 2020, 1:48 PM
Xiangling_L closed D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Oct 13 2020, 1:48 PM · Restricted Project
Xiangling_L retitled D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex from [AIX] Disable two itanium alignment LIT testcases to [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Oct 13 2020, 6:53 AM · Restricted Project
Xiangling_L updated the diff for D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Use regex to match AIX layout dumping format.

Oct 13 2020, 6:52 AM · Restricted Project

Oct 9 2020

Xiangling_L added a comment to D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Can we use a regex to make this also work in AIX?

Oct 9 2020, 1:47 PM · Restricted Project

Oct 8 2020

Xiangling_L requested review of D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Oct 8 2020, 12:26 PM · Restricted Project
Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Remove emit errors for oversized long long bitfield and related testcase;

Oct 8 2020, 7:39 AM · Restricted Project
Xiangling_L retitled D89044: [FE][AIX] Emit error for oversized long long bitfield under 32bit mode from [AIX] Emit error for oversized long long bitfield under 32bit mode to [FE][AIX] Emit error for oversized long long bitfield under 32bit mode.
Oct 8 2020, 7:37 AM