Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (37 w, 2 d)

Recent Activity

Yesterday

Xiangling_L updated the diff for D72454: [AIX] Enable frame pointer for AIX and add related test suite.

Address comments and update testcases.

Sun, Jan 26, 7:40 PM · Restricted Project
Xiangling_L added inline comments to D72454: [AIX] Enable frame pointer for AIX and add related test suite.
Sun, Jan 26, 4:32 PM · Restricted Project

Wed, Jan 22

Xiangling_L added inline comments to D72454: [AIX] Enable frame pointer for AIX and add related test suite.
Wed, Jan 22, 7:03 PM · Restricted Project

Tue, Jan 21

Xiangling_L added inline comments to D73115: [AIX] Minor cleanup in AsmPrinter. [NFC].
Tue, Jan 21, 3:18 PM · Restricted Project

Mon, Jan 20

Xiangling_L added a comment to D72989: [AIX] Replace EmitFunctionDescriptor with EmitFunctionEntryLabel() and delete needsFunctionDescriptors().

Thank you for mentioning this issue, the reason why we added MAI->needsFunctionDescriptors() are as follows:

Mon, Jan 20, 7:22 AM · Restricted Project

Sun, Jan 19

Xiangling_L updated the diff for D72454: [AIX] Enable frame pointer for AIX and add related test suite.

Fix typos

Sun, Jan 19, 3:42 PM · Restricted Project
Xiangling_L added inline comments to D72454: [AIX] Enable frame pointer for AIX and add related test suite.
Sun, Jan 19, 3:26 PM · Restricted Project

Tue, Jan 14

Xiangling_L committed rG25a8aec7f37b: [AIX] ExternalSymbolSDNode lowering (authored by Xiangling_L).
[AIX] ExternalSymbolSDNode lowering
Tue, Jan 14, 6:46 AM
Xiangling_L closed D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Tue, Jan 14, 6:45 AM · Restricted Project

Mon, Jan 13

Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Mon, Jan 13, 12:37 PM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

minor change

Mon, Jan 13, 12:37 PM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

A bug is caught that IFunc is not supported on AIX, so we shouldn't have cast a GlobalValue to a GlobalObject for all PPC target.

Mon, Jan 13, 9:19 AM · Restricted Project

Fri, Jan 10

Xiangling_L added inline comments to D72461: [AIX][XCOFF] Supporting the ReadOnlyWithRel SectionKnd.
Fri, Jan 10, 1:20 PM · Restricted Project
Xiangling_L updated the diff for D72454: [AIX] Enable frame pointer for AIX and add related test suite.

Update comments and fix typo in the testcase;

Fri, Jan 10, 1:01 PM · Restricted Project
Xiangling_L added inline comments to D72454: [AIX] Enable frame pointer for AIX and add related test suite.
Fri, Jan 10, 12:45 PM · Restricted Project

Thu, Jan 9

Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

delete extra ExternalSymSDNode in code;
modify func name;
update the testcase;

Thu, Jan 9, 8:30 AM · Restricted Project
Xiangling_L created D72454: [AIX] Enable frame pointer for AIX and add related test suite.
Thu, Jan 9, 7:15 AM · Restricted Project

Wed, Jan 8

Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

provide full context for diff;

Wed, Jan 8, 7:21 AM · Restricted Project

Tue, Jan 7

Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Update two testcases;

Tue, Jan 7, 2:06 PM · Restricted Project
Xiangling_L planned changes to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Because the best way to test which memcpy version we pick when there exists a user-declared one, we need to test the relocation of the call. So this patch would be moved to needs revision section, waiting for relocation patch to land first.

Tue, Jan 7, 8:02 AM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Address the comments;

Tue, Jan 7, 8:02 AM · Restricted Project
Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Tue, Jan 7, 7:42 AM · Restricted Project

Mon, Jan 6

Xiangling_L added a comment to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

ping.

Mon, Jan 6, 6:56 AM · Restricted Project

Dec 24 2019

Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Update the pr to address user-defined/user-declared lib function issue;
Add more testcases;

Dec 24 2019, 10:39 AM · Restricted Project

Dec 23 2019

Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 23 2019, 2:07 PM · Restricted Project

Dec 18 2019

Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Clean the formatting issue

Dec 18 2019, 4:52 PM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Refactor the code

Dec 18 2019, 4:52 PM · Restricted Project
Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 18 2019, 4:43 PM · Restricted Project
Xiangling_L planned changes to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 18 2019, 11:16 AM · Restricted Project

Dec 16 2019

Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 16 2019, 7:13 PM · Restricted Project

Dec 13 2019

Xiangling_L updated subscribers of D71144: [AIX] Use csect reference for function address constants.
Dec 13 2019, 1:27 PM · Restricted Project

Dec 9 2019

Xiangling_L added inline comments to D71144: [AIX] Use csect reference for function address constants.
Dec 9 2019, 5:45 PM · Restricted Project

Dec 8 2019

Xiangling_L added inline comments to D71125: [AIX] Avoid unset csect assert for functions defined after their use in TOC.
Dec 8 2019, 1:47 PM · Restricted Project

Dec 6 2019

Xiangling_L accepted D70126: [PowerPC] Refactor FinishCall [NFC].
Dec 6 2019, 10:03 AM · Restricted Project
Xiangling_L added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 6 2019, 9:56 AM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Minor changes

Dec 6 2019, 9:55 AM · Restricted Project
Xiangling_L updated the diff for D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

Rebase on latest master;
Address 1st round reviews;

Dec 6 2019, 9:53 AM · Restricted Project

Dec 4 2019

Xiangling_L committed rG8b8a7d1ecfb7: Revert "Add --strip-trailing-cr to compression tests so they pass on Windows." (authored by Xiangling_L).
Revert "Add --strip-trailing-cr to compression tests so they pass on Windows."
Dec 4 2019, 2:29 PM
Xiangling_L added a reverting change for rGd6cbc9528d46: Add --strip-trailing-cr to compression tests so they pass on Windows.: rG8b8a7d1ecfb7: Revert "Add --strip-trailing-cr to compression tests so they pass on Windows.".
Dec 4 2019, 2:29 PM

Dec 3 2019

Xiangling_L added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

I couldn't apply your patch on latest master branch, do you mind updating it?

Dec 3 2019, 7:09 AM · Restricted Project

Nov 26 2019

Xiangling_L added inline comments to D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 26 2019, 2:08 PM · Restricted Project
Xiangling_L added inline comments to D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 26 2019, 1:58 PM · Restricted Project
Xiangling_L created D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Nov 26 2019, 7:21 AM · Restricted Project

Nov 25 2019

Xiangling_L added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

Since this is a NFC patch, does it make sense to add NFC on patch title?

Nov 25 2019, 2:30 PM · Restricted Project

Nov 21 2019

Xiangling_L added a comment to D70461: [AIX] Emit TOC entries for ASM printing.

Just a reminder, since I landed the patch: https://reviews.llvm.org/D70243. You may need to update three testcases there.

Nov 21 2019, 8:19 AM · Restricted Project

Nov 20 2019

Xiangling_L committed rG750e855641be: A fix of the bug introduced by previous lowering in asm patch. (authored by Xiangling_L).
A fix of the bug introduced by previous lowering in asm patch.
Nov 20 2019, 8:34 AM
Xiangling_L committed rGca33727abe4c: [AIX] Lowering jump table, constant pool and block address in asm (authored by Xiangling_L).
[AIX] Lowering jump table, constant pool and block address in asm
Nov 20 2019, 7:28 AM
Xiangling_L closed D70243: Lowering CPI/JTI/BA to assembly.
Nov 20 2019, 7:28 AM · Restricted Project

Nov 19 2019

Xiangling_L added a comment to D70243: Lowering CPI/JTI/BA to assembly.

I don't think llvm actually try to put int directly into TC entry, it always put a label in there. But please correct me if I'm wrong.

Nov 19 2019, 11:01 AM · Restricted Project
Xiangling_L added a comment to D70243: Lowering CPI/JTI/BA to assembly.

Some observation for constant pool lowering:
We put all the constant pool data into rodata section, and create one TC entry per constant pool reference.
It hinders the ability for linker to garbage collect unused data. (Generates them into a separate RO section helps a bit, but won't fully solve this issue)
And we would also create a lot of TC entries for constant pool that might not get cleanup.

For comparison, gcc generates the value of constant pool data directly into the TC entry. It's faster and garbage collectable if not used.

Nov 19 2019, 8:33 AM · Restricted Project

Nov 18 2019

Xiangling_L added inline comments to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.
Nov 18 2019, 7:24 AM · Restricted Project

Nov 17 2019

Xiangling_L added a comment to D70243: Lowering CPI/JTI/BA to assembly.

When I apply your patch to master, it didn't apply cleanly. So please rebase.
And when I did some work to manually apply it, and run through clang-format, clang-format changed several places.
I suspect it's due to the tabs vs space issue.
I suggest to update this patch with after running the clang-format on it.

Nov 17 2019, 7:36 AM · Restricted Project
Xiangling_L updated the diff for D70243: Lowering CPI/JTI/BA to assembly.

Rebase the patch on the latest master;
Fix some formatting issues;

Nov 17 2019, 7:31 AM · Restricted Project

Nov 15 2019

Xiangling_L added inline comments to D69620: Add AIX assembler support.
Nov 15 2019, 10:06 AM · Restricted Project
Xiangling_L updated the diff for D70243: Lowering CPI/JTI/BA to assembly.

Update testcases;
Address 1st round reviews.

Nov 15 2019, 9:21 AM · Restricted Project
Xiangling_L added inline comments to D70243: Lowering CPI/JTI/BA to assembly.
Nov 15 2019, 9:21 AM · Restricted Project
Xiangling_L added a parent revision for D70243: Lowering CPI/JTI/BA to assembly: D70182: Add read-only data assembly writing.
Nov 15 2019, 7:33 AM · Restricted Project
Xiangling_L added a child revision for D70182: Add read-only data assembly writing: D70243: Lowering CPI/JTI/BA to assembly.
Nov 15 2019, 7:33 AM · Restricted Project

Nov 14 2019

Xiangling_L created D70243: Lowering CPI/JTI/BA to assembly.
Nov 14 2019, 7:21 AM · Restricted Project

Nov 13 2019

Xiangling_L added inline comments to D70182: Add read-only data assembly writing.
Nov 13 2019, 12:22 PM · Restricted Project

Oct 30 2019

Xiangling_L committed rG5c9bdc79e1fc: [AIX] Lowering CPI/JTI/BA to MIR (authored by Xiangling_L).
[AIX] Lowering CPI/JTI/BA to MIR
Oct 30 2019, 8:25 AM
Xiangling_L closed D69264: [AIX] Lowering CPI/JTI/BA to MIR.
Oct 30 2019, 8:25 AM · Restricted Project

Oct 22 2019

Xiangling_L added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 22 2019, 11:15 AM · Restricted Project

Oct 21 2019

Xiangling_L committed rGd499d1cedfe4: [NFC] Cleanup with variable name IsPPC64 & IsDarwin (authored by Xiangling_L).
[NFC] Cleanup with variable name IsPPC64 & IsDarwin
Oct 21 2019, 8:35 AM
Xiangling_L closed D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`.
Oct 21 2019, 8:35 AM · Restricted Project
Xiangling_L created D69264: [AIX] Lowering CPI/JTI/BA to MIR.
Oct 21 2019, 8:26 AM · Restricted Project
Xiangling_L added inline comments to D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`.
Oct 21 2019, 8:03 AM · Restricted Project
Xiangling_L updated the diff for D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`.

minor changes

Oct 21 2019, 7:43 AM · Restricted Project
Xiangling_L created D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`.
Oct 21 2019, 7:29 AM · Restricted Project

Oct 17 2019

Xiangling_L added a comment to D69123: NFC: Fix variable only used in asserts by propagating the value..

Thank you for your fix!

Oct 17 2019, 11:21 AM · Restricted Project
Xiangling_L committed rGffe2ec51702e: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large models (authored by Xiangling_L).
[AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large models
Oct 17 2019, 6:22 AM
Xiangling_L closed D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 17 2019, 6:21 AM · Restricted Project

Oct 16 2019

Xiangling_L added a comment to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

LGTM. Thanks.

Oct 16 2019, 2:04 PM · Restricted Project
Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

update the 64 bit testcase

Oct 16 2019, 1:47 PM · Restricted Project
Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Minor changes & add zeroext to 64bit testcase

Oct 16 2019, 10:46 AM · Restricted Project

Oct 11 2019

Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Update testcases: split into simpler ones

Oct 11 2019, 6:41 PM · Restricted Project
Xiangling_L added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 11 2019, 6:05 PM · Restricted Project
Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

correct code format & the testcase

Oct 11 2019, 11:46 AM · Restricted Project
Xiangling_L added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 11 2019, 11:40 AM · Restricted Project

Oct 10 2019

Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Rebase on latest master after the PPCAsmPrinter cleanup NFC patch landed.

Oct 10 2019, 12:20 PM · Restricted Project
Xiangling_L committed rG13bd3ef40d8b: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode (authored by Xiangling_L).
[NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode
Oct 10 2019, 12:00 PM
Xiangling_L closed D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 10 2019, 11:59 AM · Restricted Project
Xiangling_L added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 10 2019, 8:40 AM · Restricted Project
Xiangling_L added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 10 2019, 8:40 AM · Restricted Project
Xiangling_L updated the diff for D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.

Address 2nd round comments

Oct 10 2019, 8:22 AM · Restricted Project
Xiangling_L added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 10 2019, 7:53 AM · Restricted Project

Oct 9 2019

Xiangling_L updated the diff for D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.

Address commments & add const for lookUpOrCreateTOCEntry & TOC MapVector<const MCSymbol *, MCSymbol *>

Oct 9 2019, 1:47 PM · Restricted Project
Xiangling_L added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 9 2019, 1:19 PM · Restricted Project
Xiangling_L created D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Oct 9 2019, 12:23 PM · Restricted Project
Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Address 2nd round comments;
split out variable name NFC patch;
update testcases;

Oct 9 2019, 9:12 AM · Restricted Project
Xiangling_L added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 9 2019, 7:39 AM · Restricted Project

Oct 8 2019

Xiangling_L added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 8 2019, 2:15 PM · Restricted Project
Xiangling_L added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 8 2019, 12:50 PM · Restricted Project
Xiangling_L added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 8 2019, 9:13 AM · Restricted Project

Oct 7 2019

Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Move variable 'SRE' into assertion & rename function name to 'getMCSymbolForTOCPseudoMO'

Oct 7 2019, 2:11 PM · Restricted Project

Oct 6 2019

Xiangling_L updated the diff for D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

Rebase on latest master to pick up 'isDarwin' related patch

Oct 6 2019, 7:59 AM · Restricted Project
Xiangling_L committed rGee68f1ec67c7: [NFC] Replace 'isDarwin' with 'IsDarwin' (authored by Xiangling_L).
[NFC] Replace 'isDarwin' with 'IsDarwin'
Oct 6 2019, 7:45 AM

Oct 2 2019

Xiangling_L created D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 2 2019, 8:22 AM · Restricted Project
Xiangling_L created D68336: [NFC] Replace 'isDarwin' with 'IsDarwin' based on LLVM naming convention.
Oct 2 2019, 7:20 AM · Restricted Project

Sep 28 2019

Xiangling_L accepted D68180: [PowerPC] Fix conditions of assert in PPCAsmPrinter.

LGTM. Thank you Jinsong for putting up this patch. I found this warning as well, and I was planning to fix it in one of my PR which is also related to Sean's lowering work and will be landed in the future. But it's certainly nice to have this fixed earlier.

Sep 28 2019, 6:13 PM · Restricted Project