Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (72 w, 2 d)

Recent Activity

Fri, Sep 25

Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 4:54 PM · Restricted Project
Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 10:51 AM · Restricted Project

Thu, Sep 24

Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Rebased on the NFC patch;

Thu, Sep 24, 3:02 PM · Restricted Project
Xiangling_L requested review of D88260: [NFC][FE] Replace TypeSize with StorageUnitSize.
Thu, Sep 24, 1:51 PM · Restricted Project
Xiangling_L added a comment to D87029: [AIX] Implement AIX special bitfield related alignment rules.

I think it would help the review if we could put the NFC portion(e.g. TypeSize -> StorageUnitSize) to a new patch, and give some rationale about the NFC change.

Thu, Sep 24, 12:39 PM · Restricted Project
Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Updated the comments;

Thu, Sep 24, 11:03 AM · Restricted Project
Xiangling_L updated the summary of D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Thu, Sep 24, 10:32 AM · Restricted Project

Wed, Sep 23

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Addressed the comments;

Wed, Sep 23, 2:00 PM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Wed, Sep 23, 1:36 PM · Restricted Project
Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Wed, Sep 23, 7:58 AM · Restricted Project

Tue, Sep 22

Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Addressed the comments;

Tue, Sep 22, 1:45 PM · Restricted Project
Xiangling_L added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Tue, Sep 22, 6:45 AM · Restricted Project

Fri, Sep 18

Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 18, 11:59 AM · Restricted Project

Thu, Sep 17

Xiangling_L updated subscribers of D87114: [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX.

Do we want to take advantage of this patch to move those checks into the cmake configure so we don't need to duplicate the logic in 2 files as @sfertile mentioned previously?

Thu, Sep 17, 1:24 PM · Restricted Project
Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Rebased on the pragma/pack patch;
Added packed related testcase for bitfield;

Thu, Sep 17, 9:12 AM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Fix the PragmaStack is empty assertion failure when we do: #pragma pack(2) then #pragma align(reset)

Thu, Sep 17, 9:05 AM · Restricted Project

Wed, Sep 16

Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Use default argument;

Wed, Sep 16, 7:17 AM · Restricted Project

Tue, Sep 15

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Removed redundant header file include;

Tue, Sep 15, 8:44 AM · Restricted Project
Xiangling_L updated the summary of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Tue, Sep 15, 8:30 AM · Restricted Project
Xiangling_L requested review of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Tue, Sep 15, 8:29 AM · Restricted Project

Mon, Sep 14

Xiangling_L planned changes to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Mon, Sep 14, 1:18 PM · Restricted Project

Tue, Sep 8

Xiangling_L added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Do you have open questions on whether some callsites passing "false" here, should be switched to true? Given what's here, I would say that it definitely does not makes sense to add this parameter everywhere.

Tue, Sep 8, 7:04 AM · Restricted Project

Thu, Sep 3

Xiangling_L added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

ping.

Thu, Sep 3, 12:16 PM · Restricted Project
Xiangling_L added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 3, 8:22 AM · Restricted Project

Wed, Sep 2

Xiangling_L added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Wed, Sep 2, 2:08 PM · Restricted Project
Xiangling_L requested review of D87029: [AIX] Implement AIX special bitfield related alignment rules.
Wed, Sep 2, 7:24 AM · Restricted Project

Mon, Aug 31

Xiangling_L added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Mon, Aug 31, 8:44 AM · Restricted Project, Restricted Project

Aug 28 2020

Xiangling_L retitled D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable from [FE] Use preferred alignment instead of ABI alignment for complete object when applicable Summary: On some targets, preferred alignment is larger than ABI alignment in some cases. For example, on AIX we have special power alignment rules which... to [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Aug 28 2020, 8:51 AM · Restricted Project
Xiangling_L requested review of D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Aug 28 2020, 8:50 AM · Restricted Project

Aug 14 2020

Xiangling_L committed rGf759b4e43be2: [AIX] Generate unique module id based on Pid and timestamp (authored by Xiangling_L).
[AIX] Generate unique module id based on Pid and timestamp
Aug 14 2020, 1:24 PM
Xiangling_L closed D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 14 2020, 1:23 PM · Restricted Project
Xiangling_L added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 14 2020, 8:31 AM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Add a format indicator as a part of function names;

Aug 14 2020, 7:49 AM · Restricted Project

Aug 13 2020

Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 5:30 PM · Restricted Project
Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 1:22 PM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Add a separator between PID and timestamp;

Aug 13 2020, 1:02 PM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Use itostr for signed integer value ;

Aug 13 2020, 11:09 AM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Addressed the comments;
Fixed the testcase;

Aug 13 2020, 8:56 AM · Restricted Project
Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 8:27 AM · Restricted Project

Aug 10 2020

Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Rebase on the latest master;

Aug 10 2020, 7:24 AM · Restricted Project
Xiangling_L committed rG6ef801aa6bc0: [AIX] Static init frontend recovery and backend support (authored by Xiangling_L).
[AIX] Static init frontend recovery and backend support
Aug 10 2020, 7:11 AM
Xiangling_L closed D84534: [AIX] Static init frontend recovery and backend support.
Aug 10 2020, 7:11 AM · Restricted Project, Restricted Project

Aug 7 2020

Xiangling_L accepted D85455: [XCOFF][AIX] Use TE storage mapping class when large code model is enabled.

LGTM. thanks.

Aug 7 2020, 2:22 PM · Restricted Project
Xiangling_L added a comment to D85455: [XCOFF][AIX] Use TE storage mapping class when large code model is enabled.

so that code compiled with large code model TOC reference would not
take up spaces from the normal small code model TOC reference.

Aug 7 2020, 1:14 PM · Restricted Project
Xiangling_L requested review of D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 7 2020, 8:03 AM · Restricted Project

Aug 6 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.
Aug 6 2020, 1:07 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 6 2020, 1:07 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 6 2020, 12:04 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 6 2020, 10:53 AM · Restricted Project
Xiangling_L added a comment to D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.

As you mentioned in the summary, this patch seems be addressing two orthogonal things:

  1. remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF
  2. when branching to an undefined function, branch to qualname instead.
Aug 6 2020, 8:49 AM · Restricted Project

Aug 5 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.

Added descriptions for struct and functions;
Addressed other comments;

Aug 5 2020, 2:20 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 5 2020, 2:13 PM · Restricted Project, Restricted Project
Xiangling_L accepted D84761: [XCOFF][AIX] Put each jump table in an independent section if -ffunction-sections is specified.

LGTM. thanks

Aug 5 2020, 7:06 AM · Restricted Project

Aug 4 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.

Refactor the code by making emitXXStructorList a virtual function;
Added one testcase for .ref;
Addressed other comments;

Aug 4 2020, 12:54 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 4 2020, 12:52 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 4 2020, 9:22 AM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder..
Aug 4 2020, 7:16 AM · Restricted Project

Jul 30 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.

Removed the disablement in IncrementalProcessingTest.cpp cross-target test;

Jul 30 2020, 8:22 AM · Restricted Project, Restricted Project
Xiangling_L committed rG4e6176fd912a: [AIX] Temporarily disable IncrementalProcessingTest partially (authored by Xiangling_L).
[AIX] Temporarily disable IncrementalProcessingTest partially
Jul 30 2020, 7:42 AM
Xiangling_L closed D84880: [AIX] Temporarily disable IncrementalProcessingTest partially.
Jul 30 2020, 7:42 AM · Restricted Project

Jul 29 2020

Xiangling_L requested review of D84880: [AIX] Temporarily disable IncrementalProcessingTest partially.
Jul 29 2020, 11:40 AM · Restricted Project

Jul 28 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.

Created alias for sinit and sterm;
Adjusted the testcase accordingly;

Jul 28 2020, 8:11 AM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Jul 28 2020, 7:05 AM · Restricted Project, Restricted Project

Jul 27 2020

Xiangling_L accepted D83875: [XCOFF][AIX] Enable -ffunction-sections.

LGTM. Thanks.

Jul 27 2020, 5:15 PM · Restricted Project
Xiangling_L added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 27 2020, 2:05 PM · Restricted Project
Xiangling_L accepted D84693: [NFC][XCOFF] Use getFunctionEntryPointSymbol from TLOF to simplify logic.

LGTM. thanks.

Jul 27 2020, 1:40 PM · Restricted Project
Xiangling_L committed rG05ad8e942996: [AIX] Implement AIX special alignment rule about double/long double (authored by Xiangling_L).
[AIX] Implement AIX special alignment rule about double/long double
Jul 27 2020, 12:14 PM
Xiangling_L closed D79719: [AIX] Implement AIX special alignment rule about double/long double.
Jul 27 2020, 12:14 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 27 2020, 9:10 AM · Restricted Project
Xiangling_L added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 27 2020, 9:05 AM · Restricted Project
Xiangling_L added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 27 2020, 8:20 AM · Restricted Project
Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.

Fix clang-tidy errors;

Jul 27 2020, 6:56 AM · Restricted Project, Restricted Project

Jul 24 2020

Herald added a project to D84534: [AIX] Static init frontend recovery and backend support: Restricted Project.
Jul 24 2020, 8:35 AM · Restricted Project, Restricted Project

Jul 22 2020

Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.
  • Simplified the test command line;
  • Split the typedef related tests into two to address the LIT testcase failure on windows platform;
Jul 22 2020, 6:13 PM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.

Add one more testcase;
Addressed other comments;

Jul 22 2020, 1:20 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D79719: [AIX] Implement AIX special alignment rule about double/long double.
Jul 22 2020, 1:16 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 22 2020, 12:09 PM · Restricted Project
Xiangling_L accepted D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.

LGTM. Thanks

Jul 22 2020, 12:02 PM · Restricted Project
Xiangling_L added inline comments to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.
Jul 22 2020, 8:19 AM · Restricted Project
Xiangling_L added inline comments to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.
Jul 22 2020, 8:14 AM · Restricted Project

Jul 20 2020

Xiangling_L added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jul 20 2020, 8:49 AM · Restricted Project
Xiangling_L added inline comments to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.
Jul 20 2020, 8:42 AM · Restricted Project
Xiangling_L accepted D83252: [XCOFF] Enable symbol alias for AIX.

LGTM with minor nit.

Jul 20 2020, 7:58 AM · Restricted Project

Jul 17 2020

Xiangling_L committed rGec6ada62643c: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static… (authored by Xiangling_L).
[AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static…
Jul 17 2020, 1:16 PM
Xiangling_L closed D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init.
Jul 17 2020, 1:16 PM · Restricted Project
Xiangling_L updated the diff for D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init.

Adjust the query;

Jul 17 2020, 8:17 AM · Restricted Project

Jul 16 2020

Herald added a project to D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init: Restricted Project.
Jul 16 2020, 11:40 AM · Restricted Project
Xiangling_L committed rG69f3378ad65b: [AIX]Generate debug info for static init related functions (authored by Xiangling_L).
[AIX]Generate debug info for static init related functions
Jul 16 2020, 7:44 AM
Xiangling_L closed D83702: [AIX]Generate debug info for static init related functions.
Jul 16 2020, 7:44 AM · Restricted Project

Jul 15 2020

Xiangling_L added inline comments to D83252: [XCOFF] Enable symbol alias for AIX.
Jul 15 2020, 5:30 PM · Restricted Project
Xiangling_L added inline comments to D83252: [XCOFF] Enable symbol alias for AIX.
Jul 15 2020, 8:54 AM · Restricted Project

Jul 14 2020

Xiangling_L updated the diff for D83702: [AIX]Generate debug info for static init related functions.

Simplified the testcase;

Jul 14 2020, 7:44 AM · Restricted Project
Xiangling_L updated the summary of D83702: [AIX]Generate debug info for static init related functions.
Jul 14 2020, 7:13 AM · Restricted Project

Jul 13 2020

Herald added a project to D83702: [AIX]Generate debug info for static init related functions: Restricted Project.
Jul 13 2020, 11:04 AM · Restricted Project
Xiangling_L added inline comments to D79719: [AIX] Implement AIX special alignment rule about double/long double.
Jul 13 2020, 7:46 AM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.

Removed unused var;

Jul 13 2020, 6:56 AM · Restricted Project, Restricted Project

Jul 10 2020

Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.

Set Handled... = true for non-AIX power alignment;
Addressed other comments;

Jul 10 2020, 4:52 AM · Restricted Project, Restricted Project

Jul 9 2020

Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.

Fixed a base class related case by adding IsFirstNonEmpty flag;
Split the aix-Wpacked.cpp testcase into two;
Addressed other comments;

Jul 9 2020, 4:29 PM · Restricted Project, Restricted Project

Jul 8 2020

Xiangling_L added inline comments to D79719: [AIX] Implement AIX special alignment rule about double/long double.
Jul 8 2020, 1:03 PM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D79719: [AIX] Implement AIX special alignment rule about double/long double.

Fixed a -Wpacked related case and added the case to the tests;
Fixed the base class related code issue;
Addressed other comments;

Jul 8 2020, 12:58 PM · Restricted Project, Restricted Project