User Details
- User Since
- May 10 2019, 8:23 AM (88 w, 5 d)
Wed, Jan 13
Tue, Jan 12
Mon, Jan 11
Rebased on latest master;
Addressed the comments;
Fri, Jan 8
Thu, Jan 7
Addressed the comments;
Rebased the patch on latest master;
Wed, Jan 6
Add pre-committing tests with the incorrect behaviour as part of the NFC patch.
Fri, Jan 1
Hi, you commit failed clang-ppc64le-rhel buildbot: http://lab.llvm.org:8011/#/builders/57/builds/2938. Please take a look.
Wed, Dec 30
- used memcpy to burn AlignPackInfo into uint32_t and vice versa;
- named XL on AIX stack effect and related options after "xl" instead of "aix"
- adjusted natural align related code
Tue, Dec 29
Rebase on renaming NFC patch
Dec 11 2020
LGTM. Thanks!
Dec 10 2020
Dec 1 2020
Split testcases;
Simplified code;
Don't need to respect attribute align within typedef when the alignment value is less than bitcontainer size;
Nov 27 2020
Adjusted the logic of operator == for class AlignPackInfo;
Removed mac68k sentinel;
Nov 25 2020
As we discussed offline, the strategy to handle long long type bitfield under 32bit mode would be the bitcontainer shall be 32-bits unless if a single long long bitfield has length greater than 32 bits (what would have been a diagnostic in xlc/xlclang/xlclang++), then the bitcontainer shall be 64-bits.
Just a minor suggestion: Maybe Enabling return and argument vector types for AIX is more accurate. Otherwise, LGTM.
Update the logic to tell if two AlignPackInfo are equal;
Addressed the comments;
Handle PCH for AIX;
Nov 24 2020
LGTM. Thanks!
Nov 23 2020
Addressed comments;
Nov 20 2020
Nov 19 2020
Addressed the comments;
Nov 18 2020
Nov 16 2020
Update testcases;
Nov 13 2020
Remove the if condition and tweak the comments;
Nov 12 2020
Fix wrong sinit/sterm function formatting issue;
Fix minor issues in the testcase;
Nov 11 2020
Add testcases to both CodeGen and CodeGenCXX folder;
Nov 10 2020
Address comments;
Move testcases to CodeGen folder instead of CodeGenCXX since ctor/dtor attribute should work in both C&C++ mode;
Nov 5 2020
Remove unused function parameters;
Move testcases to CodeGenCXX folder;
Oct 26 2020
Oct 23 2020
Fixed the duplication in the testcase;
Oct 22 2020
Manually close the revision after landing it upstream.
Add one case to the test;
Fix the formatting issues;
Fixed the testcase formatting issues;
Fixed the BIGGEST_ALIGNMENT value in testcases;
Oct 21 2020
Oct 20 2020
Edit the definition of SuitableAlign;
Oct 19 2020
Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list?
Oct 15 2020
I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces.
Hi Zarko, the patch is out of sync with master branch, could you update it?
ping.
Oct 14 2020
Oct 13 2020
Use regex to match AIX layout dumping format.
Oct 9 2020
Oct 8 2020
Remove emit errors for oversized long long bitfield and related testcase;