Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (109 w, 6 d)

Recent Activity

Thu, May 20

Xiangling_L removed a reviewer for D102844: XFAIL align.pass.pass.cpp on aix regarding atomic alignment: jfb.
Thu, May 20, 7:11 AM
Xiangling_L requested review of D102844: XFAIL align.pass.pass.cpp on aix regarding atomic alignment.
Thu, May 20, 7:11 AM
Xiangling_L committed rGd74b6635ef38: Fix LIT failure on native aix (authored by Xiangling_L).
Fix LIT failure on native aix
Thu, May 20, 6:39 AM
Xiangling_L closed D102715: Fix LIT failure on native aix.
Thu, May 20, 6:39 AM · Restricted Project

Wed, May 19

Xiangling_L added inline comments to D102715: Fix LIT failure on native aix.
Wed, May 19, 11:10 AM · Restricted Project
Xiangling_L updated the diff for D102715: Fix LIT failure on native aix.

Adjust the comment;

Wed, May 19, 10:43 AM · Restricted Project
Xiangling_L retitled D102715: Fix LIT failure on native aix from [AIX] Fix LIT failure on native aix to Fix LIT failure on native aix.
Wed, May 19, 10:37 AM · Restricted Project
Xiangling_L added inline comments to D102715: Fix LIT failure on native aix.
Wed, May 19, 10:36 AM · Restricted Project
Xiangling_L updated the diff for D102715: Fix LIT failure on native aix.

Adjusted the testcase so that it also tests the property well on aix;

Wed, May 19, 7:59 AM · Restricted Project

Tue, May 18

Xiangling_L updated the diff for D102715: Fix LIT failure on native aix.

Add comments to the block;

Tue, May 18, 5:09 PM · Restricted Project
Xiangling_L updated the summary of D102715: Fix LIT failure on native aix.
Tue, May 18, 5:05 PM · Restricted Project

May 18 2021

Xiangling_L requested review of D102715: Fix LIT failure on native aix.
May 18 2021, 1:01 PM · Restricted Project

May 17 2021

Xiangling_L committed rGe0921655b1ff: [AIX] Implement AIX special bitfield related alignment rules (authored by Xiangling_L).
[AIX] Implement AIX special bitfield related alignment rules
May 17 2021, 8:31 AM
Xiangling_L closed D87029: [AIX] Implement AIX special bitfield related alignment rules.
May 17 2021, 8:31 AM · Restricted Project

May 14 2021

Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Rebased on the latest master and updated the testcase accordingly;

May 14 2021, 12:39 PM · Restricted Project

May 12 2021

Xiangling_L updated the diff for D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.

Set default timeout value to 1200 in BuildFactory, which is the default value for ShellCommand

May 12 2021, 11:00 AM
Xiangling_L added inline comments to D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.
May 12 2021, 10:50 AM
Xiangling_L requested review of D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.
May 12 2021, 8:11 AM

Apr 29 2021

Xiangling_L added inline comments to D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.
Apr 29 2021, 12:58 PM
Xiangling_L closed D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.
Apr 29 2021, 7:07 AM
Xiangling_L committed rZORGc5e33710b234: [zorg] Build and test project depends on project enabled in LibcxxAndAbiBuilder (authored by Xiangling_L).
[zorg] Build and test project depends on project enabled in LibcxxAndAbiBuilder
Apr 29 2021, 7:07 AM
Xiangling_L added inline comments to D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.
Apr 29 2021, 6:20 AM
Xiangling_L added a reviewer for D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder: ZarkoCA.
Apr 29 2021, 6:19 AM

Apr 26 2021

Xiangling_L added a comment to D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.

ping.

Apr 26 2021, 6:36 AM

Apr 22 2021

Xiangling_L added a comment to D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.

ping.

Apr 22 2021, 6:59 AM

Apr 15 2021

Xiangling_L accepted D100350: [AIX] Diagnose thinLTO usage in clang on AIX..

LGTM. thanks

Apr 15 2021, 6:49 AM · Restricted Project

Apr 14 2021

Xiangling_L requested review of D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.
Apr 14 2021, 11:27 AM

Apr 13 2021

Xiangling_L added inline comments to D100350: [AIX] Diagnose thinLTO usage in clang on AIX..
Apr 13 2021, 2:23 PM · Restricted Project
Xiangling_L added inline comments to D100350: [AIX] Diagnose thinLTO usage in clang on AIX..
Apr 13 2021, 8:06 AM · Restricted Project

Apr 8 2021

Xiangling_L committed rGd5085617986e: [AIX] Support init priority attribute (authored by Xiangling_L).
[AIX] Support init priority attribute
Apr 8 2021, 12:41 PM
Xiangling_L closed D99291: [AIX] Support init priority attribute.
Apr 8 2021, 12:40 PM · Restricted Project
Xiangling_L added inline comments to D99291: [AIX] Support init priority attribute.
Apr 8 2021, 7:03 AM · Restricted Project

Apr 7 2021

Xiangling_L committed rZORG52da64f693ff: Enable build_standalone in LibcxxAndAbiBuilder (authored by Xiangling_L).
Enable build_standalone in LibcxxAndAbiBuilder
Apr 7 2021, 7:02 AM
Xiangling_L closed D99985: Enable build_standalone in LibcxxAndAbiBuilder.
Apr 7 2021, 7:02 AM
Xiangling_L committed rZORG3a9c8098bd8f: [zorg] Adjust libcxx buildbot config on AIX (authored by Xiangling_L).
[zorg] Adjust libcxx buildbot config on AIX
Apr 7 2021, 6:59 AM
Xiangling_L closed D97326: [zorg] Adjust libcxx buildbot config on AIX.
Apr 7 2021, 6:59 AM

Apr 6 2021

Xiangling_L requested review of D99985: Enable build_standalone in LibcxxAndAbiBuilder.
Apr 6 2021, 12:23 PM
Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Split this patch into two;

Apr 6 2021, 12:22 PM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Looks fine.

However, now the change to buildbot/osuosl/master/config/builders.py and the change to zorg/buildbot/builders/LibcxxAndAbiBuilder.py are not related.
Could you break them to 2 separate patches, please?

Apr 6 2021, 10:19 AM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Apr 6 2021, 7:11 AM

Mar 31 2021

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Mar 31 2021, 6:35 AM

Mar 26 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Adjust the libcxx buildbot config to enable libcxx project only;
But still keep adding build_standalone functionalities to LibcxxAndAbiBuilder;

Mar 26 2021, 1:18 PM
Xiangling_L planned changes to D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Mar 26 2021, 6:31 AM

Mar 25 2021

Xiangling_L updated the diff for D99291: [AIX] Support init priority attribute.

Add assertion to make sure we have correct priority value in range;

Mar 25 2021, 11:01 AM · Restricted Project
Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Addressed the comments;

Mar 25 2021, 6:40 AM

Mar 24 2021

Xiangling_L requested review of D99291: [AIX] Support init priority attribute.
Mar 24 2021, 12:10 PM · Restricted Project

Mar 22 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Pass runtimes as src_bo_build_dir when building standalone runtimes

Mar 22 2021, 7:50 AM

Mar 18 2021

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Mar 18 2021, 12:53 PM

Mar 12 2021

Xiangling_L updated the diff for D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Bring back two forward declarations to avoid changing pervasive SmallVector to llvm::SmallVector

Mar 12 2021, 7:01 PM · Restricted Project
Xiangling_L added inline comments to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 3:13 PM · Restricted Project
Xiangling_L updated the diff for D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Addressed the comments;

Mar 12 2021, 2:07 PM · Restricted Project
Xiangling_L updated the summary of D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:58 PM · Restricted Project
Xiangling_L added inline comments to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:52 PM · Restricted Project
Xiangling_L added a comment to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 in this patch?

Mar 12 2021, 1:45 PM · Restricted Project
Xiangling_L requested review of D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:37 PM · Restricted Project
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Mar 12 2021, 6:46 AM

Mar 9 2021

Xiangling_L committed rG561fb7f60ab6: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX (authored by Xiangling_L).
[NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX
Mar 9 2021, 10:04 AM
Xiangling_L closed D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.
Mar 9 2021, 10:04 AM · Restricted Project
Xiangling_L added a comment to D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.

Maybe this needs to be addressed in the forward declaration in clang/include/clang/Basic/LLVM.h ?

Mar 9 2021, 9:25 AM · Restricted Project
Xiangling_L requested review of D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.
Mar 9 2021, 8:28 AM · Restricted Project

Mar 8 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Adjust the build_standalone implementation.

Mar 8 2021, 6:35 PM

Mar 4 2021

Xiangling_L added a comment to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

Or, asked differently, is it intentional that llvm/tools/bugpoint/ToolRunner.cpp still uses LTDL_SHLIB_EXT?

Mar 4 2021, 8:48 AM · Restricted Project
Xiangling_L added a comment to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

what does LTDL_SHLIB_EXT expand to on aix?

Mar 4 2021, 8:41 AM · Restricted Project
Xiangling_L committed rGe9f9ec837d44: [CMake][AIX] Adjust plugin library extension used on AIX (authored by Xiangling_L).
[CMake][AIX] Adjust plugin library extension used on AIX
Mar 4 2021, 8:24 AM
Xiangling_L closed D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Mar 4 2021, 8:24 AM · Restricted Project

Mar 3 2021

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

I'm not sure I follow what are you trying to achieve by changing the src_root.

Changing src_root would not give you ../llvm/runtimes, it simply changes where the source code gets checked out to. Like <buildbot-worker-directory>/<builder>/runtimes/llvm-project/<the rest of the monorepo tree>.

Mar 3 2021, 7:33 AM

Mar 1 2021

Xiangling_L committed rZORG1d2328ff69a8: [zorg] Use boolean flag to determine if building a unified standalone runtimes (authored by Xiangling_L).
[zorg] Use boolean flag to determine if building a unified standalone runtimes
Mar 1 2021, 1:54 PM
Xiangling_L closed D97326: [zorg] Adjust libcxx buildbot config on AIX.
Mar 1 2021, 1:54 PM

Feb 26 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Use a boolean flag instead to control if building a unified standalone runtimes;

Feb 26 2021, 1:59 PM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Feb 26 2021, 8:24 AM

Feb 24 2021

Xiangling_L committed rZORG70ac07d8c27d: [zorg] Rename cross-targeting buildbot on AIX (authored by Xiangling_L).
[zorg] Rename cross-targeting buildbot on AIX
Feb 24 2021, 6:50 AM
Xiangling_L closed D97222: [zorg] Rename cross-targeting buildbot on AIX.
Feb 24 2021, 6:50 AM

Feb 23 2021

Xiangling_L requested review of D97326: [zorg] Adjust libcxx buildbot config on AIX.
Feb 23 2021, 12:16 PM
Xiangling_L closed D96814: [zorg] Add runtimes buildbot for AIX.
Feb 23 2021, 12:12 PM

Feb 22 2021

Xiangling_L requested review of D97222: [zorg] Rename cross-targeting buildbot on AIX.
Feb 22 2021, 1:22 PM
Xiangling_L committed rZORGb656c613b72e: [zorg] Add buildbot for libcxx build on AIX (authored by Xiangling_L).
[zorg] Add buildbot for libcxx build on AIX
Feb 22 2021, 7:57 AM
Xiangling_L added inline comments to D96814: [zorg] Add runtimes buildbot for AIX.
Feb 22 2021, 6:46 AM

Feb 19 2021

Xiangling_L updated the diff for D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

minor: adjusted the comment;

Feb 19 2021, 7:05 AM · Restricted Project

Feb 18 2021

Xiangling_L updated the diff for D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

Fix the regression on Linux;

Feb 18 2021, 1:54 PM · Restricted Project
Xiangling_L added inline comments to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 18 2021, 10:40 AM · Restricted Project

Feb 17 2021

Xiangling_L added a comment to D87029: [AIX] Implement AIX special bitfield related alignment rules.

ping.

Feb 17 2021, 6:40 AM · Restricted Project

Feb 16 2021

Xiangling_L requested review of D96814: [zorg] Add runtimes buildbot for AIX.
Feb 16 2021, 1:13 PM

Feb 11 2021

Xiangling_L committed rZORG24f991707240: [zorg] Remove redundant '\' in AIX buildbot config (authored by Xiangling_L).
[zorg] Remove redundant '\' in AIX buildbot config
Feb 11 2021, 11:45 AM
Xiangling_L closed D96526: [zorg] Remove redundant '\'.
Feb 11 2021, 11:45 AM
Xiangling_L requested review of D96526: [zorg] Remove redundant '\'.
Feb 11 2021, 10:37 AM

Feb 10 2021

Xiangling_L committed rZORGd561eb810542: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX (authored by Xiangling_L).
[zorg] Add Clang ppc64le cross-targeting buildbot on AIX
Feb 10 2021, 6:45 AM
Xiangling_L closed D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 10 2021, 6:45 AM

Feb 8 2021

Xiangling_L requested review of D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 8 2021, 10:25 AM · Restricted Project
Xiangling_L committed rG6b1e2fc89327: [FE] Manipulate the first byte of guard variable type in both load and store… (authored by Xiangling_L).
[FE] Manipulate the first byte of guard variable type in both load and store…
Feb 8 2021, 8:16 AM
Xiangling_L closed D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 8 2021, 8:16 AM · Restricted Project
Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Removed redundant -DLLVM_ENABLE_PROJECTS option;

Feb 8 2021, 7:16 AM
Xiangling_L added inline comments to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 8 2021, 7:11 AM

Feb 3 2021

Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Remove make='ninja';

Feb 3 2021, 6:42 AM

Feb 2 2021

Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Addressed the comments;

Feb 2 2021, 1:06 PM
Xiangling_L added inline comments to D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 12:37 PM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Addressed the comments related to test formatting;

Feb 2 2021, 12:36 PM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Remove redundant file;

Feb 2 2021, 12:23 PM · Restricted Project
Xiangling_L added inline comments to D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 12:15 PM · Restricted Project
Xiangling_L retitled D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation from [FE][AIX] Use i8 as guard variable type in both load and store operation to [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 11:37 AM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Align load and store operation related to guard variable by both using the first byte of the variable.

Feb 2 2021, 11:34 AM · Restricted Project