This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Use ArrayRef in TargetLowering functions
ClosedPublic

Authored by Miss_Grape on Apr 13 2022, 12:06 AM.

Details

Summary

This patch is similar to D122557, D123467,adding an ArrayRef version for setLoadExtActionsetIndexedLoadActionsetIndexedStoreAction

Diff Detail

Event Timeline

Miss_Grape created this revision.Apr 13 2022, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 12:06 AM
Miss_Grape requested review of this revision.Apr 13 2022, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 12:06 AM
sunshaoce added inline comments.Apr 13 2022, 12:16 AM
llvm/include/llvm/CodeGen/TargetLowering.h
2271

How about use ArrayRef<unsigned> ExtTypes here?

Fix comment

Miss_Grape added inline comments.Apr 13 2022, 12:42 AM
llvm/include/llvm/CodeGen/TargetLowering.h
2271

Sorry, there was a problem because I didn't update the locally.

Miss_Grape retitled this revision from [NFC][CodeGen] Use ArrayRef in TargetLowering functions to [CodeGen] Use ArrayRef in TargetLowering functions.Apr 13 2022, 1:11 AM
Miss_Grape edited the summary of this revision. (Show Details)
Miss_Grape added a comment.EditedApr 13 2022, 1:54 AM

If this patch Ok, need to update the following patch:
D123659 D123663 D123661 D123654 D123653

Miss_Grape added a reviewer: lkail.
This revision is now accepted and ready to land.May 12 2022, 11:34 AM
This revision was landed with ongoing or failed builds.May 16 2022, 6:31 AM
This revision was automatically updated to reflect the committed changes.