This is an archive of the discontinued LLVM Phabricator instance.

[dsymutil] Update vector of section starts with size of current section
ClosedPublic

Authored by augusto2112 on Mar 22 2022, 10:20 AM.

Details

Summary

Take into account the contributions of the sections from different
object files when calculating the address where relocations should be
applied.

Diff Detail

Event Timeline

augusto2112 created this revision.Mar 22 2022, 10:20 AM
Herald added a project: Restricted Project. · View Herald Transcript
augusto2112 requested review of this revision.Mar 22 2022, 10:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 10:20 AM
aprantl accepted this revision.Mar 22 2022, 2:54 PM

That looks plausible. Does this affect any of the tests?

This revision is now accepted and ready to land.Mar 22 2022, 2:54 PM

That looks plausible. Does this affect any of the tests?

Yes, two swift tests.

Clang format

Clang format

This revision was landed with ongoing or failed builds.Mar 23 2022, 6:16 AM
This revision was automatically updated to reflect the committed changes.