This is an archive of the discontinued LLVM Phabricator instance.

Differential D121578

[RISCV][NFC] Add tests to address invalid arch dependencies.
ClosedPublic

Authored by khchen on Mar 14 2022, 1:10 AM.

Details

Reviewers
craig.topper
kito-cheng
asb
Commits
rGf5fea45d09e5: [RISCV][NFC] Add tests to address invalid arch dependencies.
Summary

Improve test converage.

Diff Detail

Event Timeline

khchen created this revision.Mar 14 2022, 1:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 1:10 AM
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence and 25 others. · View Herald Transcript
khchen requested review of this revision.Mar 14 2022, 1:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 1:10 AM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD. · View Herald Transcript
Harbormaster completed remote builds in B154056: Diff 415024.Mar 14 2022, 1:40 AM
asb accepted this revision.Mar 17 2022, 6:25 AM

Thanks, this looks good to me.

This revision is now accepted and ready to land.Mar 17 2022, 6:25 AM
Herald added subscribers: • s, arichardson. · View Herald TranscriptMar 17 2022, 6:25 AM
Closed by commit rGf5fea45d09e5: [RISCV][NFC] Add tests to address invalid arch dependencies. (authored by khchen). · Explain WhyMar 18 2022, 9:41 AM
This revision was automatically updated to reflect the committed changes.
khchen added a commit: rGf5fea45d09e5: [RISCV][NFC] Add tests to address invalid arch dependencies..

Revision Contents

PathSize
clang/
test/
Driver/
37 lines

Diff 416529

clang/test/Driver/riscv-arch.c

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Lines
// RV32-LETTER: error: invalid arch name 'rv32q', // RV32-LETTER: error: invalid arch name 'rv32q',
// RV32-LETTER: first letter should be 'e', 'i' or 'g' // RV32-LETTER: first letter should be 'e', 'i' or 'g'
// RUN: %clang -target riscv32-unknown-elf -march=rv32imcq -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32imcq -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ORDER %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ORDER %s
// RV32-ORDER: error: invalid arch name 'rv32imcq', // RV32-ORDER: error: invalid arch name 'rv32imcq',
// RV32-ORDER: standard user-level extension not given in canonical order 'q' // RV32-ORDER: standard user-level extension not given in canonical order 'q'
// RUN: %clang -target riscv32-unknown-elf -march=rv64e -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-EER %s
// RV64-EER: error: invalid arch name 'rv64e',
// RV64-EER: standard user-level extension 'e' requires 'rv32'
// RUN: %clang -target riscv32-unknown-elf -march=rv32id -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-DER %s
// RV32-DER: error: invalid arch name 'rv32id',
// RV32-DER: d requires f extension to also be specified
// RUN: %clang -target riscv32-unknown-elf -march=rv32izve32f -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZVE32F-ER %s
// RV32-ZVE32F-ER: error: invalid arch name 'rv32izve32f',
// RV32-ZVE32F-ER: zve32f requires f or zfinx extension to also be specified
// RUN: %clang -target riscv32-unknown-elf -march=rv32ifzve64d -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZVE64D-ER %s
// RV32-ZVE64D-ER: error: invalid arch name 'rv32ifzve64d',
// RV32-ZVE64D-ER: zve64d requires d or zdinx extension to also be specified
// RUN: %clang -target riscv32-unknown-elf -march=rv32izvl64b -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZVL64B-ER %s
// RV32-ZVL64B-ER: error: invalid arch name 'rv32izvl64b',
// RV32-ZVL64B-ER: zvl*b requires v or zve* extension to also be specified
// RUN: %clang -target riscv32-unknown-elf -march=rv32imw -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32imw -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-STD-INVAL %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-STD-INVAL %s
// RV32-STD-INVAL: error: invalid arch name 'rv32imw', // RV32-STD-INVAL: error: invalid arch name 'rv32imw',
// RV32-STD-INVAL: invalid standard user-level extension 'w' // RV32-STD-INVAL: invalid standard user-level extension 'w'
// RUN: %clang -target riscv32-unknown-elf -march=rv32imqc -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32imqc -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-STD %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-STD %s
// RV32-STD: error: invalid arch name 'rv32imqc', // RV32-STD: error: invalid arch name 'rv32imqc',
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines
// RV32-TARGET: "-triple" "riscv32-unknown-unknown-elf" // RV32-TARGET: "-triple" "riscv32-unknown-unknown-elf"
// RUN: %clang -target riscv32-unknown-elf -march=rv64i -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv64i -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s
// RUN: %clang -target riscv64-unknown-elf -march=rv64i -### %s \ // RUN: %clang -target riscv64-unknown-elf -march=rv64i -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s
// RV64-TARGET: "-triple" "riscv64-unknown-unknown-elf" // RV64-TARGET: "-triple" "riscv64-unknown-unknown-elf"
// RUN: %clang -target riscv32-unknown-elf -march=rv32ifzfh01p0 -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZFH %s
// RUN: %clang -target riscv32-unknown-elf -march=rv32ifzfh -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZFH %s
// RV32-ZFH: "-target-feature" "+zfh"
// RUN: %clang -target riscv32-unknown-elf -march=rv32ifzfhmin01p0 -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZFHMIN %s
// RUN: %clang -target riscv32-unknown-elf -march=rv32ifzfhmin -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZFHMIN %s
// RV32-ZFHMIN: "-target-feature" "+zfhmin"
// RUN: %clang -target riscv32-unknown-elf -march=rv32izbb1p0 -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32izbb1p0 -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZBB %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZBB %s
// RUN: %clang -target riscv32-unknown-elf -march=rv32izbb -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32izbb -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZBB %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZBB %s
// RV32-ZBB: "-target-feature" "+zbb" // RV32-ZBB: "-target-feature" "+zbb"
// RUN: %clang -target riscv32-unknown-elf -march=rv32izbb1p0_zbp0p93 -menable-experimental-extensions -### %s \ // RUN: %clang -target riscv32-unknown-elf -march=rv32izbb1p0_zbp0p93 -menable-experimental-extensions -### %s \
// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-ZBB-ZBP %s // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-ZBB-ZBP %s
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines