Page MenuHomePhabricator

[mlir] Update FuncOp conversion passes to Pass/InterfacePass<FunctionOpInterface>
ClosedPublic

Authored by rriddle on Mar 8 2022, 12:49 AM.

Details

Summary

These passes generally don't rely on any special aspects of FuncOp, and moving allows
for these passes to be used in many more situations. The passes that obbiously weren't
relying on invariants guaranteed by a "function" were updated to be generic pass, the
rest were updated to be FunctionOpinterface InterfacePasses.

The test updates are NFC switching from implicit nesting (-pass -pass2) form to
the -pass-pipeline form (generic passes do not implicitly nest as op-specific passes do).

Diff Detail

Event Timeline

rriddle created this revision.Mar 8 2022, 12:49 AM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Mar 8 2022, 12:49 AM
rriddle updated this revision to Diff 413841.Mar 8 2022, 9:40 AM
rriddle edited the summary of this revision. (Show Details)
mehdi_amini accepted this revision.Mar 8 2022, 12:14 PM

Typo in the description: "obbiously"

This revision is now accepted and ready to land.Mar 8 2022, 12:14 PM
This revision was automatically updated to reflect the committed changes.