Just some minor nits; the bulk of this is above my pay grade. :)
Here and line 34, extraneous whitespace. (Weird spacing throughout, honestly, but that's clang-format for you.)
Here and throughout, FYI, the code is not ADL-proof, which means it'll have this problem:
(1) It kinda looks like __pattern_sort (pstl/include/pstl/internal/algorithm_impl.h line 2198) can call this with __xe == __xs. But maybe I'm wrong.
I have re-run clang-format on the code. Not sure what else to do about it.
Good point. I've tried to fix this everywhere, in the same way that the OpenMP backend fixes it.
Good catch, thank you!
Is there a reason you use ::std here instead of std?
This isn't ADL-proof.
Also not ADL-proof
These comments seem weird to me.
No. I suppose it's been so long that it won't apply cleanly. I would really like some help getting a builder to turn this on for macOS automatically so that it can run as part of the normal test suite. I can try to carve out some time to rebase it and re-test it. I'm not really sure what anyone is waiting for...