Page MenuHomePhabricator

MikeDvorskiy (Mikhail Dvorskiy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2018, 4:49 AM (43 w, 3 d)

Recent Activity

Jul 8 2019

MikeDvorskiy added inline comments to D60480: [libc++] Integrate the PSTL into libc++.
Jul 8 2019, 6:29 AM · Restricted Project, Restricted Project

Jun 27 2019

MikeDvorskiy added inline comments to D60480: [libc++] Integrate the PSTL into libc++.
Jun 27 2019, 9:11 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D61340: [pstl] Move the dummy standard library headers to extra/.

...

I don't mind. All I care is that this stuff stays out of the main include directory.

Jun 27 2019, 2:29 AM · Restricted Project

Jun 21 2019

MikeDvorskiy added a comment to D61340: [pstl] Move the dummy standard library headers to extra/.

Louis,
thanks for the alternative proposal.

Jun 21 2019, 12:33 AM · Restricted Project

Jun 13 2019

MikeDvorskiy updated the diff for D62719: A hot fix for exclusive_scan.
  1. The test was improved.
  2. Minor changes in PSTL code. It needs for possibility of coverage that case in "negative test scenario".
Jun 13 2019, 4:56 AM
MikeDvorskiy added inline comments to D62719: A hot fix for exclusive_scan.
Jun 13 2019, 4:53 AM

Jun 6 2019

MikeDvorskiy updated the diff for D62719: A hot fix for exclusive_scan.

+ fix filename in a file header

Jun 6 2019, 2:44 AM
MikeDvorskiy updated the diff for D62719: A hot fix for exclusive_scan.

Added a negative test for exclusive_scan algorithm. It checks non-participation the algo declare in overload resolution.

Jun 6 2019, 2:43 AM
MikeDvorskiy committed rG36d1f2443b0d: [pstl] The optimized parallel versions of sort, stable_sort algorithms, TBB… (authored by MikeDvorskiy).
[pstl] The optimized parallel versions of sort, stable_sort algorithms, TBB…
Jun 6 2019, 12:33 AM

Jun 4 2019

MikeDvorskiy updated the diff for D59925: The optimized parallel versions of sort, stable_sort algorithms..

Add uglification for "merge_task" and Rebased to the HEAD

Jun 4 2019, 4:01 AM · Restricted Project

Jun 3 2019

MikeDvorskiy added a comment to D62719: A hot fix for exclusive_scan.

Actually, we should probably get a test of some sort here before accepting the change. Yes, it's fairly obviously wrong and the fix is fairly obviously correct, but it's a regression and we should provide tests for regressions, lest certain standard library maintainers ask uncomfortable questions.

Jun 3 2019, 1:48 AM
MikeDvorskiy committed rG209adba44053: A test commit from Mikhail Dvorskiy (blank line, to pstl/trunk) according… (authored by MikeDvorskiy).
A test commit from Mikhail Dvorskiy (blank line, to pstl/trunk) according…
Jun 3 2019, 1:21 AM
MikeDvorskiy added a comment to D62719: A hot fix for exclusive_scan.

Do you have commit access?

Jun 3 2019, 1:21 AM

May 31 2019

MikeDvorskiy created D62719: A hot fix for exclusive_scan.
May 31 2019, 1:40 AM

Apr 26 2019

MikeDvorskiy added inline comments to D59925: The optimized parallel versions of sort, stable_sort algorithms..
Apr 26 2019, 12:50 PM · Restricted Project
MikeDvorskiy updated the diff for D59925: The optimized parallel versions of sort, stable_sort algorithms..

+ "internal::" for "brick_move"

Apr 26 2019, 12:50 PM · Restricted Project
MikeDvorskiy updated the diff for D59925: The optimized parallel versions of sort, stable_sort algorithms..

Rebased of the HEAD of the master

Apr 26 2019, 7:48 AM · Restricted Project

Apr 24 2019

MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

What do you think about my last proposal regarding

Apr 24 2019, 12:48 AM · Restricted Project

Apr 23 2019

MikeDvorskiy accepted D59792: [pstl] Make the default backend be the serial backend and always provide parallel policies.
Apr 23 2019, 11:31 AM · Restricted Project, Restricted Project

Apr 22 2019

MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

But let's avoid any name/path that suggests these headers are part of the public interface of the library, because they are not

Apr 22 2019, 1:54 AM · Restricted Project

Apr 18 2019

MikeDvorskiy accepted D59791: [pstl] Add a serial backend for the PSTL.

If the problem with passing test inplace_merge.pass.cpp" is actual, I'll investigate and fix it by proposed new patch over the top your changes.

Apr 18 2019, 10:34 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.
I don't think the pstl should include headers that are useless to all but one specific shipping vehicle of the PSTL (the standalone version)
Apr 18 2019, 8:36 AM · Restricted Project
MikeDvorskiy requested changes to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

I have an issue regarding the dummy stdlib headers.
Proposed location is valid only for the test. (/test/support/stdlib)

Apr 18 2019, 1:56 AM · Restricted Project

Apr 15 2019

MikeDvorskiy added a comment to D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes.

In that case, may we "reserve" MINOR version to differ PSTL code version?

Apr 15 2019, 8:55 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes.

// The version is XYYZ, where X is major, YY is minor, and Z is patch (i.e. X.YY.Z)

Apr 15 2019, 8:32 AM · Restricted Project, Restricted Project

Apr 12 2019

MikeDvorskiy added inline comments to D59791: [pstl] Add a serial backend for the PSTL.
Apr 12 2019, 9:14 AM · Restricted Project, Restricted Project
MikeDvorskiy added inline comments to D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes.
Apr 12 2019, 8:41 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

Continuing the discussion - the code snippet of the test engine - pay your attention to using namespace __pstl::execution

Apr 12 2019, 7:33 AM · Restricted Project
MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

we should have a way to customize the namespace in which pstl injects the algorithms

Apr 12 2019, 6:42 AM · Restricted Project

Apr 11 2019

MikeDvorskiy added inline comments to D59791: [pstl] Add a serial backend for the PSTL.
Apr 11 2019, 9:05 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60525: [pstl] Fix header inclusion order failures.

Eventually, I tend to that keeping "cout" code is redundant , just "return 0" is enough.
We will try to re-config our test system to accept just returning zero;

Apr 11 2019, 8:26 AM · Restricted Project, Restricted Project
MikeDvorskiy added inline comments to D59791: [pstl] Add a serial backend for the PSTL.
Apr 11 2019, 5:25 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60464: [pstl] Setup the _PSTL_VERSION macro like _LIBCPP_VERSION, and add release notes.

I don't see any "bookmarks" (technical, and others) on scheme versioning on our side.
So, I've no objections against the proposed approach.

Apr 11 2019, 2:27 AM · Restricted Project, Restricted Project
MikeDvorskiy added a comment to D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.

Guys,
I understand that given pstl code is becoming a part of C++ standard library and , of course should be std::execution::unsequenced_policy and so on..

Apr 11 2019, 2:13 AM · Restricted Project
MikeDvorskiy added a comment to D60525: [pstl] Fix header inclusion order failures.

I have no objections in general..
But let add the line

Apr 11 2019, 1:50 AM · Restricted Project, Restricted Project

Apr 10 2019

MikeDvorskiy added inline comments to D59791: [pstl] Add a serial backend for the PSTL.
Apr 10 2019, 4:38 AM · Restricted Project, Restricted Project
MikeDvorskiy accepted D60467: [pstl] Remove our custom FindTBB CMake file.
Apr 10 2019, 1:53 AM · Restricted Project

Apr 8 2019

MikeDvorskiy added a comment to D59791: [pstl] Add a serial backend for the PSTL.

I think we all agreed that this was worth implementing

Apr 8 2019, 2:04 AM · Restricted Project, Restricted Project

Apr 4 2019

MikeDvorskiy added a comment to D59813: The other fix for equal algo.

Of course. I will configure "ninja" for running the upstream test.

Apr 4 2019, 1:17 AM

Apr 3 2019

MikeDvorskiy added a comment to D59813: The other fix for equal algo.

..no matching function for call to 'equal' return std::equal(first1, last1, first2, last2, __p);

Apr 3 2019, 10:08 AM
MikeDvorskiy updated the diff for D59813: The other fix for equal algo.

+ compilation fixes (lost "__").

Apr 3 2019, 9:27 AM
MikeDvorskiy updated the diff for D59813: The other fix for equal algo.

The lost "__" has been returned.

Apr 3 2019, 4:55 AM
MikeDvorskiy updated the diff for D59813: The other fix for equal algo.

Rebased on top of latest master (+ uglification)

Apr 3 2019, 2:56 AM

Mar 28 2019

MikeDvorskiy added a comment to D59930: Parallel STL version updated.

Yes, agree.

Mar 28 2019, 8:58 AM
MikeDvorskiy added a comment to D59930: Parallel STL version updated.

Yes,... I doubted that is relevant to LLVM release.. and so as the some other macros form pstl_config.h
But as far as pstl_config.h is, PSTL_VERSION may be useful, at least to differ major changes, I guess...

Mar 28 2019, 7:40 AM
MikeDvorskiy created D59930: Parallel STL version updated.
Mar 28 2019, 6:16 AM
MikeDvorskiy created D59925: The optimized parallel versions of sort, stable_sort algorithms..
Mar 28 2019, 3:24 AM · Restricted Project

Mar 27 2019

MikeDvorskiy updated the diff for D59813: The other fix for equal algo.
  1. Usage of std::equal with "4 iterators" (due to it is available in C++ standard library since C++14)
  2. Clang formatted
Mar 27 2019, 5:38 AM

Mar 26 2019

MikeDvorskiy added inline comments to D59813: The other fix for equal algo.
Mar 26 2019, 6:55 AM
MikeDvorskiy added a comment to D59704: Changed buffer API to receive policy instance..

At least, it "extends" signature of functions of a back-end that helps (now) to support several back-ends in the same time (by overloading).

Mar 26 2019, 5:03 AM
MikeDvorskiy added a comment to D59767: [pstl] Indent preprocessor directives as part of the clang-format rules.

a significant gain in readability

Mar 26 2019, 4:59 AM · Restricted Project
MikeDvorskiy created D59813: The other fix for equal algo.
Mar 26 2019, 4:16 AM
MikeDvorskiy added a comment to D59791: [pstl] Add a serial backend for the PSTL.

Hi Louis,

Mar 26 2019, 2:27 AM · Restricted Project, Restricted Project

Mar 25 2019

MikeDvorskiy added inline comments to D59705: Hot fix for equal algo.
Mar 25 2019, 3:29 AM · Restricted Project
MikeDvorskiy added a comment to D59704: Changed buffer API to receive policy instance..

How would you somehow handle allocation through a custom policy?

Mar 25 2019, 2:47 AM
MikeDvorskiy added inline comments to D59705: Hot fix for equal algo.
Mar 25 2019, 2:06 AM · Restricted Project

Mar 22 2019

MikeDvorskiy created D59705: Hot fix for equal algo.
Mar 22 2019, 10:10 AM · Restricted Project
MikeDvorskiy created D59704: Changed buffer API to receive policy instance..
Mar 22 2019, 10:03 AM

Mar 13 2019

MikeDvorskiy accepted D59181: Uglify backend.
Mar 13 2019, 3:10 AM

Mar 5 2019

MikeDvorskiy added a comment to D58852: Changes from integrating PSTL with libstdc++.
pstl_config.h is not required
Mar 5 2019, 5:26 AM
MikeDvorskiy added inline comments to D58852: Changes from integrating PSTL with libstdc++.
Mar 5 2019, 4:26 AM

Feb 19 2019

MikeDvorskiy accepted D57638: [pstl] Fix missing parallel policy guards.
Feb 19 2019, 3:13 AM · Restricted Project

Jan 10 2019

MikeDvorskiy added inline comments to D56139: [pstl] Fix compile errors when PARALLEL_POLICIES is disabled.
Jan 10 2019, 2:00 AM

Jan 9 2019

MikeDvorskiy added a comment to D55945: [pstl] Avoid shadowing explicit lambda capture with lambda parameter.

Yes, a captured __comp instance is redundant in the all cases here due to it is passed via argument's list explicitly.

Jan 9 2019, 1:59 AM

Dec 21 2018

MikeDvorskiy added inline comments to D55963: [pstl] Initial integration with LLVM's CMake.
Dec 21 2018, 3:25 AM