Page MenuHomePhabricator

nadiasvertex (Christopher Nelson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2020, 12:14 PM (124 w, 16 h)

Recent Activity

Nov 23 2022

nadiasvertex added a comment to D120186: [pstl] Implementation of Grand Central Dispatch backend.

No. I suppose it's been so long that it won't apply cleanly. I would really like some help getting a builder to turn this on for macOS automatically so that it can run as part of the normal test suite. I can try to carve out some time to rebase it and re-test it. I'm not really sure what anyone is waiting for...

Nov 23 2022, 5:19 AM · Restricted Project, Restricted Project

Jul 10 2022

nadiasvertex added a comment to D120186: [pstl] Implementation of Grand Central Dispatch backend.

Fixed some additional comments.

Jul 10 2022, 11:03 AM · Restricted Project, Restricted Project
nadiasvertex updated the diff for D120186: [pstl] Implementation of Grand Central Dispatch backend.

[pstl] More ADL guards

Jul 10 2022, 11:00 AM · Restricted Project, Restricted Project
nadiasvertex updated the diff for D120186: [pstl] Implementation of Grand Central Dispatch backend.

[pstl] Fix minor nit

Jul 10 2022, 9:17 AM · Restricted Project, Restricted Project
nadiasvertex added inline comments to D120186: [pstl] Implementation of Grand Central Dispatch backend.
Jul 10 2022, 9:16 AM · Restricted Project, Restricted Project

May 11 2022

nadiasvertex updated subscribers of D120186: [pstl] Implementation of Grand Central Dispatch backend.

@MikeDvorskiy could you look at this patch, please? Thank you!

May 11 2022, 7:46 AM · Restricted Project, Restricted Project

Mar 12 2022

nadiasvertex added inline comments to D120186: [pstl] Implementation of Grand Central Dispatch backend.
Mar 12 2022, 7:58 AM · Restricted Project, Restricted Project
nadiasvertex updated the diff for D120186: [pstl] Implementation of Grand Central Dispatch backend.

Add the __tag parameter, and address comments about ADL and a bad assertion.

Mar 12 2022, 7:57 AM · Restricted Project, Restricted Project

Feb 19 2022

nadiasvertex requested review of D120186: [pstl] Implementation of Grand Central Dispatch backend.
Feb 19 2022, 6:12 AM · Restricted Project, Restricted Project

Oct 26 2021

nadiasvertex accepted D112528: A hot compilation fix for MacOS, OpenMP backend; + full qualified names for some internal functions.

LGTM

Oct 26 2021, 5:22 AM · Restricted Project, Restricted Project

Oct 20 2021

nadiasvertex accepted D112125: A hot fix for a reduction parallel pattern of OpenMP backend.

Thank you! I fixed that bug once, but in the various changes I missed it the last time.

Oct 20 2021, 11:34 AM · Restricted Project

Oct 14 2021

nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

Resolved all outstanding comments.

Oct 14 2021, 7:58 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Fix the header guards naming standard. Also remove ::std uses.

Oct 14 2021, 7:56 AM · Restricted Project

Oct 9 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Undo clang-format of pstl_config.h.

Oct 9 2021, 7:22 AM · Restricted Project

Oct 6 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Fix libc++ compile issues.

Oct 6 2021, 7:08 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Fix typo

Oct 6 2021, 6:16 AM · Restricted Project
nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

Addressed all known concerns with the last patch.

Oct 6 2021, 5:44 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Remove this _Size alias in parallel_transform_reduce

Oct 6 2021, 5:42 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Rename the config key to _PSTL_PAR_BACKEND_OPENMP.
Remove redundant parentheses.
Fix merge artifacts.

Oct 6 2021, 5:36 AM · Restricted Project

Oct 5 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Add come comments, minor formatting changes.

Oct 5 2021, 6:49 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Apply the clang-format changes from CI.

Oct 5 2021, 6:32 AM · Restricted Project

Oct 4 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Fix additional uses of std::distance() and remove serial fallbacks.

Oct 4 2021, 12:31 PM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Remove copyright.

Oct 4 2021, 12:12 PM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Minor compilation fixes from typos.

Oct 4 2021, 12:07 PM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Fix pstl for removal of std::result_of (use std::invoke_result)

Oct 4 2021, 11:38 AM · Restricted Project
nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

Commented on, and marked many reviews as fixed.

Oct 4 2021, 11:21 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Add changes from review by rarutyan.

Oct 4 2021, 11:21 AM · Restricted Project

Oct 1 2021

nadiasvertex added inline comments to D99836: [pstl] Implement OpenMP backend.
Oct 1 2021, 8:27 AM · Restricted Project

Sep 26 2021

nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

All of the serious comments were addressed. The nits were style differences I disagree with. :-) If these nits are LLVM required style I will adjust them.

Sep 26 2021, 10:10 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

This update applies changes suggested by MikeDvorskiy's review.

Sep 26 2021, 9:55 AM · Restricted Project

Sep 10 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

[pstl][omp] Fix header file movement

Sep 10 2021, 8:26 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

[pstl][omp] Fix clang-tidy header guard warnings

Sep 10 2021, 8:04 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

[pstl][omp] Add 'omp' option to list

Sep 10 2021, 6:44 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

[pstl][omp] Rework patch to pacify clang-tidy

Sep 10 2021, 6:33 AM · Restricted Project

Sep 9 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Disable lint checks

Sep 9 2021, 10:53 AM · Restricted Project

Sep 7 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Perform clang-format

Sep 7 2021, 8:22 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Another attempt at fixing the broken patch.

Sep 7 2021, 4:20 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

The previous patch was somehow broken. I have regenerated it.

Sep 7 2021, 4:13 AM · Restricted Project

Sep 2 2021

nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Update the linker script for parallel STL.

Sep 2 2021, 6:35 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

Adds the "omp" entry into the PSTL CMakeLists.txt

Sep 2 2021, 5:57 AM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

This patch brings in fixes made in the oneDPL project. All unit tests in oneDPL now pass.

Sep 2 2021, 5:42 AM · Restricted Project

Aug 31 2021

nadiasvertex abandoned D99849: [pstl] Fix a number of bugs with parallel partial sort.

This work will continue on https://reviews.llvm.org/D99836

Aug 31 2021, 7:35 AM · Restricted Project

Jun 15 2021

nadiasvertex updated the summary of D99836: [pstl] Implement OpenMP backend.
Jun 15 2021, 5:21 AM · Restricted Project

Jun 14 2021

nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

Resolved all review comments.

Jun 14 2021, 2:45 PM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

This corrects all known problems in the parallel partial sort implementation. The parallel merge algorithm still needs implementing.

Jun 14 2021, 2:44 PM · Restricted Project

Apr 3 2021

nadiasvertex added inline comments to D99849: [pstl] Fix a number of bugs with parallel partial sort.
Apr 3 2021, 4:49 PM · Restricted Project
nadiasvertex requested review of D99849: [pstl] Fix a number of bugs with parallel partial sort.
Apr 3 2021, 2:37 PM · Restricted Project
nadiasvertex requested review of D99836: [pstl] Implement OpenMP backend.
Apr 3 2021, 5:07 AM · Restricted Project