This is an archive of the discontinued LLVM Phabricator instance.

Differential D119793

[SelectionDAG] Add SPLAT_VECTOR to SelectionDAG::isConstantFPBuildVectorOrConstantFP.
ClosedPublic

Authored by craig.topper on Feb 14 2022, 3:53 PM.

Details

Reviewers
efriedma
sdesmalen
frasercrmck
spatel
RKSimon
Commits
rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG…
Summary

Matches what is done for the int version.

Diff Detail

Unit TestsFailed

TimeTest
60,300 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
60,310 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
60,290 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c
60,340 msx64 debian > Clang.Driver::arm-cortex-cpus.c

Event Timeline

craig.topper created this revision.Feb 14 2022, 3:53 PM
Herald added subscribers: ecnelises, hiraditya. · View Herald TranscriptFeb 14 2022, 3:53 PM
craig.topper requested review of this revision.Feb 14 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 3:53 PM
craig.topper added reviewers: spatel, RKSimon.Feb 14 2022, 4:19 PM
Harbormaster completed remote builds in B149554: Diff 408659.Feb 14 2022, 5:17 PM
craig.topper updated this revision to Diff 408982.Feb 15 2022, 11:37 AM

Add test case for simplifying fmul with 1.0.

Herald added subscribers: • pcwang-thead, luismarques, apazos and 19 others. · View Herald TranscriptFeb 15 2022, 11:37 AM
Harbormaster completed remote builds in B149776: Diff 408982.Feb 15 2022, 1:24 PM
sdesmalen accepted this revision.Feb 15 2022, 1:25 PM

Thanks, LGTM!

This revision is now accepted and ready to land.Feb 15 2022, 1:25 PM
Closed by commit rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG… (authored by craig.topper). · Explain WhyFeb 16 2022, 9:22 AM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG….

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
4 lines

Diff 408659

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
//===- SelectionDAG.cpp - Implement the SelectionDAG data structures ------===// //===- SelectionDAG.cpp - Implement the SelectionDAG data structures ------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 11,093 Lines • ▼ Show 20 Lines
// or constant float. // or constant float.
SDNode *SelectionDAG::isConstantFPBuildVectorOrConstantFP(SDValue N) const { SDNode *SelectionDAG::isConstantFPBuildVectorOrConstantFP(SDValue N) const {
if (isa<ConstantFPSDNode>(N)) if (isa<ConstantFPSDNode>(N))
return N.getNode(); return N.getNode();
if (ISD::isBuildVectorOfConstantFPSDNodes(N.getNode())) if (ISD::isBuildVectorOfConstantFPSDNodes(N.getNode()))
return N.getNode(); return N.getNode();
if ((N.getOpcode() == ISD::SPLAT_VECTOR) &&
isa<ConstantFPSDNode>(N.getOperand(0)))
return N.getNode();
return nullptr; return nullptr;
} }
void SelectionDAG::createOperands(SDNode *Node, ArrayRef<SDValue> Vals) { void SelectionDAG::createOperands(SDNode *Node, ArrayRef<SDValue> Vals) {
assert(!Node->OperandList && "Node already has operands"); assert(!Node->OperandList && "Node already has operands");
assert(SDNode::getMaxNumOperands() >= Vals.size() && assert(SDNode::getMaxNumOperands() >= Vals.size() &&
"too many operands to fit into SDNode"); "too many operands to fit into SDNode");
SDUse *Ops = OperandRecycler.allocate( SDUse *Ops = OperandRecycler.allocate(
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines