This is an archive of the discontinued LLVM Phabricator instance.

Differential D119793

[SelectionDAG] Add SPLAT_VECTOR to SelectionDAG::isConstantFPBuildVectorOrConstantFP.
ClosedPublic

Authored by craig.topper on Feb 14 2022, 3:53 PM.

Details

Reviewers
efriedma
sdesmalen
frasercrmck
spatel
RKSimon
Commits
rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG…
Summary

Matches what is done for the int version.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 14 2022, 3:53 PM
Herald added subscribers: ecnelises, hiraditya. · View Herald TranscriptFeb 14 2022, 3:53 PM
craig.topper requested review of this revision.Feb 14 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 3:53 PM
craig.topper added reviewers: spatel, RKSimon.Feb 14 2022, 4:19 PM
Harbormaster completed remote builds in B149554: Diff 408659.Feb 14 2022, 5:17 PM
craig.topper updated this revision to Diff 408982.Feb 15 2022, 11:37 AM

Add test case for simplifying fmul with 1.0.

Herald added subscribers: • pcwang-thead, luismarques, apazos and 19 others. · View Herald TranscriptFeb 15 2022, 11:37 AM
Harbormaster completed remote builds in B149776: Diff 408982.Feb 15 2022, 1:24 PM
sdesmalen accepted this revision.Feb 15 2022, 1:25 PM

Thanks, LGTM!

This revision is now accepted and ready to land.Feb 15 2022, 1:25 PM
Closed by commit rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG… (authored by craig.topper). · Explain WhyFeb 16 2022, 9:22 AM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG1daa66d3fda9: [SelectionDAG] Add SPLAT_VECTOR to SelectionDAG….

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
4 lines
test/
CodeGen/
RISCV/
rvv/
22 lines

Diff 409294

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 11,111 Lines • ▼ Show 20 Lines
// or constant float. // or constant float.
SDNode *SelectionDAG::isConstantFPBuildVectorOrConstantFP(SDValue N) const { SDNode *SelectionDAG::isConstantFPBuildVectorOrConstantFP(SDValue N) const {
if (isa<ConstantFPSDNode>(N)) if (isa<ConstantFPSDNode>(N))
return N.getNode(); return N.getNode();
if (ISD::isBuildVectorOfConstantFPSDNodes(N.getNode())) if (ISD::isBuildVectorOfConstantFPSDNodes(N.getNode()))
return N.getNode(); return N.getNode();
if ((N.getOpcode() == ISD::SPLAT_VECTOR) &&
isa<ConstantFPSDNode>(N.getOperand(0)))
return N.getNode();
return nullptr; return nullptr;
} }
void SelectionDAG::createOperands(SDNode *Node, ArrayRef<SDValue> Vals) { void SelectionDAG::createOperands(SDNode *Node, ArrayRef<SDValue> Vals) {
assert(!Node->OperandList && "Node already has operands"); assert(!Node->OperandList && "Node already has operands");
assert(SDNode::getMaxNumOperands() >= Vals.size() && assert(SDNode::getMaxNumOperands() >= Vals.size() &&
"too many operands to fit into SDNode"); "too many operands to fit into SDNode");
SDUse *Ops = OperandRecycler.allocate( SDUse *Ops = OperandRecycler.allocate(
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines

llvm/test/CodeGen/RISCV/rvv/combine-splats.ll

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines; CHECK-NEXT: ret
%ins1 = insertelement <vscale x 8 x i16> poison, i16 2, i32 0 %ins1 = insertelement <vscale x 8 x i16> poison, i16 2, i32 0
%splat1 = shufflevector <vscale x 8 x i16> %ins1, <vscale x 8 x i16> poison, <vscale x 8 x i32> zeroinitializer %splat1 = shufflevector <vscale x 8 x i16> %ins1, <vscale x 8 x i16> poison, <vscale x 8 x i32> zeroinitializer
%ins2 = insertelement <vscale x 8 x i16> poison, i16 4, i32 0 %ins2 = insertelement <vscale x 8 x i16> poison, i16 4, i32 0
%splat2 = shufflevector <vscale x 8 x i16> %ins2, <vscale x 8 x i16> poison, <vscale x 8 x i32> zeroinitializer %splat2 = shufflevector <vscale x 8 x i16> %ins2, <vscale x 8 x i16> poison, <vscale x 8 x i32> zeroinitializer
%v1 = lshr <vscale x 8 x i16> %x, %splat2 %v1 = lshr <vscale x 8 x i16> %x, %splat2
%v2 = lshr <vscale x 8 x i16> %v1, %splat2 %v2 = lshr <vscale x 8 x i16> %v1, %splat2
ret <vscale x 8 x i16> %v2 ret <vscale x 8 x i16> %v2
} }
; fold (fmul x, 1.0) -> x
define <vscale x 2 x float> @combine_fmul_one(<vscale x 2 x float> %x) {
; CHECK-LABEL: combine_fmul_one:
; CHECK: # %bb.0:
; CHECK-NEXT: ret
%ins = insertelement <vscale x 2 x float> poison, float 1.0, i32 0
%splat = shufflevector <vscale x 2 x float> %ins, <vscale x 2 x float> poison, <vscale x 2 x i32> zeroinitializer
%v = fmul <vscale x 2 x float> %x, %splat
ret <vscale x 2 x float> %v
}
; fold (fmul 1.0, x) -> x
define <vscale x 2 x float> @combine_fmul_one_commuted(<vscale x 2 x float> %x) {
; CHECK-LABEL: combine_fmul_one_commuted:
; CHECK: # %bb.0:
; CHECK-NEXT: ret
%ins = insertelement <vscale x 2 x float> poison, float 1.0, i32 0
%splat = shufflevector <vscale x 2 x float> %ins, <vscale x 2 x float> poison, <vscale x 2 x i32> zeroinitializer
%v = fmul <vscale x 2 x float> %splat, %x
ret <vscale x 2 x float> %v
}