This is an archive of the discontinued LLVM Phabricator instance.

[clang][CMake] Add a warning about the Standalone build being deprecated
AbandonedPublic

Authored by MaskRay on Feb 9 2022, 3:48 PM.

Details

Summary

For me, cmake -Hclang -B/path/to/build currently fails with

CMake Error at CMakeLists.txt:122 (include):
  include could not find requested file:

    GetErrcMessages

-- Found Python3: /usr/bin/python3.9 (found version "3.9.9") found components: Interpreter
CMake Error at /home/maskray/llvm/llvm/utils/llvm-lit/CMakeLists.txt:13 (make_paths_relative):
  Unknown CMake command "make_paths_relative".

Keeping the Standalone build working is now quite a bit of hassle and to
the best of my knowledge not any active contributor typically does. Let's
follow libc++/libc++abi/libunwind (D119341), deprecate and remove the build
mode. We will be able to remove much code related to CLANG_BUILT_STANDALONE.

To keep the disruption minimum, use message(WARNING ... for release/14.x and
message(FATAL_ERROR ... for main.

Similar to D119380 for lld.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 9 2022, 3:48 PM
MaskRay requested review of this revision.Feb 9 2022, 3:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 3:48 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.Feb 9 2022, 3:49 PM
clang/CMakeLists.txt
16

For the main branch, we can delete this block.

tstellar requested changes to this revision.Feb 9 2022, 7:00 PM

I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to start a thread on Discourse so we can try to find a solution that works for everyone.

This revision now requires changes to proceed.Feb 9 2022, 7:00 PM

I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to start a thread on Discourse so we can try to find a solution that works for everyone.

I created https://discourse.llvm.org/t/standalone-build-for-clang-lld-fix-or-remove/59977

MaskRay abandoned this revision.Aug 18 2022, 4:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 4:29 PM
Herald added a subscriber: StephenFan. · View Herald Transcript