Page MenuHomePhabricator

clang-tools-extra: Make test dependency on LLVMHello optional
Needs ReviewPublic

Authored by tstellar on Feb 21 2022, 10:37 PM.

Details

Reviewers
vtjnash
Summary

This fixes clang + clang-tools-extra standalone build after
36892727e4f19a60778e371d78f8fb09d8122c85.

Diff Detail

Event Timeline

tstellar created this revision.Feb 21 2022, 10:37 PM
tstellar requested review of this revision.Feb 21 2022, 10:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2022, 10:37 PM

Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate?

Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate?

Seems that D119383 that is not favored by Gentoo and RedHat.
I do not know whether we will be able to remove the standalone build mode.

@vtjnash There hasn't been consensus on removing support for standalone builds yet, and I'm in favor of keeping them as are some other distribution maintainers.

Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 8:04 AM
nikic added a subscriber: nikic.May 9 2022, 11:51 AM
nikic added inline comments.
clang-tools-extra/test/CMakeLists.txt
107

Shouldn't this be LLVMHello?

tstellar marked an inline comment as done.Jul 1 2022, 9:19 PM