This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add type conversion for !fir.box<none>
ClosedPublic

Authored by clementval on Feb 9 2022, 5:14 AM.

Details

Summary

none is used in fir.box type to specify a polymorphic type.
This patch add the conversion from !fir.box<none> to LLVM.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Jean Perier <jperier@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Feb 9 2022, 5:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
clementval requested review of this revision.Feb 9 2022, 5:14 AM
ftynse added inline comments.Feb 9 2022, 5:16 AM
mlir/test/Conversion/StandardToLLVM/convert-types.mlir
35 ↗(On Diff #407125)

Spurious change.

awarzynski added inline comments.Feb 9 2022, 5:20 AM
flang/test/Fir/types-to-llvm.fir
428
clementval marked 2 inline comments as done.Feb 9 2022, 5:25 AM
clementval added inline comments.
flang/test/Fir/types-to-llvm.fir
428

Good catch!

mlir/test/Conversion/StandardToLLVM/convert-types.mlir
35 ↗(On Diff #407125)

My bad. Sorry for the noise.

clementval updated this revision to Diff 407126.Feb 9 2022, 5:25 AM
clementval marked 2 inline comments as done.

Address comments

Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 5:25 AM
ftynse resigned from this revision.Feb 9 2022, 5:29 AM
awarzynski accepted this revision.Feb 9 2022, 5:31 AM

LGTM, thanks!

flang/test/Fir/types-to-llvm.fir
424

Incomplete comment :)

This revision is now accepted and ready to land.Feb 9 2022, 5:31 AM
This revision was automatically updated to reflect the committed changes.