This is an archive of the discontinued LLVM Phabricator instance.

[Spill2Reg][7/9] MBB live-ins are now being updated.
Needs ReviewPublic

Authored by vporpo on Jan 26 2022, 5:58 PM.

Details

Reviewers
Carrot
arsenm
Summary

This patch implements updates for the MBB live-ins due to the newly introduced
instructions emitted by spill2reg.
This is required for correct tracking of live register usage.

Diff Detail

Event Timeline

vporpo created this revision.Jan 26 2022, 5:58 PM
vporpo requested review of this revision.Jan 26 2022, 5:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2022, 5:58 PM
wxiao3 added a subscriber: wxiao3.Jan 26 2022, 7:19 PM
vporpo updated this revision to Diff 405813.Feb 3 2022, 3:10 PM

Updated tests.

vporpo retitled this revision from [Spill2Reg] MBB live-ins are now being updated. to [Spill2Reg][7/9] MBB live-ins are now being updated..Feb 4 2022, 9:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 12:06 PM
Herald added a subscriber: wdng. · View Herald Transcript
Carrot added inline comments.Aug 2 2022, 4:32 PM
llvm/lib/CodeGen/Spill2Reg.cpp
329

If the reload and spill are in the same BB, like

bb6:
     spill  stack.0
     reload stack.0

does it adds VectorReg to LiveIn?

vporpo added inline comments.Aug 2 2022, 4:53 PM
llvm/lib/CodeGen/Spill2Reg.cpp
329

No, because ReloadData.IsLiveIn is false (set earlier in line 224), so the code will not reach line 328 in this case.
I will add comments to explain this.

vporpo updated this revision to Diff 449492.Aug 2 2022, 5:18 PM

Updated comments.