Page MenuHomePhabricator

wxiao3 (Wei Xiao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 17 2019, 12:43 AM (18 w, 1 d)

Recent Activity

Yesterday

wxiao3 added a comment to D61224: Fix i386 stack alignment for parameter type with breakdowns.

No, in most normal operation for x86_32, LLVM does the wrong thing. A simple example to show the ABI bug:

Thu, May 23, 7:28 AM · Restricted Project

Tue, May 14

wxiao3 added a comment to D61224: Fix i386 stack alignment for parameter type with breakdowns.

Hi all,

Tue, May 14, 2:47 AM · Restricted Project

Mon, May 13

wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Yes, the ABI bug will cause SEGV in Linux where a lot of libraries are built by GCC.
I have restricted the fix to Linux only in the latest revision.

Mon, May 13, 8:34 PM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Mon, May 13, 8:28 PM · Restricted Project
wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Any other comments?

Mon, May 13, 3:49 AM · Restricted Project
wxiao3 added inline comments to D59744: Fix i386 ABI "__m64" type bug.
Mon, May 13, 3:47 AM · Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Mon, May 13, 3:38 AM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Mon, May 13, 3:38 AM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Mon, May 13, 3:38 AM · Restricted Project

Sat, Apr 27

wxiao3 updated the summary of D61224: Fix i386 stack alignment for parameter type with breakdowns.
Sat, Apr 27, 8:24 AM · Restricted Project
wxiao3 created D61224: Fix i386 stack alignment for parameter type with breakdowns.
Sat, Apr 27, 8:22 AM · Restricted Project
wxiao3 added inline comments to D59744: Fix i386 ABI "__m64" type bug.
Sat, Apr 27, 8:08 AM · Restricted Project
wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Ok, I have excluded Darwin and PS4 for the changes.
The fix mainly targets at Linux so that we can compile a project with parts by GCC and parts by LLVM given that they follow the same ABI.

Sat, Apr 27, 7:50 AM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Sat, Apr 27, 7:43 AM · Restricted Project

Apr 17 2019

wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 17 2019, 6:37 PM · Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 17 2019, 6:25 PM · Restricted Project

Apr 15 2019

wxiao3 created D60748: Fix i386 struct and union parameter alignment.
Apr 15 2019, 7:35 PM · Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 15 2019, 7:26 PM · Restricted Project

Apr 14 2019

wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 14 2019, 11:00 PM · Restricted Project

Apr 3 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Dear reviewers, any comments?

Apr 3 2019, 7:37 PM · Restricted Project

Mar 24 2019

wxiao3 updated the summary of D59744: Fix i386 ABI "__m64" type bug.
Mar 24 2019, 1:10 AM · Restricted Project

Mar 23 2019

wxiao3 created D59744: Fix i386 ABI "__m64" type bug.
Mar 23 2019, 9:08 PM · Restricted Project

Feb 26 2019

wxiao3 added inline comments to D57643: [X86] Fix bug in vectorcall calling convention.
Feb 26 2019, 1:29 AM · Restricted Project
wxiao3 updated the diff for D57643: [X86] Fix bug in vectorcall calling convention.
Feb 26 2019, 1:29 AM · Restricted Project

Feb 20 2019

wxiao3 added a comment to D57643: [X86] Fix bug in vectorcall calling convention.

I have updated the patch so that we don't have to enumerate all the X,Y,Z cases and inevitable W someday in the future. Is it ok for merge?

Feb 20 2019, 11:21 PM · Restricted Project
wxiao3 updated the diff for D57643: [X86] Fix bug in vectorcall calling convention.
Feb 20 2019, 11:20 PM · Restricted Project

Feb 2 2019

wxiao3 added reviewers for D57643: [X86] Fix bug in vectorcall calling convention: craig.topper, annita.zhang, smaslov, rnk, LuoYuanke.
Feb 2 2019, 6:44 PM · Restricted Project
wxiao3 updated the summary of D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:42 PM · Restricted Project
wxiao3 updated the summary of D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:39 PM · Restricted Project
wxiao3 created D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:37 PM · Restricted Project

Jan 17 2019

wxiao3 added a comment to D56275: x86 interrupt calling convention: Fix argument offsets.

I have narrowed the issue to a small test case as below and hope it can help you it:

Jan 17 2019, 6:17 PM