Page MenuHomePhabricator

wxiao3 (Wei Xiao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 17 2019, 12:43 AM (26 w, 21 h)

Recent Activity

Jun 18 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Can anyone provide me some small reproducers code for the issue tripped over by Chromium / Skia?

Jun 18 2019, 10:11 PM · Restricted Project, Restricted Project
wxiao3 added a comment to D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.

Yes, there is a test to ensure that Darwin defaults to the old behaviour in "test/CodeGen/x86_32-m64.c".

Jun 18 2019, 12:01 AM · Restricted Project
wxiao3 updated the diff for D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.
Jun 18 2019, 12:01 AM · Restricted Project

Jun 17 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

I have created a patch for you: https://reviews.llvm.org/D63473
Is it ok?

Jun 17 2019, 8:51 PM · Restricted Project, Restricted Project
wxiao3 created D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.
Jun 17 2019, 8:51 PM · Restricted Project
wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Please make sure all Chromium for 32-bit Linux libraries are following System V ABI (i.e., m64 is passed on mmx register). I suspect that there are some hand written assembly code in your libraries which is not following the ABI.

Jun 17 2019, 6:12 PM · Restricted Project, Restricted Project

Jun 11 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Thanks for the comments!
Updated for landing.

Jun 11 2019, 6:11 PM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Jun 11 2019, 6:08 PM · Restricted Project, Restricted Project
wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Thanks for the suggestions!
I have updated it.

Jun 11 2019, 7:09 AM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Jun 11 2019, 7:06 AM · Restricted Project, Restricted Project

Jun 6 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Thanks for the suggestions!
I have updated the patch accordingly.

Jun 6 2019, 9:41 PM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Jun 6 2019, 9:38 PM · Restricted Project, Restricted Project
wxiao3 added a reviewer for D59744: Fix i386 ABI "__m64" type bug: joerg.
Jun 6 2019, 9:38 PM · Restricted Project, Restricted Project

Jun 3 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing needed is to add a flag (like "IsLinuxABI" ) to enable it.

Jun 3 2019, 7:13 AM · Restricted Project, Restricted Project

Jun 1 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Hi all,

Jun 1 2019, 8:07 PM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Jun 1 2019, 7:54 PM · Restricted Project, Restricted Project
wxiao3 added a reviewer for D59744: Fix i386 ABI "__m64" type bug: krytarowski.
Jun 1 2019, 7:51 PM · Restricted Project, Restricted Project
wxiao3 added a reviewer for D59744: Fix i386 ABI "__m64" type bug: rjmccall.
Jun 1 2019, 7:50 PM · Restricted Project, Restricted Project

May 30 2019

wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Thanks for the information!
We have reverted the patch and will resubmit it when we have a complete fix.

May 30 2019, 7:40 PM · Restricted Project

May 28 2019

wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Ok for merge now?

May 28 2019, 1:28 AM · Restricted Project

May 23 2019

wxiao3 added a comment to D61224: Fix i386 stack alignment for parameter type with breakdowns.

No, in most normal operation for x86_32, LLVM does the wrong thing. A simple example to show the ABI bug:

May 23 2019, 7:28 AM · Restricted Project

May 14 2019

wxiao3 added a comment to D61224: Fix i386 stack alignment for parameter type with breakdowns.

Hi all,

May 14 2019, 2:47 AM · Restricted Project

May 13 2019

wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Yes, the ABI bug will cause SEGV in Linux where a lot of libraries are built by GCC.
I have restricted the fix to Linux only in the latest revision.

May 13 2019, 8:34 PM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
May 13 2019, 8:28 PM · Restricted Project
wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Any other comments?

May 13 2019, 3:49 AM · Restricted Project
wxiao3 added inline comments to D59744: Fix i386 ABI "__m64" type bug.
May 13 2019, 3:47 AM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
May 13 2019, 3:38 AM · Restricted Project, Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
May 13 2019, 3:38 AM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
May 13 2019, 3:38 AM · Restricted Project

Apr 27 2019

wxiao3 updated the summary of D61224: Fix i386 stack alignment for parameter type with breakdowns.
Apr 27 2019, 8:24 AM · Restricted Project
wxiao3 created D61224: Fix i386 stack alignment for parameter type with breakdowns.
Apr 27 2019, 8:22 AM · Restricted Project
wxiao3 added inline comments to D59744: Fix i386 ABI "__m64" type bug.
Apr 27 2019, 8:08 AM · Restricted Project, Restricted Project
wxiao3 added a comment to D60748: Fix i386 struct and union parameter alignment.

Ok, I have excluded Darwin and PS4 for the changes.
The fix mainly targets at Linux so that we can compile a project with parts by GCC and parts by LLVM given that they follow the same ABI.

Apr 27 2019, 7:50 AM · Restricted Project
wxiao3 updated the diff for D60748: Fix i386 struct and union parameter alignment.
Apr 27 2019, 7:43 AM · Restricted Project

Apr 17 2019

wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 17 2019, 6:37 PM · Restricted Project, Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 17 2019, 6:25 PM · Restricted Project, Restricted Project

Apr 15 2019

wxiao3 created D60748: Fix i386 struct and union parameter alignment.
Apr 15 2019, 7:35 PM · Restricted Project
wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 15 2019, 7:26 PM · Restricted Project, Restricted Project

Apr 14 2019

wxiao3 updated the diff for D59744: Fix i386 ABI "__m64" type bug.
Apr 14 2019, 11:00 PM · Restricted Project, Restricted Project

Apr 3 2019

wxiao3 added a comment to D59744: Fix i386 ABI "__m64" type bug.

Dear reviewers, any comments?

Apr 3 2019, 7:37 PM · Restricted Project, Restricted Project

Mar 24 2019

wxiao3 updated the summary of D59744: Fix i386 ABI "__m64" type bug.
Mar 24 2019, 1:10 AM · Restricted Project, Restricted Project

Mar 23 2019

wxiao3 created D59744: Fix i386 ABI "__m64" type bug.
Mar 23 2019, 9:08 PM · Restricted Project, Restricted Project

Feb 26 2019

wxiao3 added inline comments to D57643: [X86] Fix bug in vectorcall calling convention.
Feb 26 2019, 1:29 AM · Restricted Project
wxiao3 updated the diff for D57643: [X86] Fix bug in vectorcall calling convention.
Feb 26 2019, 1:29 AM · Restricted Project

Feb 20 2019

wxiao3 added a comment to D57643: [X86] Fix bug in vectorcall calling convention.

I have updated the patch so that we don't have to enumerate all the X,Y,Z cases and inevitable W someday in the future. Is it ok for merge?

Feb 20 2019, 11:21 PM · Restricted Project
wxiao3 updated the diff for D57643: [X86] Fix bug in vectorcall calling convention.
Feb 20 2019, 11:20 PM · Restricted Project

Feb 2 2019

wxiao3 added reviewers for D57643: [X86] Fix bug in vectorcall calling convention: craig.topper, annita.zhang, smaslov, rnk, LuoYuanke.
Feb 2 2019, 6:44 PM · Restricted Project
wxiao3 updated the summary of D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:42 PM · Restricted Project
wxiao3 updated the summary of D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:39 PM · Restricted Project
wxiao3 created D57643: [X86] Fix bug in vectorcall calling convention.
Feb 2 2019, 6:37 PM · Restricted Project

Jan 17 2019

wxiao3 added a comment to D56275: x86 interrupt calling convention: Fix argument offsets.

I have narrowed the issue to a small test case as below and hope it can help you it:

Jan 17 2019, 6:17 PM