Page MenuHomePhabricator

Carrot (Guozhi Wei)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2015, 3:50 PM (402 w, 3 d)

Recent Activity

Yesterday

Carrot committed rGa72162cc529c: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities (authored by Carrot).
[AARCH64] Enable STORE of v4i8 to help more vectorization opportunities
Fri, Mar 31, 10:04 AM · Restricted Project, Restricted Project
Carrot closed D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.
Fri, Mar 31, 10:03 AM · Restricted Project, Restricted Project

Wed, Mar 29

Carrot updated the diff for D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

Thanks for the review! Will commit this version.

Wed, Mar 29, 2:15 PM · Restricted Project, Restricted Project

Mon, Mar 27

Carrot added a comment to D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

X86 backend also set store of v4i8 as custom. We have similar capability for v4i8.

I can also add a real custom way of lowering store of v4i8 as following. It's more simple and natural than storing of v4i16.

t2: i32 = bitcast t1:v4i8
t3: ch = store<store (s32) into %somewhere> t10, t2, address

But v4i8 is not a legal type, so we can't see a store v4i8 dag node, so it looks not necessary.

I believe that X86 will treat vector lanes differently to Arm/AArch64. For smaller types the vector will be widened by adding more elements (v4i8 [a,b,c,d] will become v8i8 [a,b,c,d,u,u,u,u]) as opposed to being promoted under aarch64 to larger sizes (v4i8 is promoted to v4i16, with the top half of each lane unused). They can both have their advantages and disadvantages. With SVE having t/b instructions the promotion can make more sense, and it is good to keep SVE and NEON inline. The same is true under MVE which only has 128bit vectors so more types are promoted, but this plays nicely into the how the t/b instructions operate.

Mon, Mar 27, 1:23 PM · Restricted Project, Restricted Project
Carrot updated the diff for D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

Override getStoreMinimumVF to support vectorization of store v4i8 for AArch64.

Mon, Mar 27, 1:22 PM · Restricted Project, Restricted Project

Wed, Mar 22

Carrot added a comment to D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

X86 backend also set store of v4i8 as custom. We have similar capability for v4i8.

Wed, Mar 22, 12:40 PM · Restricted Project, Restricted Project

Tue, Mar 21

Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

@nikic, the original version of this patch is 0.07% slower because more triggered optimizations caused more iterations on huge functions.
http://llvm-compile-time-tracker.com/compare.php?from=d38d6065584ee5dd837e9a629f90c731d8a7dffc&to=94fc2022ff32b63d6c744d3eeff4f304e1a81618&stat=instructions:u

Tue, Mar 21, 6:35 PM · Restricted Project, Restricted Project

Mon, Mar 20

Carrot added a comment to D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

ping

Mon, Mar 20, 2:00 PM · Restricted Project, Restricted Project

Fri, Mar 10

Carrot added a comment to D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.

I tried isTruncStoreLegalOrCustom and it works, generates the same code as my patch. The final code is

Fri, Mar 10, 11:34 AM · Restricted Project, Restricted Project

Wed, Mar 8

Carrot requested review of D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities.
Wed, Mar 8, 2:02 PM · Restricted Project, Restricted Project

Mar 2 2023

Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

Current compile time change
http://llvm-compile-time-tracker.com/compare.php?from=c8e5354f0063b090b6fa7ad4cfc2b9df78038454&to=d21dbfa65423bbd9251ab5948f6cc1baa2db61c8&stat=instructions:u

Mar 2 2023, 5:23 PM · Restricted Project, Restricted Project

Feb 24 2023

Carrot updated the diff for D141712: [GVN] Improve PRE on load instructions.

To improve compile time, now I record the basic blocks contain dead load instructions, at the end of the same iteration, process these blocks again to delete load instructions. So we can avoid the extra iteration on the whole function.

Feb 24 2023, 4:23 PM · Restricted Project, Restricted Project

Feb 23 2023

Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

In private email communication, @hans told me he couldn't find any problem in his optimized code, and his fail disappeared after updating his source code. So there is no known problem with this version.

Feb 23 2023, 5:42 PM · Restricted Project, Restricted Project

Feb 14 2023

Carrot abandoned D143954: [ValueTracking] It is not safe to execute FDIV/FREM speculatively.
Feb 14 2023, 7:53 PM · Restricted Project, Restricted Project

Feb 13 2023

Carrot added inline comments to D143954: [ValueTracking] It is not safe to execute FDIV/FREM speculatively.
Feb 13 2023, 3:40 PM · Restricted Project, Restricted Project
Carrot requested review of D143954: [ValueTracking] It is not safe to execute FDIV/FREM speculatively.
Feb 13 2023, 2:56 PM · Restricted Project, Restricted Project

Feb 2 2023

Carrot updated the diff for D141712: [GVN] Improve PRE on load instructions.

Check for implicit control flow instruction in function findLoadToHoistIntoPred, so we can avoid moving load across unexpected control flow.

Feb 2 2023, 8:10 PM · Restricted Project, Restricted Project
Carrot reopened D141712: [GVN] Improve PRE on load instructions.
Feb 2 2023, 8:08 PM · Restricted Project, Restricted Project
Carrot abandoned D143222: [GVN] Improve PRE on load instructions.
Feb 2 2023, 8:06 PM · Restricted Project, Restricted Project
Carrot requested review of D143222: [GVN] Improve PRE on load instructions.
Feb 2 2023, 3:27 PM · Restricted Project, Restricted Project

Feb 1 2023

Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

It's reverted now. Thanks for the test case. Will improve it in another version.

Feb 1 2023, 2:50 PM · Restricted Project, Restricted Project
Carrot added a reverting change for rG5f1448fe1585: [GVN] Improve PRE on load instructions: rG43969af627aa: Revert "[GVN] Improve PRE on load instructions".
Feb 1 2023, 2:49 PM · Restricted Project, Restricted Project
Carrot committed rG43969af627aa: Revert "[GVN] Improve PRE on load instructions" (authored by Carrot).
Revert "[GVN] Improve PRE on load instructions"
Feb 1 2023, 2:49 PM · Restricted Project, Restricted Project
Carrot added a reverting change for rGf494b366ff8a: [GVN] Don't count debug instructions when limit the number of checked…: rG3a5777f6308b: Revert "[GVN] Don't count debug instructions when limit the number of checked….
Feb 1 2023, 2:49 PM · Restricted Project, Restricted Project
Carrot added a reverting change for D141712: [GVN] Improve PRE on load instructions: rG43969af627aa: Revert "[GVN] Improve PRE on load instructions".
Feb 1 2023, 2:49 PM · Restricted Project, Restricted Project
Carrot committed rG3a5777f6308b: Revert "[GVN] Don't count debug instructions when limit the number of checked… (authored by Carrot).
Revert "[GVN] Don't count debug instructions when limit the number of checked…
Feb 1 2023, 2:49 PM · Restricted Project, Restricted Project
Carrot added a reverting change for D142787: [GVN] Don't count debug instructions when limit the number of checked instructions: rG3a5777f6308b: Revert "[GVN] Don't count debug instructions when limit the number of checked….
Feb 1 2023, 2:49 PM · debug-info, Restricted Project, Restricted Project
Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

@reames, I'm happy to revert it once I get your test case, otherwise I have nothing to investigate.

Feb 1 2023, 1:27 PM · Restricted Project, Restricted Project
Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

@hans, do you have a reduced test case to demonstrate the problem?

Feb 1 2023, 10:47 AM · Restricted Project, Restricted Project

Jan 31 2023

Carrot committed rGf494b366ff8a: [GVN] Don't count debug instructions when limit the number of checked… (authored by Carrot).
[GVN] Don't count debug instructions when limit the number of checked…
Jan 31 2023, 1:05 PM · Restricted Project, Restricted Project
Carrot closed D142787: [GVN] Don't count debug instructions when limit the number of checked instructions.
Jan 31 2023, 1:04 PM · debug-info, Restricted Project, Restricted Project

Jan 30 2023

Carrot added a comment to D142787: [GVN] Don't count debug instructions when limit the number of checked instructions.

Can we follow-up updating the place I've pointed out above?

Jan 30 2023, 3:17 PM · debug-info, Restricted Project, Restricted Project
Carrot updated the diff for D142787: [GVN] Don't count debug instructions when limit the number of checked instructions.
Jan 30 2023, 3:16 PM · debug-info, Restricted Project, Restricted Project

Jan 27 2023

Carrot requested review of D142787: [GVN] Don't count debug instructions when limit the number of checked instructions.
Jan 27 2023, 3:29 PM · debug-info, Restricted Project, Restricted Project
Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

@uabelho, thank you for the reporting! I think you are right. I'm preparing the patch.

Jan 27 2023, 11:27 AM · Restricted Project, Restricted Project

Jan 26 2023

Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

It looks like the new version of the patch ended up being more expensive in terms of compile-time: Original, New

I wonder whether this is because not removing the load essentially always forces an extra GVN iteration?

Jan 26 2023, 12:32 PM · Restricted Project, Restricted Project

Jan 25 2023

Carrot committed rG5f1448fe1585: [GVN] Improve PRE on load instructions (authored by Carrot).
[GVN] Improve PRE on load instructions
Jan 25 2023, 11:48 AM · Restricted Project, Restricted Project
Carrot closed D141712: [GVN] Improve PRE on load instructions.
Jan 25 2023, 11:48 AM · Restricted Project, Restricted Project

Jan 19 2023

Carrot added inline comments to D141712: [GVN] Improve PRE on load instructions.
Jan 19 2023, 2:32 PM · Restricted Project, Restricted Project
Carrot updated the diff for D141712: [GVN] Improve PRE on load instructions.
Jan 19 2023, 2:32 PM · Restricted Project, Restricted Project

Jan 18 2023

Carrot added inline comments to D141712: [GVN] Improve PRE on load instructions.
Jan 18 2023, 2:13 PM · Restricted Project, Restricted Project
Carrot updated the diff for D141712: [GVN] Improve PRE on load instructions.
Jan 18 2023, 2:13 PM · Restricted Project, Restricted Project
Carrot added a comment to D141712: [GVN] Improve PRE on load instructions.

In general, I'm concerned that this patch tries to combine 2 different transformations: load PRE and hoisting. It can omit critical edge splitting in some cases, but after hoisting we can also cleanup CFG.

Jan 18 2023, 10:00 AM · Restricted Project, Restricted Project

Jan 17 2023

Carrot added inline comments to D141712: [GVN] Improve PRE on load instructions.
Jan 17 2023, 6:19 PM · Restricted Project, Restricted Project
Carrot updated the diff for D141712: [GVN] Improve PRE on load instructions.
Jan 17 2023, 6:19 PM · Restricted Project, Restricted Project

Jan 13 2023

Carrot updated the summary of D141712: [GVN] Improve PRE on load instructions.
Jan 13 2023, 11:14 AM · Restricted Project, Restricted Project
Carrot requested review of D141712: [GVN] Improve PRE on load instructions.
Jan 13 2023, 11:12 AM · Restricted Project, Restricted Project

Jan 9 2023

Carrot added a comment to D139582: [GVN] Improve PRE on load instructions.

@SixWeining @dyung , both reproduction work for me, thanks a lot!

Jan 9 2023, 8:43 PM · Restricted Project, Restricted Project
Carrot added a comment to D139582: [GVN] Improve PRE on load instructions.

@dyung @chapuni thank you for the report, I have reverted it.
How did you investigate it ? I try to reproduce it according to https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild, but always got following error

...
+ BUILDBOT_MONO_REPO_PATH=
+ BUILDBOT_REVISION=llvmorg-
+ buildbot_update
+ echo @@@BUILD_STEP update llvmorg-@@@
@@@BUILD_STEP update llvmorg-@@@
+ [[ -d '' ]]
+ local DEPTH=100
+ [[ -d llvm-project ]]
+ cd llvm-project
+ git fetch origin
+ git clean -fd
+ local REV=llvmorg-
+ git checkout -f llvmorg-
error: pathspec 'llvmorg-' did not match any file(s) known to git
+ git status
On branch main
Jan 9 2023, 7:02 PM · Restricted Project, Restricted Project
Carrot added a reverting change for rG1f1d501843e5: [GVN] Improve PRE on load instructions: rG9852941f0138: Revert "[GVN] Improve PRE on load instructions".
Jan 9 2023, 6:40 PM · Restricted Project, Restricted Project
Carrot committed rG9852941f0138: Revert "[GVN] Improve PRE on load instructions" (authored by Carrot).
Revert "[GVN] Improve PRE on load instructions"
Jan 9 2023, 6:40 PM · Restricted Project, Restricted Project
Carrot added a reverting change for D139582: [GVN] Improve PRE on load instructions: rG9852941f0138: Revert "[GVN] Improve PRE on load instructions".
Jan 9 2023, 6:40 PM · Restricted Project, Restricted Project
Carrot committed rG1f1d501843e5: [GVN] Improve PRE on load instructions (authored by Carrot).
[GVN] Improve PRE on load instructions
Jan 9 2023, 3:09 PM · Restricted Project, Restricted Project
Carrot closed D139582: [GVN] Improve PRE on load instructions.
Jan 9 2023, 3:09 PM · Restricted Project, Restricted Project

Jan 5 2023

Carrot updated the diff for D139582: [GVN] Improve PRE on load instructions.

Thanks for the review! Will commit this version.

Jan 5 2023, 2:33 PM · Restricted Project, Restricted Project

Dec 21 2022

Carrot added inline comments to D139582: [GVN] Improve PRE on load instructions.
Dec 21 2022, 11:02 AM · Restricted Project, Restricted Project
Carrot updated the diff for D139582: [GVN] Improve PRE on load instructions.
Dec 21 2022, 11:01 AM · Restricted Project, Restricted Project

Dec 20 2022

Carrot committed rG4c13af22b4d4: [TEST] Pre-commit test for GVN PRE load (authored by Carrot).
[TEST] Pre-commit test for GVN PRE load
Dec 20 2022, 10:46 AM · Restricted Project, Restricted Project
Carrot closed D140234: [TEST] Pre-commit test for GVN PRE load.
Dec 20 2022, 10:46 AM · Restricted Project, Restricted Project

Dec 19 2022

Carrot updated the diff for D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Rebase the code.

Dec 19 2022, 3:02 PM · Restricted Project, Restricted Project

Dec 16 2022

Carrot requested review of D140234: [TEST] Pre-commit test for GVN PRE load.
Dec 16 2022, 10:55 AM · Restricted Project, Restricted Project

Dec 15 2022

Carrot added a comment to D139582: [GVN] Improve PRE on load instructions.

The compile time regression on ClamAV is in file libclamav_htmlnorm.c. The increased compile time is completely in GVN pass, from 4.0s to 5.3s. There is a huge function cli_html_normalise in this file, it's more than 6600 lines in generated assembly file. The statistic result of NumPRELoad increased from 1 to 10 because of this patch. In function GVNPass::runImpl we have

unsigned Iteration = 0;
while (ShouldContinue) {
  LLVM_DEBUG(dbgs() << "GVN iteration: " << Iteration << "\n");
  (void) Iteration;
  ShouldContinue = iterateOnFunction(F);
  Changed |= ShouldContinue;
  ++Iteration;
}

It means we continuously do GVN on a function until there is no more such optimization applicable. This patch enables more optimizations, potentially it may also cause more iterations on a function. In this case, the loop is executed 4 times without this patch, but 5 times with this patch. These numbers closely correlate to the increased compile time.

Dec 15 2022, 2:05 PM · Restricted Project, Restricted Project

Dec 12 2022

Carrot updated the diff for D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Add a test case to show that llvm can generate wrong instructions without this patch.

Dec 12 2022, 2:08 PM · Restricted Project, Restricted Project

Dec 8 2022

Carrot updated the diff for D139582: [GVN] Improve PRE on load instructions.

Compile time improvement.

Dec 8 2022, 5:27 PM · Restricted Project, Restricted Project
Carrot added a comment to D139582: [GVN] Improve PRE on load instructions.

Seems like this patch keeps finding values in vectors, and it might be a reason of CT degradation. Maybe refactor them to be maps instead?

Dec 8 2022, 4:41 PM · Restricted Project, Restricted Project

Dec 7 2022

Carrot requested review of D139582: [GVN] Improve PRE on load instructions.
Dec 7 2022, 2:32 PM · Restricted Project, Restricted Project

Dec 5 2022

Carrot added a comment to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Any other comments?

Dec 5 2022, 3:27 PM · Restricted Project, Restricted Project

Nov 28 2022

Carrot added a comment to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

ping

Nov 28 2022, 2:42 PM · Restricted Project, Restricted Project

Nov 22 2022

Carrot committed rG835da13ae0b8: [AArch64] Correctly recognize -reserve-regs-for-regalloc=X30,X29 (authored by Carrot).
[AArch64] Correctly recognize -reserve-regs-for-regalloc=X30,X29
Nov 22 2022, 9:21 AM · Restricted Project, Restricted Project
Carrot closed D137810: [AArch64] Correctly recognize -reserve-regs-for-regalloc=X30,X29.
Nov 22 2022, 9:21 AM · Restricted Project, Restricted Project

Nov 18 2022

Carrot added a comment to D137810: [AArch64] Correctly recognize -reserve-regs-for-regalloc=X30,X29.

ping

Nov 18 2022, 5:39 PM · Restricted Project, Restricted Project

Nov 15 2022

Carrot updated the diff for D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Rebase this patch after committing the MachineCSE part.

Nov 15 2022, 2:26 PM · Restricted Project, Restricted Project

Nov 14 2022

Carrot committed rG11e86868c1a1: [MachineCSE] Allow CSE for instructions with ignorable operands (authored by Carrot).
[MachineCSE] Allow CSE for instructions with ignorable operands
Nov 14 2022, 11:39 AM · Restricted Project, Restricted Project
Carrot closed D137222: [MachineCSE] Allow CSE for instructions with ignorable operands.
Nov 14 2022, 11:39 AM · Restricted Project, Restricted Project

Nov 11 2022

Carrot added a comment to D137222: [MachineCSE] Allow CSE for instructions with ignorable operands.

ping

Nov 11 2022, 11:30 AM · Restricted Project, Restricted Project

Nov 10 2022

Carrot requested review of D137810: [AArch64] Correctly recognize -reserve-regs-for-regalloc=X30,X29.
Nov 10 2022, 6:01 PM · Restricted Project, Restricted Project

Nov 4 2022

Carrot updated the diff for D137222: [MachineCSE] Allow CSE for instructions with ignorable operands.

MachineCSE was changed recently, so rebase this patch. Now it has more impact.

Nov 4 2022, 1:04 PM · Restricted Project, Restricted Project

Nov 3 2022

Carrot added inline comments to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.
Nov 3 2022, 2:42 PM · Restricted Project, Restricted Project

Nov 1 2022

Carrot added a comment to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

@foad, thanks a lot for reviewing AMDGPU changes!

Nov 1 2022, 7:06 PM · Restricted Project, Restricted Project
Carrot requested review of D137222: [MachineCSE] Allow CSE for instructions with ignorable operands.
Nov 1 2022, 7:00 PM · Restricted Project, Restricted Project

Oct 28 2022

Carrot added a comment to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Why are there so many changes in AMDGPU codegen, even in tests that do not contain function calls?

Oct 28 2022, 2:17 PM · Restricted Project, Restricted Project

Oct 27 2022

Carrot updated the diff for D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Any other comments?

Oct 27 2022, 6:38 PM · Restricted Project, Restricted Project

Oct 26 2022

Carrot committed rGe5244706ec6a: [dexter-tests] Add attribute optnone to main function (authored by Carrot).
[dexter-tests] Add attribute optnone to main function
Oct 26 2022, 2:01 PM · Restricted Project
Carrot closed D136778: [dexter-tests] Add attribute optnone to main function.
Oct 26 2022, 2:00 PM · Restricted Project, Restricted Project
Carrot added a comment to D136396: [X86] Enable reassociation for ADD instructions .

Hey, this broke a Dexter test: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/47878/

@jmorse and/or @Orlando can you help make sure this isn't a Dexter issue?

Oct 26 2022, 1:29 PM · Restricted Project, Restricted Project
Carrot requested review of D136778: [dexter-tests] Add attribute optnone to main function.
Oct 26 2022, 12:03 PM · Restricted Project, Restricted Project

Oct 25 2022

Carrot committed rGd24c93cc4107: [X86] Enable reassociation for ADD instructions (authored by Carrot).
[X86] Enable reassociation for ADD instructions
Oct 25 2022, 5:49 PM · Restricted Project, Restricted Project
Carrot closed D136396: [X86] Enable reassociation for ADD instructions .
Oct 25 2022, 5:48 PM · Restricted Project, Restricted Project

Oct 24 2022

Carrot updated the diff for D136396: [X86] Enable reassociation for ADD instructions .

Rebase test cases.

Oct 24 2022, 2:10 PM · Restricted Project, Restricted Project
Carrot committed rGf298bfb09b74: [X86] New test case for reassociation of ADD instructions. (authored by Carrot).
[X86] New test case for reassociation of ADD instructions.
Oct 24 2022, 10:49 AM · Restricted Project, Restricted Project
Carrot closed D136501: [X86] New test case for reassociation of ADD instructions..
Oct 24 2022, 10:49 AM · Restricted Project, Restricted Project
Carrot updated the diff for D136501: [X86] New test case for reassociation of ADD instructions..

Thanks for the review. Will commit this version.

Oct 24 2022, 8:56 AM · Restricted Project, Restricted Project

Oct 21 2022

Carrot added inline comments to D136396: [X86] Enable reassociation for ADD instructions .
Oct 21 2022, 3:01 PM · Restricted Project, Restricted Project
Carrot requested review of D136501: [X86] New test case for reassociation of ADD instructions..
Oct 21 2022, 2:21 PM · Restricted Project, Restricted Project
Carrot added inline comments to D136396: [X86] Enable reassociation for ADD instructions .
Oct 21 2022, 1:12 PM · Restricted Project, Restricted Project
Carrot added inline comments to D136396: [X86] Enable reassociation for ADD instructions .
Oct 21 2022, 11:51 AM · Restricted Project, Restricted Project
Carrot added inline comments to D136396: [X86] Enable reassociation for ADD instructions .
Oct 21 2022, 11:14 AM · Restricted Project, Restricted Project

Oct 20 2022

Carrot requested review of D136396: [X86] Enable reassociation for ADD instructions .
Oct 20 2022, 5:07 PM · Restricted Project, Restricted Project

Oct 13 2022

Carrot updated the diff for D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

Rebase.

Oct 13 2022, 6:56 PM · Restricted Project, Restricted Project

Oct 5 2022

Carrot added a comment to D130919: [MRI] isConstantPhysReg should also check if the register is clobbered by a RegMask.

ping

Oct 5 2022, 10:06 AM · Restricted Project, Restricted Project