This is an archive of the discontinued LLVM Phabricator instance.

[flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic
ClosedPublic

Authored by josh.mottley.arm on Jan 21 2022, 3:30 AM.

Details

Summary

This patch adds partial lowering of the "COMMAND_ARGUMENT_COUNT" intrinsic
to the backend runtime hook implemented in patch D109048. Also adds a
"helper" function for retrieving the default integer type from
FIRBuilder, which will be used later when finishing the lowering of
intrinsic.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
josh.mottley.arm requested review of this revision.Jan 21 2022, 3:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2022, 3:30 AM

Fixed comment in CommandTest.cpp

Fixed first line not being correctly modified.

clementval accepted this revision.Jan 21 2022, 4:43 AM

LGTM

flang/unittests/Optimizer/Builder/Runtime/CommandTest.cpp
14

nit

This revision is now accepted and ready to land.Jan 21 2022, 4:43 AM
awarzynski accepted this revision.Jan 28 2022, 10:06 AM

LGTM, thanks!

flang/unittests/Optimizer/Builder/Runtime/CommandTest.cpp
16

nit :)

Addressed nit comments.