Page MenuHomePhabricator

josh.mottley.arm (Josh Mottley)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 13 2021, 5:32 AM (58 w, 6 d)

Recent Activity

Feb 8 2022

josh.mottley.arm committed rG5ebbcfa01d78: [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic (authored by josh.mottley.arm).
[flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic
Feb 8 2022, 9:44 AM
josh.mottley.arm closed D118984: [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic.
Feb 8 2022, 9:44 AM · Restricted Project, Restricted Project

Feb 4 2022

josh.mottley.arm added reviewers for D118984: [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic: awarzynski, Leporacanthicus, kiranchandramohan, clementval, schweitz.
Feb 4 2022, 3:25 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D118984: [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic.
Feb 4 2022, 3:24 AM · Restricted Project, Restricted Project
josh.mottley.arm committed rG38073b066973: [flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic (authored by josh.mottley.arm).
[flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic
Feb 4 2022, 2:25 AM
josh.mottley.arm closed D118801: [flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic.
Feb 4 2022, 2:25 AM · Restricted Project, Restricted Project

Feb 3 2022

josh.mottley.arm updated the diff for D118801: [flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic.

Fixed unit test failing in debug. Issue was genGetCommandArgument requires the
length and status parameters to be memory references (as we convert to ensure
result type).

Feb 3 2022, 5:39 AM · Restricted Project, Restricted Project

Feb 2 2022

josh.mottley.arm added reviewers for D118801: [flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic: awarzynski, Leporacanthicus, kiranchandramohan, clementval, schweitz.
Feb 2 2022, 8:21 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D118801: [flang] Upstream partial lowering of GET_COMMAND_ARGUMENT intrinsic.
Feb 2 2022, 8:19 AM · Restricted Project, Restricted Project

Feb 1 2022

josh.mottley.arm committed rGce8022faa365: [flang] Upstream partial lowering of EXIT intrinsic (authored by josh.mottley.arm).
[flang] Upstream partial lowering of EXIT intrinsic
Feb 1 2022, 9:49 AM
josh.mottley.arm closed D118141: [flang] Upstream partial lowering of EXIT intrinsic.
Feb 1 2022, 9:49 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D118141: [flang] Upstream partial lowering of EXIT intrinsic.

Addressed awarzynski comments.

Feb 1 2022, 2:12 AM · Restricted Project, Restricted Project

Jan 31 2022

josh.mottley.arm committed rGddac11aee649: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic (authored by josh.mottley.arm).
[flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic
Jan 31 2022, 9:02 AM
josh.mottley.arm closed D117869: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic.
Jan 31 2022, 9:01 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D117869: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic.

Addressed nit comments.

Jan 31 2022, 2:13 AM · Restricted Project, Restricted Project

Jan 26 2022

josh.mottley.arm added inline comments to D118141: [flang] Upstream partial lowering of EXIT intrinsic.
Jan 26 2022, 8:28 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D118141: [flang] Upstream partial lowering of EXIT intrinsic.

Addressed awarzynski comments.

Jan 26 2022, 8:27 AM · Restricted Project, Restricted Project

Jan 25 2022

josh.mottley.arm added reviewers for D118141: [flang] Upstream partial lowering of EXIT intrinsic: awarzynski, Leporacanthicus, kiranchandramohan, clementval.
Jan 25 2022, 6:49 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D118141: [flang] Upstream partial lowering of EXIT intrinsic.
Jan 25 2022, 6:27 AM · Restricted Project, Restricted Project

Jan 21 2022

josh.mottley.arm added reviewers for D117869: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic: kiranchandramohan, Leporacanthicus, awarzynski.
Jan 21 2022, 3:39 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D117869: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic.

Fixed comment in CommandTest.cpp

Jan 21 2022, 3:37 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D117869: [flang] Upstream partial lowering of COMMAND_ARGUMENT_COUNT intrinsic.
Jan 21 2022, 3:30 AM · Restricted Project, Restricted Project

Nov 4 2021

josh.mottley.arm committed rGa0f29fec657e: [flang][flang-omp-report] Add flang-omp-report summarising script (authored by josh.mottley.arm).
[flang][flang-omp-report] Add flang-omp-report summarising script
Nov 4 2021, 10:43 AM
josh.mottley.arm closed D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
Nov 4 2021, 10:43 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the summary of D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
Nov 4 2021, 10:16 AM · Restricted Project, Restricted Project
josh.mottley.arm retitled D111042: [flang][flang-omp-report] Add flang-omp-report summarising script from flang-omp-report summarising script to [flang][flang-omp-report] Add flang-omp-report summarising script.
Nov 4 2021, 10:09 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the summary of D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
Nov 4 2021, 9:14 AM · Restricted Project, Restricted Project
josh.mottley.arm committed rG2aec2549e8e5: [flang][flang-omp-report] Remove the loop workarounds for nowait clause (authored by josh.mottley.arm).
[flang][flang-omp-report] Remove the loop workarounds for nowait clause
Nov 4 2021, 7:25 AM
josh.mottley.arm closed D112217: [flang][flang-omp-report] Remove the loop workarounds for nowait clause.
Nov 4 2021, 7:24 AM · Restricted Project, Restricted Project
josh.mottley.arm committed rG0a95abb7dcf3: [flang][flang-omp-report] Removed unnecessary comments in flang-omp-report… (authored by josh.mottley.arm).
[flang][flang-omp-report] Removed unnecessary comments in flang-omp-report…
Nov 4 2021, 6:47 AM
josh.mottley.arm closed D112817: Removed unnecessary comments in flang-omp-report plugin tests.
Nov 4 2021, 6:47 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
  • Fixed issues reported from review comments.
  • Extended '-d' argument to be able to take a list of semicolon seperated directory paths to search for '.yaml' files in.
Nov 4 2021, 4:37 AM · Restricted Project, Restricted Project

Nov 3 2021

josh.mottley.arm updated the summary of D112817: Removed unnecessary comments in flang-omp-report plugin tests.
Nov 3 2021, 10:09 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D112817: Removed unnecessary comments in flang-omp-report plugin tests.

Updated phabricator summary.

Nov 3 2021, 9:37 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D112817: Removed unnecessary comments in flang-omp-report plugin tests.

Updated phabricator summary.

Nov 3 2021, 9:33 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D112817: Removed unnecessary comments in flang-omp-report plugin tests.

Updated commit message.

Nov 3 2021, 8:48 AM · Restricted Project, Restricted Project

Nov 1 2021

josh.mottley.arm added a comment to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

@NimishMishra Thanks for the help. Looks like the patch fixes the issue I was having on my end.

Nov 1 2021, 4:04 AM · Restricted Project, Restricted Project, Restricted Project

Oct 29 2021

josh.mottley.arm added reviewers for D112817: Removed unnecessary comments in flang-omp-report plugin tests: awarzynski, kiranchandramohan, Leporacanthicus.
Oct 29 2021, 7:42 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D112817: Removed unnecessary comments in flang-omp-report plugin tests.
Oct 29 2021, 7:41 AM · Restricted Project, Restricted Project
josh.mottley.arm added a comment to D108904: [flang][OpenMP] Added semantic checks for sections (associated section(s) should be structured block(s)) and simd constructs (associated loop(s) should be structured block(s)).

@NimishMishra I believe this patch is causing a false semantic error with SNAP. The error being:

error: Semantic errors in inner.f90
./inner.f90:152:7: error: CYCLE to construct outside of PARALLEL DO construct is not allowed
        IF ( g == 0 ) CYCLE

The code in snap it is erroring at in inner.f90 is:

!$OMP PARALLEL DO NUM_THREADS(nnstd_used) IF(nnstd_used>1)           &
!$OMP& SCHEDULE(STATIC,1) DEFAULT(SHARED) PRIVATE(n,g)               &
!$OMP& PROC_BIND(CLOSE)
  DO n = 1, ng_per_thrd
    g = grp_act(n,t)
    IF ( g == 0 ) CYCLE
    CALL inner_df_calc ( inno, iits(g), flux0pi(:,:,:,g),            &
                      flux0(:,:,:,g), dfmxi(g) )
  END DO
!$OMP END PARALLEL DO

AFAIK this should be valid code, and I know that @Leporacanthicus is also experiencing this issue (although it looks like there could be a secondary issue as well).
I've tried reverting this patch, and managed to stop getting this error when using the flang-omp-report plugin.

Oct 29 2021, 5:58 AM · Restricted Project, Restricted Project, Restricted Project
josh.mottley.arm added inline comments to D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
Oct 29 2021, 4:13 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
  • Fixed issues reported from review comments.
  • Added type hints where appropriate to arguments of functions.
  • Removed the default arguments from functions where it was not neccesary, and added default arguments to parsed arguments.
Oct 29 2021, 4:10 AM · Restricted Project, Restricted Project

Oct 27 2021

josh.mottley.arm updated the diff for D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.
  • Removed try...except check for importing ruamel.yaml. This also includes removing the yaml_module_not_found function.
  • Added requirements.txt.
  • Refactored code to include functions; main, parse_arguments, create_arg_parser.
Oct 27 2021, 5:26 AM · Restricted Project, Restricted Project

Oct 26 2021

josh.mottley.arm added reviewers for D111042: [flang][flang-omp-report] Add flang-omp-report summarising script: awarzynski, kiranchandramohan, Leporacanthicus.
Oct 26 2021, 7:05 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.

Refactored code.

Oct 26 2021, 7:03 AM · Restricted Project, Restricted Project
josh.mottley.arm commandeered D111042: [flang][flang-omp-report] Add flang-omp-report summarising script.

I will now be taking over this patch from Ivan.

Oct 26 2021, 7:03 AM · Restricted Project, Restricted Project
josh.mottley.arm updated the diff for D112217: [flang][flang-omp-report] Remove the loop workarounds for nowait clause.

Removed unnecessary comments in 'omp-nowait.f90'.

Oct 26 2021, 6:05 AM · Restricted Project, Restricted Project

Oct 21 2021

josh.mottley.arm updated the diff for D112217: [flang][flang-omp-report] Remove the loop workarounds for nowait clause.

Manually ran clang-format of flang-omp-report-visistor.cpp as git-clang-format
not correctly formatting the code.

Oct 21 2021, 6:31 AM · Restricted Project, Restricted Project
josh.mottley.arm added reviewers for D112217: [flang][flang-omp-report] Remove the loop workarounds for nowait clause: awarzynski, kiranchandramohan, Leporacanthicus.
Oct 21 2021, 5:29 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D112217: [flang][flang-omp-report] Remove the loop workarounds for nowait clause.
Oct 21 2021, 5:27 AM · Restricted Project, Restricted Project

Oct 19 2021

josh.mottley.arm added a comment to D111709: [Flang] flang-omp-report replace std::vector's with llvm::SmallVector.

@DavidTruby & @clementval Just to let you know, got the map and string patches up for review now :)

Oct 19 2021, 5:22 AM · Restricted Project, Restricted Project

Oct 18 2021

josh.mottley.arm requested review of D111980: [Flang][flang-omp-report] Switch from std::string to StringRef (where possible).
Oct 18 2021, 3:18 AM · Restricted Project, Restricted Project
josh.mottley.arm requested review of D111977: [flang] flang-omp-report replace std::map with llvm::DenseMap.
Oct 18 2021, 2:35 AM · Restricted Project, Restricted Project

Oct 13 2021

josh.mottley.arm requested review of D111709: [Flang] flang-omp-report replace std::vector's with llvm::SmallVector.
Oct 13 2021, 5:38 AM · Restricted Project, Restricted Project