Revert "[X86][LLD] Update datelayout in LLD tests. NFCI"
AbandonedPublic
Actions

Authored by pengfei on Jan 13 2022, 7:50 PM.

Details

Reviewers

rnk
craig.topper
efriedma
gbreynoo
dexonsmith

Summary

This reverts commit 9b43237128da0a7a3bc8a16f6f2c0897b9e842be

The reverted patch is a workaround to make buildbot happy.
This fixes the real problem in rG1bb0caf56168.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

pengfei created this revision.Jan 13 2022, 7:50 PM

Herald added subscribers: ormris, dexonsmith, steven_wu, hiraditya. · View Herald TranscriptJan 13 2022, 7:50 PM

pengfei requested review of this revision.Jan 13 2022, 7:50 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 7:50 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

pengfei mentioned this in D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC.Jan 13 2022, 7:52 PM

pengfei mentioned this in D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.Jan 13 2022, 7:54 PM

Harbormaster completed remote builds in B143303: Diff 399874.Jan 13 2022, 8:22 PM

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

This revision is now accepted and ready to land.Jan 14 2022, 11:39 AM

In D117270#3244517, @dexonsmith wrote:

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

Nevermind, looking closer, this isn't a simple revert. I'll resign as reviewer so someone can look at the autoupgrade changes.

If I were you, I'd revert the original commit and the incorrect testcase fix in lld (without review) and then post a review for relanding with autoupgrade working correctly.

This revision now requires review to proceed.Jan 14 2022, 11:43 AM

In D117270#3244523, @dexonsmith wrote:

In D117270#3244517, @dexonsmith wrote:

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

Nevermind, looking closer, this isn't a simple revert. I'll resign as reviewer so someone can look at the autoupgrade changes.

If I were you, I'd revert the original commit and the incorrect testcase fix in lld (without review) and then post a review for relanding with autoupgrade working correctly.