Page MenuHomePhabricator

Revert "[X86][LLD] Update datelayout in LLD tests. NFCI"
AbandonedPublic

Authored by pengfei on Thu, Jan 13, 7:50 PM.

Details

Summary

This reverts commit 9b43237128da0a7a3bc8a16f6f2c0897b9e842be

The reverted patch is a workaround to make buildbot happy.
This fixes the real problem in rG1bb0caf56168.

Diff Detail

Event Timeline

pengfei created this revision.Thu, Jan 13, 7:50 PM
pengfei requested review of this revision.Thu, Jan 13, 7:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jan 13, 7:50 PM
dexonsmith accepted this revision.Fri, Jan 14, 11:39 AM

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

This revision is now accepted and ready to land.Fri, Jan 14, 11:39 AM
dexonsmith resigned from this revision.Fri, Jan 14, 11:43 AM

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

Nevermind, looking closer, this isn't a simple revert. I'll resign as reviewer so someone can look at the autoupgrade changes.

If I were you, I'd revert the original commit and the incorrect testcase fix in lld (without review) and then post a review for relanding with autoupgrade working correctly.

This revision now requires review to proceed.Fri, Jan 14, 11:43 AM
pengfei abandoned this revision.Fri, Jan 14, 7:01 PM

Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)

Nevermind, looking closer, this isn't a simple revert. I'll resign as reviewer so someone can look at the autoupgrade changes.

If I were you, I'd revert the original commit and the incorrect testcase fix in lld (without review) and then post a review for relanding with autoupgrade working correctly.

I was hesitating on it too. Reverted, thanks!