This is an archive of the discontinued LLVM Phabricator instance.

[X86][LLD] Fix warning from updated data layout in LLD tests
AbandonedPublic

Authored by gbreynoo on Jan 13 2022, 3:48 AM.

Download Raw Diff

Details

Reviewers

pengfei
rnk
craig.topper

Summary

The commit 9b43237128da0a7a3bc8a16f6f2c0897b9e842be fixed a number of failing tests but introduced a warning output to lld/test/COFF/libcall-archive.ll due to the input file also needing updating. This change updates the input file.

Diff Detail

Event Timeline

gbreynoo requested review of this revision.Jan 13 2022, 3:48 AM

gbreynoo created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 3:48 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Due to a private patch we were seeing this warning cause a test failure, hence this diff.

Harbormaster completed remote builds in B143128: Diff 399621.Jan 13 2022, 3:58 AM

@gbreynoo Thanks for working on that and sorry for the incomplete!
I know very little about LLD and am investigating why auto upgrade doesn't work as expected. I would expect I can change back those tests finally.
I'm happy with this patch as a temporary solution. @rnk do you think we can let it in and permit me doing the follow up, or revert the previous two patches instead?

There's nothing to do with LLD, it's a bug in AutoUpgrade.cpp, fixed on D117270.

This issue was resolved.

Revision Contents

Path

Size

lld/

test/

COFF/

Inputs/

libcall-archive.ll

2 lines

Diff 399621

lld/test/COFF/Inputs/libcall-archive.ll

	target datalayout = "e-m:x-p:32:32-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:32-n8:16:32-a:0:32-S32"			target datalayout = "e-m:x-p:32:32-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32-a:0:32-S32"
	target triple = "i686-unknown-windows"			target triple = "i686-unknown-windows"

	define void @memcpy() {			define void @memcpy() {
	ret void			ret void
	}			}