This is an archive of the discontinued LLVM Phabricator instance.

[IRBuilder] Migrate add-folding to value-based FoldAdd.
ClosedPublic

Authored by fhahn on Jan 10 2022, 12:44 PM.

Diff Detail

Event Timeline

fhahn created this revision.Jan 10 2022, 12:44 PM
fhahn requested review of this revision.Jan 10 2022, 12:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2022, 12:44 PM
nikic accepted this revision.Jan 10 2022, 12:51 PM

LGTM

llvm/include/llvm/Analysis/InstSimplifyFolder.h
52

Might make sense to store the SimplifyQuery in the class?

This revision is now accepted and ready to land.Jan 10 2022, 12:51 PM
This revision was landed with ongoing or failed builds.Jan 12 2022, 1:25 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.Jan 12 2022, 1:25 AM
fhahn added inline comments.
llvm/include/llvm/Analysis/InstSimplifyFolder.h
52

Done in the committed version, thanks!