[NFC][RISCV] Make the macro names more uniform

[craig.topper]

llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp

27 ↗

(On Diff #397772)

Revert this. Most targets uses "asm-printer". This is common functionality on all targets, there doesn't need to be a different way to spell it for RISCV.

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp

33 ↗

(On Diff #397772)

Same, "mccodeemitter" is used by the majority of targets.

llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp

34 ↗

(On Diff #397772)

This seems to have more inconsistency between targets, but every target has this file so I don't see why we need a different string for RISCV.

[jrtc27]

I could've sworn I stumbled upon guidance the other day about using standard names for things that exist for all targets, but can't for the life of me find it today

[achieveartificialintelligence]

update

[achieveartificialintelligence]

Thank you both for your guidance. @craig.topper @jrtc27

[asb]

Thanks for the patch. I wouldn't mark this as NFC, because the DEBUG_TYPE changes will impact backend developers using -debug-only to control debug messages. It would be worth noting this impact in the commit message too.

I've gone through and I think I'm slightly against most of the proposed DEBUG_TYPE changes. It doesn't always make sense to copy what other targets do (after all, one hope with the RISC-V backend was to try to avoid that copy and paste approach), but I think it's probably advantageous that the same format of -debug-only invocations is common across backends, even if the names themselves aren't always the best (or consistent in style).

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp

28 ↗

(On Diff #397785)

I was mirroring other targets with this one (e.g. Sparc, Mips, Lanai). But I don't think this is used enough that it's necessary to follow these. I'd suggest riscv-mcexpr is a better change though (and also matches HexagonMCExpr).

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

28 ↗

(On Diff #397785)

Basically all other archs use $target-isel for this, so it would be best to keep it the same.

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

43 ↗

(On Diff #397785)

This is another one that matches what almost all other targets do (a few call it $target-isel instead), so would be best left unchanged.

llvm/lib/Target/RISCV/RISCVInstructionSelector.cpp

22 ↗

(On Diff #397785)

This also matches other targets (AArch64, AMDGPU, Arm, M68k, Mips).

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp

16 ↗

(On Diff #397785)

Again, the current name matches the format used for other backends.

[achieveartificialintelligence]

Address @asb 's comments.

[craig.topper]

LGTM

[jrtc27]

In D116719#3224274, @jrtc27 wrote:

I could've sworn I stumbled upon guidance the other day about using standard names for things that exist for all targets, but can't for the life of me find it today

For future reference, https://llvm.org/docs/ProgrammersManual.html#fine-grained-debug-info-with-debug-type-and-the-debug-only-option is that documentation

llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.h

 //===-- RISCVELFStreamer.h - RISCV ELF Target Streamer ---------*- C++ -*--===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIB_TARGET_RISCV_RISCVELFSTREAMER_H
-#define LLVM_LIB_TARGET_RISCV_RISCVELFSTREAMER_H
+#ifndef LLVM_LIB_TARGET_RISCV_MCTARGETDESC_RISCVELFSTREAMER_H
+#define LLVM_LIB_TARGET_RISCV_MCTARGETDESC_RISCVELFSTREAMER_H
 
 #include "RISCVTargetStreamer.h"
 #include "llvm/MC/MCELFStreamer.h"
 
 namespace llvm {
 
 class RISCVTargetELFStreamer : public RISCVTargetStreamer {
 private:

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.h

 //===- RISCVMatInt.h - Immediate materialisation ---------------*- C++ -*--===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIB_TARGET_RISCV_MATINT_H
-#define LLVM_LIB_TARGET_RISCV_MATINT_H
+#ifndef LLVM_LIB_TARGET_RISCV_MCTARGETDESC_MATINT_H
+#define LLVM_LIB_TARGET_RISCV_MCTARGETDESC_MATINT_H
 
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/MC/SubtargetFeature.h"
 #include <cstdint>
 
 namespace llvm {
 class APInt;
 

llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.h

 //===-- RISCVTargetStreamer.h - RISCV Target Streamer ----------*- C++ -*--===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef LLVM_LIB_TARGET_RISCV_RISCVTARGETSTREAMER_H
-#define LLVM_LIB_TARGET_RISCV_RISCVTARGETSTREAMER_H
+#ifndef LLVM_LIB_TARGET_RISCV_MCTARGETDESC_RISCVTARGETSTREAMER_H
+#define LLVM_LIB_TARGET_RISCV_MCTARGETDESC_RISCVTARGETSTREAMER_H
 
 #include "llvm/MC/MCStreamer.h"
 #include "llvm/MC/MCSubtargetInfo.h"
 
 namespace llvm {
 
 class formatted_raw_ostream;