This is an archive of the discontinued LLVM Phabricator instance.

Revert "[amdgpu] Enable selection of `s_cselect_b64`."
AbandonedPublic

Authored by david-salinas on Jan 3 2022, 10:18 AM.

Details

Reviewers
lebedev.ri
jhenderson
jdoerfert
smeenai
Group Reviewers
Restricted Project
Restricted Project
Summary

This reverts commit 640beb38e7710b939b3cfb3f4c54accc694b1d30.

Change-Id: I179ce9595d31af5847fc5c29d66ae8c845dff0a8

Diff Detail

Event Timeline

david-salinas created this revision.Jan 3 2022, 10:18 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
david-salinas requested review of this revision.Jan 3 2022, 10:18 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
smeenai requested changes to this revision.Jan 3 2022, 11:51 AM
smeenai added a subscriber: smeenai.

This doesn't seem like a correct revert.

What command are you using to generate this? git revert is what you should be using, e.g.

git revert 640beb38e7710b939b3cfb3f4c54accc694b1d30

You should also edit the commit message afterwards (git commit --amend) to explain why you're reverting the change.

This revision now requires changes to proceed.Jan 3 2022, 11:51 AM
david-salinas abandoned this revision.Jan 4 2022, 1:41 PM

Abandoning. Will use D115960