Page MenuHomePhabricator

david-salinas (David Salinas)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 30 2017, 8:34 AM (93 w, 6 d)

Recent Activity

Jun 25 2019

david-salinas updated the diff for D63520: AMDGPU: Use ReversePostOrder when fixing i1 copies.

original fix was incorrect. This update forces the RegClass if the destination operand is VReg_1, to SReg_32. And then removes the attempt to change the new MI Operand(1).

Jun 25 2019, 3:47 PM · Restricted Project

Jun 18 2019

david-salinas created D63520: AMDGPU: Use ReversePostOrder when fixing i1 copies.
Jun 18 2019, 3:11 PM · Restricted Project

Mar 8 2019

david-salinas added a comment to D58346: [Sema] Change addr space diagnostics in casts to follow C++ style.

This change has caused a regression for generic C++. Should this affect OpenCL only?

Mar 8 2019, 1:29 PM · Restricted Project

Nov 5 2018

david-salinas updated the diff for D53780: Fix bitcast to address space cast for coerced load/stores.

fix missing ;

Nov 5 2018, 3:35 PM
david-salinas updated the diff for D53780: Fix bitcast to address space cast for coerced load/stores.

using CreateElementBitCast instead

Nov 5 2018, 3:07 PM

Nov 2 2018

david-salinas updated the diff for D53780: Fix bitcast to address space cast for coerced load/stores.

As per rjmccall's comments, changed the call to CreatePointerBitCastOrAddrSpaceCast back to a call to CreateBitCast, but now we're casting to the int8* with the address space of the target.

Nov 2 2018, 2:14 PM

Oct 26 2018

david-salinas updated the diff for D53780: Fix bitcast to address space cast for coerced load/stores.

remove attribute((cpu)) attribute((hc)) from test

Oct 26 2018, 3:46 PM
david-salinas created D53780: Fix bitcast to address space cast for coerced load/stores.
Oct 26 2018, 3:09 PM