This is an archive of the discontinued LLVM Phabricator instance.

Demo fix for modernize-use-override (WIP)
ClosedPublic

Authored by mehdi_amini on Dec 28 2021, 9:52 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 28 2021, 9:52 PM
mehdi_amini requested review of this revision.Dec 28 2021, 9:52 PM

By the word, since Clang-tidy issue was fixed at least in this part of LLVM code base, it's reasonable to enable this check in local .clang-tidy, so it'll be enforced automatically for those who run the tool.

jpienaar accepted this revision.Dec 29 2021, 8:45 AM
This revision is now accepted and ready to land.Dec 29 2021, 8:45 AM

Yes. And same applies for other Clang-tidy checks run on examples code.

I don't quite get what you mean by "run on examples code"?

Sorry for being unclear. I mean checks applied in D116355, D116359, etc.

Right, I opened D116185 first, and then all these revision are here to illustrate the effect of these checks before we add them to the config.
So to be clear: I'm exclusively running checks that I'm also adding to the config in D116185.

rriddle accepted this revision.Jan 1 2022, 3:27 AM
This revision was landed with ongoing or failed builds.Jan 1 2022, 5:24 PM
This revision was automatically updated to reflect the committed changes.