Enable a few clang-tidy checks in MLIR

[mehdi_amini]

Summary

This enables a few more "modernize" and "bugprone" checks (mostly).

[Mogball]

I assume all those NFC patches already fixed the issues raised by these? :P

[rriddle]

Are these not things that should be in the parent config?

[Mogball]

Putting them in the parent config would enable it for all llvm-project, wouldn't it?

[mehdi_amini]

In D116185#3207202, @rriddle wrote:

Are these not things that should be in the parent config?

I can try to do this, it may be harder to reach consensus at the scale of the project though.

In D116185#3207177, @Mogball wrote:

I assume all those NFC patches already fixed the issues raised by these? :P

No: I only fixed the existing checks, I wanted the codebase clean before adding more checks. It also helps judging the effect of these new ones.

A sample of the new fixes (I haven't processed the entire codebase yet) is here: D116237

[mehdi_amini]

I landed this except the misc-unused-parameters for now.

mlir/.clang-tidy

 InheritParentConfig: true
+Checks: >
+        bugprone-argument-comment,
+        bugprone-assert-side-effect,
+        bugprone-branch-clone,
+        bugprone-copy-constructor-init,
+        bugprone-dangling-handle,
+        bugprone-dynamic-static-initializers,
+        bugprone-macro-parentheses,
+        bugprone-macro-repeated-side-effects,
+        bugprone-misplaced-widening-cast,
+        bugprone-move-forwarding-reference,
+        bugprone-multiple-statement-macro,
+        bugprone-suspicious-semicolon,
+        bugprone-swapped-arguments,
+        bugprone-terminating-continue,
+        bugprone-unused-raii,
+        bugprone-unused-return-value,
+        misc-redundant-expression,
+        misc-static-assert,
+        misc-unused-parameters,
+        misc-unused-using-decls,
+        modernize-use-bool-literals,
+        modernize-loop-convert,
+        modernize-make-unique,
+        modernize-raw-string-literal,
+        modernize-use-equals-default,
+        modernize-use-default-member-init,
+        modernize-use-emplace,
+        modernize-use-nullptr,
+        modernize-use-override,
+        modernize-use-using,
+        performance-for-range-copy,
+        performance-implicit-conversion-in-loop,
+        performance-inefficient-algorithm,
+        performance-inefficient-vector-operation,
+        performance-move-const-arg,
+        performance-no-automatic-move,
+        performance-trivially-destructible,
+        performance-unnecessary-copy-initialization,
+        performance-unnecessary-value-param,
+        readability-avoid-const-params-in-decls,
+        readability-const-return-type,
+        readability-container-size-empty,
+        readability-inconsistent-declaration-parameter-name,
+        readability-misleading-indentation,
+        readability-redundant-control-flow,
+        readability-simplify-boolean-expr,
+        readability-simplify-subscript-expr,
+        readability-use-anyofallof
+
+
 CheckOptions:
   - key:             readability-identifier-naming.MemberCase
     value:           camelBack
   - key:             readability-identifier-naming.ParameterCase
     value:           camelBack
   - key:             readability-identifier-naming.VariableCase
     value:           camelBack