This is an archive of the discontinued LLVM Phabricator instance.

[flang][nfc] Update the description of `!fir.coordinate_of`
ClosedPublic

Authored by awarzynski on Dec 17 2021, 3:49 AM.

Download Raw Diff

Details

Reviewers

jeanPerier
AlexisPerry
rovka
schweitz
kiranchandramohan
clementval

Commits

rG022600334dcb: [flang] Update the description of `!fir.coordinate_of`

Summary

This change was suggested in one of the comments for
https://reviews.llvm.org/D115333. Basically, the following usage is
valid, but the current wording suggests otherwise:

%1 = fir.coordinate_of %a, %k : (!fir.ptr<!fir.array<5x15x25xi32>>, index) -> !fir.ref<!fir.array<5x15xi32>>

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

awarzynski created this revision.Dec 17 2021, 3:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 3:49 AM

awarzynski requested review of this revision.Dec 17 2021, 3:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 3:49 AM

Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript

Harbormaster completed remote builds in B139815: Diff 395091.Dec 17 2021, 4:07 AM

Maybe we should also add a test for this? I'm not sure if we have anything similar to this upstream.

In D115929#3231490, @rovka wrote:

Maybe we should also add a test for this? I'm not sure if we have anything similar to this upstream.

Good suggestion, will send one in a sec!

Add a test for the newly documented case

Harbormaster completed remote builds in B143432: Diff 400046.Jan 14 2022, 10:29 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 17 2022, 1:01 AM

schweitz accepted this revision.Jan 21 2022, 1:10 PM

Closed by commit rG022600334dcb: [flang] Update the description of `!fir.coordinate_of` (authored by awarzynski). · Explain WhyJan 24 2022, 2:46 AM

This revision was automatically updated to reflect the committed changes.

awarzynski added a commit: rG022600334dcb: [flang] Update the description of `!fir.coordinate_of`.

Revision Contents

Path

Size

flang/

include/

flang/

Optimizer/

Dialect/

FIROps.td

2 lines

Diff 395091

flang/include/flang/Optimizer/Dialect/FIROps.td

	Show First 20 Lines • Show All 1,627 Lines • ▼ Show 20 Lines
	def fir_CoordinateOp : fir_Op<"coordinate_of", [NoSideEffect]> {			def fir_CoordinateOp : fir_Op<"coordinate_of", [NoSideEffect]> {

	let summary = "Finds the coordinate (location) of a value in memory";			let summary = "Finds the coordinate (location) of a value in memory";

	let description = [{			let description = [{
	Compute the internal coordinate address starting from a boxed value or			Compute the internal coordinate address starting from a boxed value or
	unboxed memory reference. Returns a memory reference. When computing the			unboxed memory reference. Returns a memory reference. When computing the
	coordinate of an array element, the rank of the array must be known and			coordinate of an array element, the rank of the array must be known and
	the number of indexing expressions must equal the rank of the array.			the number of indexing expressions must not exceed the rank of the array.

	This operation will apply the access map from a boxed value implicitly.			This operation will apply the access map from a boxed value implicitly.

	Unlike LLVM's GEP instruction, one cannot stride over the outermost			Unlike LLVM's GEP instruction, one cannot stride over the outermost
	reference; therefore, the leading 0 index must be omitted.			reference; therefore, the leading 0 index must be omitted.

	```mlir			```mlir
	%i = ... : index			%i = ... : index
	▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines