This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][DWARF] emit DW_AT_accessibility attribute for class/struct/union types.
ClosedPublic

Authored by Esme on Dec 12 2021, 6:29 PM.

Details

Summary

This patch emits the DW_AT_accessibility attribute for class/struct/union types in the LLVM part.

Diff Detail

Event Timeline

Esme created this revision.Dec 12 2021, 6:29 PM
Esme requested review of this revision.Dec 12 2021, 6:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2021, 6:29 PM
dblaikie added inline comments.Dec 12 2021, 10:04 PM
llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
1010–1020

Could this be shared with some other code that handles accessibility attributes for other entities? (refactor into a common function and call it from here and wherever else this is already handled?)

Esme updated this revision to Diff 394143.Dec 13 2021, 10:37 PM

Address comment.

dblaikie accepted this revision.Dec 14 2021, 10:41 AM

Looks great, thanks!

This revision is now accepted and ready to land.Dec 14 2021, 10:41 AM
This revision was landed with ongoing or failed builds.Dec 14 2021, 11:38 PM
This revision was automatically updated to reflect the committed changes.