This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GlobalISel] Handle hasPostISelHook for atomic inst without return.
AbandonedPublic

Authored by abinavpp on Dec 5 2021, 8:11 PM.

Details

Summary

This change copies the SelectionDAG's handling of hasPostISelHook for
atomic instructions with no use to global-isel. This will enable
selecting the no return version of the atomic instructions in
global-isel.

Diff Detail

Event Timeline

abinavpp created this revision.Dec 5 2021, 8:11 PM
abinavpp requested review of this revision.Dec 5 2021, 8:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2021, 8:11 PM
foad added inline comments.Dec 6 2021, 2:23 AM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
11601

use_nodbg_empty?

arsenm added a comment.Dec 6 2021, 7:12 AM

I was hoping to avoid reproducing the SelectionDAG scheme for this. IMO the main reason for the existence of post-isel hooks is workarounds for DAG limitations. I guess we could move this to patterns in the DAG anyway, so I guess that's a separate improvement.

I was hoping to avoid reproducing the SelectionDAG scheme for this. IMO the main reason for the existence of post-isel hooks is workarounds for DAG limitations. I guess we could move this to patterns in the DAG anyway, so I guess that's a separate improvement.

D115881 is an attempt to do this in tblgen.

abinavpp abandoned this revision.Mar 24 2022, 9:13 PM

TableGen based handling of this is in progress

Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 9:13 PM
Herald added a subscriber: hsmhsm. · View Herald Transcript