This is an archive of the discontinued LLVM Phabricator instance.

Differential D114883

[BuildLibCalls] Add support for memset_pattern{4,8}.
ClosedPublic

Authored by fhahn on Dec 1 2021, 8:40 AM.

Details

Reviewers
efriedma
ab
t.p.northover
Commits
rG2de5f39e546d: [BuildLibCalls] Add support for memset_pattern{4,8}.
Summary

Add support for memset_pattern{4,8} similar to the existing
memset_pattern16 handling.

Diff Detail

Unit TestsFailed

TimeTest
14,740 msx64 debian > libFuzzer.libFuzzer::entropic-scale-per-exec-time.test

Event Timeline

fhahn created this revision.Dec 1 2021, 8:40 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptDec 1 2021, 8:40 AM
fhahn requested review of this revision.Dec 1 2021, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 8:40 AM
fhahn added a parent revision: D114881: [TLI] Add memset_pattern4, memset_pattern8 lib functions..Dec 1 2021, 8:40 AM
Harbormaster completed remote builds in B136936: Diff 391045.Dec 1 2021, 9:23 AM
ab accepted this revision.Dec 1 2021, 10:24 AM

Quite the old TODO, nice ;) LGTM!

This revision is now accepted and ready to land.Dec 1 2021, 10:24 AM
fhahn updated this revision to Diff 391259.Dec 2 2021, 2:16 AM

rebase on top of precommitted tests

fhahn added a child revision: D114904: [BuildLibCalls] Add nounwind,willreturn to memset_pattern{4,8,16}..Dec 2 2021, 2:16 AM
Harbormaster completed remote builds in B137098: Diff 391259.Dec 2 2021, 2:56 AM
This revision was landed with ongoing or failed builds.Dec 2 2021, 3:04 AM
Closed by commit rG2de5f39e546d: [BuildLibCalls] Add support for memset_pattern{4,8}. (authored by fhahn). · Explain Why
This revision was automatically updated to reflect the committed changes.
fhahn added a commit: rG2de5f39e546d: [BuildLibCalls] Add support for memset_pattern{4,8}..

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
5 lines
test/
Transforms/
InferFunctionAttrs/
6 lines

Diff 391259

llvm/lib/Transforms/Utils/BuildLibCalls.cpp

Show First 20 Lines • Show All 1,011 Lines • ▼ Show 20 Lines case LibFunc_gettimeofday:
// Currently some platforms have the restrict keyword on the arguments to // Currently some platforms have the restrict keyword on the arguments to
// gettimeofday. To be conservative, do not add noalias to gettimeofday's // gettimeofday. To be conservative, do not add noalias to gettimeofday's
// arguments. // arguments.
Changed |= setRetAndArgsNoUndef(F); Changed |= setRetAndArgsNoUndef(F);
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setDoesNotCapture(F, 0); Changed |= setDoesNotCapture(F, 0);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
return Changed; return Changed;
// TODO: add LibFunc entries for: case LibFunc_memset_pattern4:
// case LibFunc_memset_pattern4: case LibFunc_memset_pattern8:
// case LibFunc_memset_pattern8:
case LibFunc_memset_pattern16: case LibFunc_memset_pattern16:
Changed |= setOnlyAccessesArgMemory(F); Changed |= setOnlyAccessesArgMemory(F);
Changed |= setDoesNotCapture(F, 0); Changed |= setDoesNotCapture(F, 0);
Changed |= setOnlyWritesMemory(F, 0); Changed |= setOnlyWritesMemory(F, 0);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 1); Changed |= setOnlyReadsMemory(F, 1);
return Changed; return Changed;
case LibFunc_memset: case LibFunc_memset:
▲ Show 20 Lines • Show All 649 Lines • Show Last 20 Lines

llvm/test/Transforms/InferFunctionAttrs/annotate.ll

Show First 20 Lines • Show All 1,006 Lines • ▼ Show 20 Lines
; CHECK: declare noundef i32 @vsscanf(i8* nocapture noundef readonly, i8* nocapture noundef readonly, %opaque* noundef) [[NOFREE_NOUNWIND]] ; CHECK: declare noundef i32 @vsscanf(i8* nocapture noundef readonly, i8* nocapture noundef readonly, %opaque* noundef) [[NOFREE_NOUNWIND]]
declare i32 @vsscanf(i8*, i8*, %opaque*) declare i32 @vsscanf(i8*, i8*, %opaque*)
; CHECK: declare noundef i64 @write(i32 noundef, i8* nocapture noundef readonly, i64 noundef) [[NOFREE]] ; CHECK: declare noundef i64 @write(i32 noundef, i8* nocapture noundef readonly, i64 noundef) [[NOFREE]]
declare i64 @write(i32, i8*, i64) declare i64 @write(i32, i8*, i64)
; memset_pattern{4,8,16} aren't available everywhere. ; memset_pattern{4,8,16} aren't available everywhere.
; CHECK-DARWIN: declare void @memset_pattern4(i8*, i8*, i64) [[NOFREE]] ; CHECK-DARWIN: declare void @memset_pattern4(i8* nocapture writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE:#[0-9]+]]
declare void @memset_pattern4(i8*, i8*, i64) declare void @memset_pattern4(i8*, i8*, i64)
; CHECK-DARWIN: declare void @memset_pattern8(i8*, i8*, i64) [[NOFREE]] ; CHECK-DARWIN: declare void @memset_pattern8(i8* nocapture writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE]]
declare void @memset_pattern8(i8*, i8*, i64) declare void @memset_pattern8(i8*, i8*, i64)
; CHECK-DARWIN: declare void @memset_pattern16(i8* nocapture writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE:#[0-9]+]] ; CHECK-DARWIN: declare void @memset_pattern16(i8* nocapture writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE]]
declare void @memset_pattern16(i8*, i8*, i64) declare void @memset_pattern16(i8*, i8*, i64)
; CHECK-DAG: attributes [[NOFREE_NOUNWIND_WILLRETURN]] = { mustprogress nofree nounwind willreturn } ; CHECK-DAG: attributes [[NOFREE_NOUNWIND_WILLRETURN]] = { mustprogress nofree nounwind willreturn }
; CHECK-DAG: attributes [[NOFREE_NOUNWIND]] = { nofree nounwind } ; CHECK-DAG: attributes [[NOFREE_NOUNWIND]] = { nofree nounwind }
; CHECK-DAG: attributes [[INACCESSIBLEMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] = { inaccessiblememonly mustprogress nofree nounwind willreturn } ; CHECK-DAG: attributes [[INACCESSIBLEMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] = { inaccessiblememonly mustprogress nofree nounwind willreturn }
; CHECK-DAG: attributes [[NOFREE_NOUNWIND_READONLY_WILLRETURN]] = { mustprogress nofree nounwind readonly willreturn } ; CHECK-DAG: attributes [[NOFREE_NOUNWIND_READONLY_WILLRETURN]] = { mustprogress nofree nounwind readonly willreturn }
; CHECK-DAG: attributes [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] = { argmemonly mustprogress nofree nounwind willreturn } ; CHECK-DAG: attributes [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] = { argmemonly mustprogress nofree nounwind willreturn }
Show All 11 Lines