Page MenuHomePhabricator

[OpenMP][test] Regression tests for OpenMPIRBuilder.

Authored by Meinersbur on Nov 23 2021, 9:40 PM.



Categorize libomp regression tests according to whether they currently work with -fopenmp-enable-irbuilder. Tests marked with XFAIL are reliably failing. Tests with UNSUPPORTED fail or succeed occasionally. Add some additional tests that currently fail using the OpenMPIRBuilder.

Diff Detail

Event Timeline

Meinersbur created this revision.Nov 23 2021, 9:40 PM
Meinersbur requested review of this revision.Nov 23 2021, 9:40 PM
Meinersbur updated this revision to Diff 392407.Dec 7 2021, 8:07 AM

Rebase to head-of-tree

  • Fix/adapt tests
Leporacanthicus accepted this revision.Dec 8 2021, 2:58 AM

LGTM. Just one nit-pick, there's a few new tests that test some pretty specific things. Would be nice to have a line or three about what they actually test - e.g "Tests that destructor is not called until after OpenMP section has completed".


Would be nice to describe what the test is actually testing.

Although some of the other tests do not describe the purpose either!

This revision is now accepted and ready to land.Dec 8 2021, 2:58 AM

The two additional tests cause clang with -fopenmp-enable-irbuilder to crash, their introduction is not motivated by a specific execution behaviour (although that is useful too). D115216 is the basis to fix those. I will add descriptions to the tests.