Categorize libomp regression tests according to whether they currently work with -fopenmp-enable-irbuilder. Tests marked with XFAIL are reliably failing. Tests with UNSUPPORTED fail or succeed occasionally. Add some additional tests that currently fail using the OpenMPIRBuilder.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM. Just one nit-pick, there's a few new tests that test some pretty specific things. Would be nice to have a line or three about what they actually test - e.g "Tests that destructor is not called until after OpenMP section has completed".
openmp/runtime/test/parallel/omp_dtor_parallel_dtor.cpp | ||
---|---|---|
9 | Would be nice to describe what the test is actually testing. Although some of the other tests do not describe the purpose either! |
The two additional tests cause clang with -fopenmp-enable-irbuilder to crash, their introduction is not motivated by a specific execution behaviour (although that is useful too). D115216 is the basis to fix those. I will add descriptions to the tests.
Would be nice to describe what the test is actually testing.
Although some of the other tests do not describe the purpose either!