[NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

[kuhnel]

Summary

The file follows the LSP syntax, so we're intentially deviating
from the LLVM coding standard.

[kbobyrev]

clang-tools-extra/clangd/Protocol.h

39

Nit: we're only using C-style comments for single-line parameter name "injection".

Context:

https://llvm.org/docs/CodingStandards.html#comment-formatting

[hokein]

This looks the best we can do, please address Kirill's comment.

I spotted a related crash bug (https://github.com/clangd/clangd/issues/929) in clangd, but I think this patch should be fine to go.

[kuhnel]

I just checked with my local clangd and it does not crash on this file...

[hokein]

In D113889#3134857, @kuhnel wrote:

I just checked with my local clangd and it does not crash on this file...

yeah, this file is fine, the crash only occurs if you use an assertion-enabled clangd and the code has an unmatched NOLINTBEGIN.

clang-tools-extra/clangd/Protocol.h

 #include "llvm/ADT/SmallVector.h"
 #include "llvm/Support/JSON.h"
 #include "llvm/Support/raw_ostream.h"
 #include <bitset>
 #include <memory>
 #include <string>
 #include <vector>
 
+// This file is using the LSP syntax for identifier names which is different
+// from the LLVM coding standard. To avoid the clang-tidy warnings, we're
+// disabling one check here.
+// NOLINTBEGIN(readability-identifier-naming)
+
 namespace clang {
 namespace clangd {
 
 enum class ErrorCode {
   // Defined by JSON RPC.
   ParseError = -32700,
   InvalidRequest = -32600,
   MethodNotFound = -32601,
template <> struct format_provider<clang::clangd::Position> {
   static void format(const clang::clangd::Position &Pos, raw_ostream &OS,
                      StringRef Style) {
     assert(Style.empty() && "style modifiers for this type are not supported");
     OS << Pos;
   }
 };
 } // namespace llvm
 
+// NOLINTEND(readability-identifier-naming)
+
 #endif