Please use GitHub pull requests for new patches. Phabricator shutdown timeline

In D121824#3399208, @sammccall wrote:

I reduced something very similar recently as https://github.com/clangd/clangd/issues/1073

This patch does not fix it, but looks closely related, want to take a look?

Mar 22 2022, 10:15 AM · Restricted Project, Restricted Project

adamcz updated the diff for D121824: [clang] Do not crash on arrow operator on dependent type..

Reverted to previous version + new test

Mar 22 2022, 10:15 AM · Restricted Project, Restricted Project

Mar 21 2022

adamcz added a comment to D122102: [clangd] Introduce "add subclass" tweak.

Thanks, this looks really good! I always wanted a code action like this.

Mar 21 2022, 11:39 AM · Restricted Project, Restricted Project

adamcz committed rG6009d0d5801d: [clangd] Track time spent in filesystem ops during preamble builds (authored by adamcz).

[clangd] Track time spent in filesystem ops during preamble builds

Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project

adamcz closed D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project

adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

fix comments

Mar 21 2022, 10:29 AM · Restricted Project, Restricted Project

adamcz added inline comments to D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Mar 21 2022, 8:28 AM · Restricted Project, Restricted Project

adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

more review comments

Mar 21 2022, 8:28 AM · Restricted Project, Restricted Project

Mar 18 2022

adamcz added a comment to D121824: [clang] Do not crash on arrow operator on dependent type..

I updated the change. Let me know if this is what you had in mind.
I kept the original test too, can't hurt right?

Mar 18 2022, 10:36 AM · Restricted Project, Restricted Project

adamcz updated the diff for D121824: [clang] Do not crash on arrow operator on dependent type..

changed to marking VarDecl as invalid if it's ref type and initializer is invalid

Mar 18 2022, 10:36 AM · Restricted Project, Restricted Project

Mar 16 2022

adamcz added a comment to D121712: [clangd] Track time spent in filesystem ops during preamble builds.

In D121712#3383944, @Trass3r wrote:

Hmm just a few curious questions from the sidelines.
Why a "custom system" instead of something -ftime-trace based?

Mar 16 2022, 11:38 AM · Restricted Project, Restricted Project

adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

addressed review comments

Mar 16 2022, 11:38 AM · Restricted Project, Restricted Project

adamcz requested review of D121824: [clang] Do not crash on arrow operator on dependent type..

Mar 16 2022, 9:44 AM · Restricted Project, Restricted Project

Mar 15 2022

adamcz requested review of D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Mar 15 2022, 9:23 AM · Restricted Project, Restricted Project

Mar 1 2022

adamcz accepted D120619: [clangd] Support include-fixer inside macro arguments..

Mar 1 2022, 8:19 AM · Restricted Project, Restricted Project

adamcz committed rG8f4ea36bfe4c: [clang] Improve laziness of resolving module map headers. (authored by adamcz).

[clang] Improve laziness of resolving module map headers.

Mar 1 2022, 7:02 AM

adamcz closed D120569: [clang] Improve laziness of resolving module map headers..

Mar 1 2022, 7:02 AM · Restricted Project

Feb 25 2022

adamcz requested review of D120569: [clang] Improve laziness of resolving module map headers..

Feb 25 2022, 8:31 AM · Restricted Project

Nov 18 2021

adamcz committed rG55a79318c60d: [clang][clangd] Improve signature help for variadic functions. (authored by adamcz).

[clang][clangd] Improve signature help for variadic functions.

Nov 18 2021, 7:03 AM

adamcz closed D111318: [clang][clangd] Improve signature help for variadic functions..

Nov 18 2021, 7:02 AM · Restricted Project, Restricted Project

adamcz added a comment to D111318: [clang][clangd] Improve signature help for variadic functions..

Added a slightly awkward clang (not clangd) test. The output is suboptimial, because it's not clangd, but it shows things work as they should.

Nov 18 2021, 5:36 AM · Restricted Project, Restricted Project

adamcz updated the diff for D111318: [clang][clangd] Improve signature help for variadic functions..

addressed review comments, added new test

Nov 18 2021, 5:34 AM · Restricted Project, Restricted Project

Nov 17 2021

adamcz accepted D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Looks good. Thanks!

Nov 17 2021, 5:39 AM · Restricted Project, Restricted Project

Nov 10 2021

adamcz added a reverting change for rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays.: rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 12:01 PM

adamcz added a reverting change for D113120: [clang] Add early exit when checking for const init of arrays.: rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 12:01 PM · Restricted Project

adamcz committed rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays." (authored by adamcz).

Revert "[clang] Add early exit when checking for const init of arrays."

Nov 10 2021, 12:01 PM

adamcz closed D113599: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 12:01 PM · Restricted Project

adamcz added a reverting change for rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays.: D113599: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 11:50 AM

adamcz requested review of D113599: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 11:50 AM · Restricted Project

adamcz added a reverting change for D113120: [clang] Add early exit when checking for const init of arrays.: D113599: Revert "[clang] Add early exit when checking for const init of arrays.".

Nov 10 2021, 11:50 AM · Restricted Project

adamcz added a comment to D113120: [clang] Add early exit when checking for const init of arrays..

Sorry for trouble, I will revert this for now.

Nov 10 2021, 11:49 AM · Restricted Project

adamcz committed rG581a6a8118f5: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test. (authored by adamcz).

[clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

Nov 10 2021, 10:26 AM

adamcz closed D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test..

Nov 10 2021, 10:25 AM · Restricted Project

adamcz requested review of D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test..

Nov 10 2021, 10:21 AM · Restricted Project

adamcz committed rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays. (authored by adamcz).

[clang] Add early exit when checking for const init of arrays.

Nov 10 2021, 9:18 AM

adamcz closed D113120: [clang] Add early exit when checking for const init of arrays..

Nov 10 2021, 9:18 AM · Restricted Project

adamcz committed rG7a2b1bdb4c8a: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs. (authored by adamcz).

[clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

Nov 10 2021, 8:18 AM

adamcz closed D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs..

Nov 10 2021, 8:18 AM · Restricted Project, Restricted Project

adamcz requested review of D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs..

Nov 10 2021, 7:30 AM · Restricted Project, Restricted Project

Nov 5 2021

adamcz added inline comments to D113120: [clang] Add early exit when checking for const init of arrays..

Nov 5 2021, 9:34 AM · Restricted Project

adamcz updated the diff for D113120: [clang] Add early exit when checking for const init of arrays..

review comments

Nov 5 2021, 9:34 AM · Restricted Project

adamcz added a comment to D111318: [clang][clangd] Improve signature help for variadic functions..

Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before).

Nov 5 2021, 7:45 AM · Restricted Project, Restricted Project

adamcz updated the diff for D111318: [clang][clangd] Improve signature help for variadic functions..

addressed review comment

Nov 5 2021, 7:45 AM · Restricted Project, Restricted Project

Nov 4 2021

adamcz committed rG97fbc975fab1: [clangd] Find definition of ClassTemplate without going through index. (authored by adamcz).

[clangd] Find definition of ClassTemplate without going through index.

Nov 4 2021, 7:26 AM

adamcz closed D113029: [clangd] Find definition of ClassTemplate without going through index..

Nov 4 2021, 7:26 AM · Restricted Project

Nov 3 2021

adamcz added a comment to D113120: [clang] Add early exit when checking for const init of arrays..

Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you think.

Nov 3 2021, 8:56 AM · Restricted Project

adamcz requested review of D113120: [clang] Add early exit when checking for const init of arrays..

Nov 3 2021, 8:55 AM · Restricted Project