Page MenuHomePhabricator

adamcz (Adam Czachorowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2020, 5:57 AM (120 w, 1 h)

Recent Activity

Tue, Jun 14

adamcz accepted D127749: [clangd] Wire up compilation for style blocks.

Wait, what? How? Whaaat? How did that happen?

Tue, Jun 14, 8:12 AM · Restricted Project, Restricted Project

May 20 2022

adamcz accepted D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs.
May 20 2022, 6:15 AM · Restricted Project, Restricted Project

Apr 21 2022

adamcz accepted D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory.
Apr 21 2022, 9:12 AM · Restricted Project, Restricted Project
adamcz committed rGad46aaede6e4: [clangd] Add beforeExecute() callback to FeatureModules. (authored by adamcz).
[clangd] Add beforeExecute() callback to FeatureModules.
Apr 21 2022, 9:05 AM · Restricted Project, Restricted Project
adamcz closed D124176: [clangd] Add beforeExecute() callback to FeatureModules..
Apr 21 2022, 9:04 AM · Restricted Project, Restricted Project
adamcz updated the diff for D124176: [clangd] Add beforeExecute() callback to FeatureModules..

addressed review comments

Apr 21 2022, 8:51 AM · Restricted Project, Restricted Project
adamcz accepted D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC.
Apr 21 2022, 7:46 AM · Restricted Project, Restricted Project
adamcz requested review of D124176: [clangd] Add beforeExecute() callback to FeatureModules..
Apr 21 2022, 7:29 AM · Restricted Project, Restricted Project

Apr 13 2022

adamcz accepted D123672: [clangd] Export preamble AST and serialized size as metrics.
Apr 13 2022, 5:41 AM · Restricted Project, Restricted Project
adamcz added inline comments to D123672: [clangd] Export preamble AST and serialized size as metrics.
Apr 13 2022, 5:21 AM · Restricted Project, Restricted Project

Apr 1 2022

adamcz accepted D122894: [clangd] Record IO precentage for first preamble build of the instance.
Apr 1 2022, 6:12 AM · Restricted Project, Restricted Project
adamcz added a comment to D122894: [clangd] Record IO precentage for first preamble build of the instance.

Thanks, I was just about to fix that!

Apr 1 2022, 4:56 AM · Restricted Project, Restricted Project

Mar 25 2022

adamcz committed rG7e459126185f: [clang] Do not crash on arrow operator on dependent type. (authored by adamcz).
[clang] Do not crash on arrow operator on dependent type.
Mar 25 2022, 7:53 AM · Restricted Project, Restricted Project
adamcz closed D121824: [clang] Do not crash on arrow operator on dependent type..
Mar 25 2022, 7:53 AM · Restricted Project, Restricted Project
adamcz added a comment to D121824: [clang] Do not crash on arrow operator on dependent type..

Thanks for all the comments!

Mar 25 2022, 7:47 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121824: [clang] Do not crash on arrow operator on dependent type..

added a comment

Mar 25 2022, 7:47 AM · Restricted Project, Restricted Project

Mar 22 2022

adamcz added a comment to D121824: [clang] Do not crash on arrow operator on dependent type..

I reduced something very similar recently as https://github.com/clangd/clangd/issues/1073

This patch does not fix it, but looks closely related, want to take a look?

Mar 22 2022, 10:15 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121824: [clang] Do not crash on arrow operator on dependent type..

Reverted to previous version + new test

Mar 22 2022, 10:15 AM · Restricted Project, Restricted Project

Mar 21 2022

adamcz added a comment to D122102: [clangd] Introduce "add subclass" tweak.

Thanks, this looks really good! I always wanted a code action like this.

Mar 21 2022, 11:39 AM · Restricted Project, Restricted Project
adamcz committed rG6009d0d5801d: [clangd] Track time spent in filesystem ops during preamble builds (authored by adamcz).
[clangd] Track time spent in filesystem ops during preamble builds
Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project
adamcz closed D121712: [clangd] Track time spent in filesystem ops during preamble builds.
Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

fix comments

Mar 21 2022, 10:29 AM · Restricted Project, Restricted Project
adamcz added inline comments to D121712: [clangd] Track time spent in filesystem ops during preamble builds.
Mar 21 2022, 8:28 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

more review comments

Mar 21 2022, 8:28 AM · Restricted Project, Restricted Project

Mar 18 2022

adamcz added a comment to D121824: [clang] Do not crash on arrow operator on dependent type..

I updated the change. Let me know if this is what you had in mind.
I kept the original test too, can't hurt right?

Mar 18 2022, 10:36 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121824: [clang] Do not crash on arrow operator on dependent type..

changed to marking VarDecl as invalid if it's ref type and initializer is invalid

Mar 18 2022, 10:36 AM · Restricted Project, Restricted Project

Mar 16 2022

adamcz added a comment to D121712: [clangd] Track time spent in filesystem ops during preamble builds.

Hmm just a few curious questions from the sidelines.
Why a "custom system" instead of something -ftime-trace based?

Mar 16 2022, 11:38 AM · Restricted Project, Restricted Project
adamcz updated the diff for D121712: [clangd] Track time spent in filesystem ops during preamble builds.

addressed review comments

Mar 16 2022, 11:38 AM · Restricted Project, Restricted Project
adamcz requested review of D121824: [clang] Do not crash on arrow operator on dependent type..
Mar 16 2022, 9:44 AM · Restricted Project, Restricted Project

Mar 15 2022

adamcz requested review of D121712: [clangd] Track time spent in filesystem ops during preamble builds.
Mar 15 2022, 9:23 AM · Restricted Project, Restricted Project

Mar 1 2022

adamcz accepted D120619: [clangd] Support include-fixer inside macro arguments..
Mar 1 2022, 8:19 AM · Restricted Project, Restricted Project
adamcz committed rG8f4ea36bfe4c: [clang] Improve laziness of resolving module map headers. (authored by adamcz).
[clang] Improve laziness of resolving module map headers.
Mar 1 2022, 7:02 AM
adamcz closed D120569: [clang] Improve laziness of resolving module map headers..
Mar 1 2022, 7:02 AM · Restricted Project

Feb 25 2022

adamcz requested review of D120569: [clang] Improve laziness of resolving module map headers..
Feb 25 2022, 8:31 AM · Restricted Project

Nov 18 2021

adamcz committed rG55a79318c60d: [clang][clangd] Improve signature help for variadic functions. (authored by adamcz).
[clang][clangd] Improve signature help for variadic functions.
Nov 18 2021, 7:03 AM
adamcz closed D111318: [clang][clangd] Improve signature help for variadic functions..
Nov 18 2021, 7:02 AM · Restricted Project, Restricted Project
adamcz added a comment to D111318: [clang][clangd] Improve signature help for variadic functions..

Added a slightly awkward clang (not clangd) test. The output is suboptimial, because it's not clangd, but it shows things work as they should.

Nov 18 2021, 5:36 AM · Restricted Project, Restricted Project
adamcz updated the diff for D111318: [clang][clangd] Improve signature help for variadic functions..

addressed review comments, added new test

Nov 18 2021, 5:34 AM · Restricted Project, Restricted Project

Nov 17 2021

adamcz accepted D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Looks good. Thanks!

Nov 17 2021, 5:39 AM · Restricted Project, Restricted Project

Nov 10 2021

adamcz added a reverting change for rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays.: rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 12:01 PM
adamcz added a reverting change for D113120: [clang] Add early exit when checking for const init of arrays.: rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 12:01 PM · Restricted Project
adamcz committed rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for const init of arrays." (authored by adamcz).
Revert "[clang] Add early exit when checking for const init of arrays."
Nov 10 2021, 12:01 PM
adamcz closed D113599: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 12:01 PM · Restricted Project
adamcz added a reverting change for rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays.: D113599: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 11:50 AM
adamcz requested review of D113599: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 11:50 AM · Restricted Project
adamcz added a reverting change for D113120: [clang] Add early exit when checking for const init of arrays.: D113599: Revert "[clang] Add early exit when checking for const init of arrays.".
Nov 10 2021, 11:50 AM · Restricted Project
adamcz added a comment to D113120: [clang] Add early exit when checking for const init of arrays..

Sorry for trouble, I will revert this for now.

Nov 10 2021, 11:49 AM · Restricted Project
adamcz committed rG581a6a8118f5: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test. (authored by adamcz).
[clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.
Nov 10 2021, 10:26 AM
adamcz closed D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test..
Nov 10 2021, 10:25 AM · Restricted Project
adamcz requested review of D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test..
Nov 10 2021, 10:21 AM · Restricted Project
adamcz committed rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays. (authored by adamcz).
[clang] Add early exit when checking for const init of arrays.
Nov 10 2021, 9:18 AM
adamcz closed D113120: [clang] Add early exit when checking for const init of arrays..
Nov 10 2021, 9:18 AM · Restricted Project
adamcz committed rG7a2b1bdb4c8a: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs. (authored by adamcz).
[clang] Do not crash in APValue::prettyPrint() on forward-decl structs.
Nov 10 2021, 8:18 AM
adamcz closed D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs..
Nov 10 2021, 8:18 AM · Restricted Project, Restricted Project
adamcz requested review of D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs..
Nov 10 2021, 7:30 AM · Restricted Project, Restricted Project

Nov 5 2021

adamcz added inline comments to D113120: [clang] Add early exit when checking for const init of arrays..
Nov 5 2021, 9:34 AM · Restricted Project
adamcz updated the diff for D113120: [clang] Add early exit when checking for const init of arrays..

review comments

Nov 5 2021, 9:34 AM · Restricted Project
adamcz added a comment to D111318: [clang][clangd] Improve signature help for variadic functions..

Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before).

Nov 5 2021, 7:45 AM · Restricted Project, Restricted Project
adamcz updated the diff for D111318: [clang][clangd] Improve signature help for variadic functions..

addressed review comment

Nov 5 2021, 7:45 AM · Restricted Project, Restricted Project

Nov 4 2021

adamcz committed rG97fbc975fab1: [clangd] Find definition of ClassTemplate without going through index. (authored by adamcz).
[clangd] Find definition of ClassTemplate without going through index.
Nov 4 2021, 7:26 AM
adamcz closed D113029: [clangd] Find definition of ClassTemplate without going through index..
Nov 4 2021, 7:26 AM · Restricted Project

Nov 3 2021

adamcz added a comment to D113120: [clang] Add early exit when checking for const init of arrays..

Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you think.

Nov 3 2021, 8:56 AM · Restricted Project
adamcz requested review of D113120: [clang] Add early exit when checking for const init of arrays..
Nov 3 2021, 8:55 AM · Restricted Project

Nov 2 2021

adamcz requested review of D113029: [clangd] Find definition of ClassTemplate without going through index..
Nov 2 2021, 9:51 AM · Restricted Project

Oct 27 2021

adamcz requested review of D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone..
Oct 27 2021, 8:36 AM · Restricted Project

Oct 26 2021

adamcz committed rG2174524116a8: [clangd] AddUsing: Fix support for template specializations. (authored by adamcz).
[clangd] AddUsing: Fix support for template specializations.
Oct 26 2021, 8:35 AM
adamcz closed D112530: [clangd] AddUsing: Fix support for template specializations..
Oct 26 2021, 8:35 AM · Restricted Project
adamcz committed rGe8f4a0118914: [clangd] Fix a hover crash on templated spaceship operator. (authored by adamcz).
[clangd] Fix a hover crash on templated spaceship operator.
Oct 26 2021, 8:31 AM
adamcz closed D112527: [clangd] Fix a hover crash on templated spaceship operator..
Oct 26 2021, 8:31 AM · Restricted Project
adamcz updated the diff for D112530: [clangd] AddUsing: Fix support for template specializations..

review comments

Oct 26 2021, 8:13 AM · Restricted Project
adamcz removed a reviewer for D112530: [clangd] AddUsing: Fix support for template specializations.: usaxena95.

Thanks Kadir!

Oct 26 2021, 8:13 AM · Restricted Project
adamcz updated the diff for D112527: [clangd] Fix a hover crash on templated spaceship operator..

review comments

Oct 26 2021, 8:02 AM · Restricted Project
adamcz added a reviewer for D112530: [clangd] AddUsing: Fix support for template specializations.: usaxena95.
Oct 26 2021, 6:14 AM · Restricted Project
adamcz requested review of D112530: [clangd] AddUsing: Fix support for template specializations..
Oct 26 2021, 6:12 AM · Restricted Project
adamcz requested review of D112527: [clangd] Fix a hover crash on templated spaceship operator..
Oct 26 2021, 4:39 AM · Restricted Project

Oct 19 2021

adamcz committed rG8fbac4e88ac3: [clangd] Add code completion of param name on /* inside function calls. (authored by adamcz).
[clangd] Add code completion of param name on /* inside function calls.
Oct 19 2021, 4:04 AM
adamcz closed D110823: [clangd] Add code completion of param name on /* inside function calls..
Oct 19 2021, 4:04 AM · Restricted Project
adamcz added inline comments to D110823: [clangd] Add code completion of param name on /* inside function calls..
Oct 19 2021, 4:00 AM · Restricted Project
adamcz updated the diff for D110823: [clangd] Add code completion of param name on /* inside function calls..

final review comment (dropped Preamble check)

Oct 19 2021, 4:00 AM · Restricted Project

Oct 18 2021

adamcz accepted D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Fix LGTM

Oct 18 2021, 4:46 AM · Restricted Project, Restricted Project

Oct 13 2021

adamcz committed rGfba563e92b64: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args. (authored by adamcz).
[clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.
Oct 13 2021, 4:17 AM
adamcz closed D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args..
Oct 13 2021, 4:16 AM · Restricted Project
adamcz updated the diff for D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args..

removed unnecessary Flags.clear()

Oct 13 2021, 3:54 AM · Restricted Project

Oct 12 2021

adamcz added inline comments to D110823: [clangd] Add code completion of param name on /* inside function calls..
Oct 12 2021, 9:13 AM · Restricted Project
adamcz updated the diff for D110823: [clangd] Add code completion of param name on /* inside function calls..

next round of review comments

Oct 12 2021, 9:13 AM · Restricted Project
adamcz added a comment to D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args..

Hi Nathan

Oct 12 2021, 7:58 AM · Restricted Project
adamcz requested review of D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args..
Oct 12 2021, 7:57 AM · Restricted Project

Oct 7 2021

adamcz added inline comments to D110823: [clangd] Add code completion of param name on /* inside function calls..
Oct 7 2021, 9:45 AM · Restricted Project
adamcz updated the diff for D110823: [clangd] Add code completion of param name on /* inside function calls..

addressed review comments

Oct 7 2021, 9:44 AM · Restricted Project
adamcz requested review of D111318: [clang][clangd] Improve signature help for variadic functions..
Oct 7 2021, 8:36 AM · Restricted Project, Restricted Project

Sep 30 2021

adamcz added a reviewer for D110823: [clangd] Add code completion of param name on /* inside function calls.: kadircet.
Sep 30 2021, 6:29 AM · Restricted Project
adamcz requested review of D110823: [clangd] Add code completion of param name on /* inside function calls..
Sep 30 2021, 6:20 AM · Restricted Project

Aug 3 2021

adamcz committed rG08128fe7059e: [clang] Make member var invalid when static initializer is invalid. (authored by adamcz).
[clang] Make member var invalid when static initializer is invalid.
Aug 3 2021, 2:58 AM
adamcz closed D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..
Aug 3 2021, 2:58 AM · Restricted Project

Aug 2 2021

adamcz added inline comments to D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..
Aug 2 2021, 9:32 AM · Restricted Project
adamcz updated the diff for D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..

ActOnInializerError instead of SetInvalidDecl

Aug 2 2021, 9:32 AM · Restricted Project

Jul 9 2021

adamcz added a comment to D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..

OK, I think we've got it now :-)

Jul 9 2021, 8:03 AM · Restricted Project
adamcz updated the diff for D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..

Fix a more generic case of invalid static initializer

Jul 9 2021, 8:02 AM · Restricted Project

Jul 7 2021

adamcz added inline comments to D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..
Jul 7 2021, 5:37 AM · Restricted Project
adamcz updated the diff for D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields..

changed to marking field type as invalid

Jul 7 2021, 5:35 AM · Restricted Project