Page MenuHomePhabricator

adamcz (Adam Czachorowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2020, 5:57 AM (64 w, 1 d)

Recent Activity

Thu, Jun 10

adamcz committed rG49eba8bf1780: [clang] Do not crash when ArgTy is null in CheckArgAlignment (authored by adamcz).
[clang] Do not crash when ArgTy is null in CheckArgAlignment
Thu, Jun 10, 7:59 AM
adamcz closed D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.
Thu, Jun 10, 7:59 AM · Restricted Project
adamcz updated the diff for D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

updated after the CXXDefaultArgExpr containsErrors() change.

Thu, Jun 10, 6:28 AM · Restricted Project
adamcz committed rGa95937452f23: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr (authored by adamcz).
[clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr
Thu, Jun 10, 5:59 AM
adamcz closed D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr.
Thu, Jun 10, 5:59 AM · Restricted Project

Wed, Jun 9

adamcz added a comment to D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

Thanks Haojian!
I sent out https://reviews.llvm.org/D103982 for the CXXDefaultArgExpr. I'll update this change after I submit that one.

Wed, Jun 9, 11:28 AM · Restricted Project
adamcz requested review of D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr.
Wed, Jun 9, 10:55 AM · Restricted Project

Tue, Jun 8

adamcz added reviewers for D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment: kadircet, hokein.

FYI The ArgTy.isNull() check is sufficient to fix this. The Arg->containsErrors() is not - it's false in this case, since it seems CXXDefaultArgExpr with RecoveryExpr inside seems to not contains errors, according to containsError(). I can't tell if that's by design, or a bug.

Tue, Jun 8, 9:40 AM · Restricted Project
adamcz updated the diff for D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

Added some containsErrors() calls, not sure if that's the right thing to do

Tue, Jun 8, 9:35 AM · Restricted Project
adamcz updated the diff for D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

update commit description

Tue, Jun 8, 8:38 AM · Restricted Project
adamcz updated the diff for D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.

added a test

Tue, Jun 8, 8:36 AM · Restricted Project

Mon, Jun 7

adamcz requested review of D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment.
Mon, Jun 7, 9:27 AM · Restricted Project
adamcz committed rG721476e6b211: [clang] Fix a crash during code completion (authored by adamcz).
[clang] Fix a crash during code completion
Mon, Jun 7, 4:37 AM
adamcz closed D103472: [clang] Fix a crash during code completion.
Mon, Jun 7, 4:37 AM · Restricted Project

Fri, Jun 4

adamcz committed rGeba3ee04d450: [clangd] Run code completion on each token coverd by --check-lines (authored by adamcz).
[clangd] Run code completion on each token coverd by --check-lines
Fri, Jun 4, 8:52 AM
adamcz closed D103538: [clangd] Run code completion on each token coverd by --check-lines.
Fri, Jun 4, 8:52 AM · Restricted Project
adamcz updated the diff for D103538: [clangd] Run code completion on each token coverd by --check-lines.

review comments

Fri, Jun 4, 8:01 AM · Restricted Project
adamcz added a comment to D103538: [clangd] Run code completion on each token coverd by --check-lines.

I didn't put much thought into where --check-lines goes. It's an interesting thought.

Fri, Jun 4, 8:01 AM · Restricted Project

Wed, Jun 2

adamcz added a reviewer for D103538: [clangd] Run code completion on each token coverd by --check-lines: kadircet.
Wed, Jun 2, 10:49 AM · Restricted Project
adamcz requested review of D103538: [clangd] Run code completion on each token coverd by --check-lines.
Wed, Jun 2, 10:48 AM · Restricted Project

Tue, Jun 1

adamcz added a reviewer for D103472: [clang] Fix a crash during code completion: kadircet.

This is https://github.com/clangd/clangd/issues/771

Tue, Jun 1, 10:58 AM · Restricted Project
adamcz requested review of D103472: [clang] Fix a crash during code completion.
Tue, Jun 1, 10:51 AM · Restricted Project

Thu, May 20

adamcz accepted D102773: [clang] invalidate a non-dependent-type RecordDecl when it has any dependent-type base class specifier..
Thu, May 20, 3:57 AM · Restricted Project

Fri, May 14

adamcz accepted D102418: [clangd] Always default to raw pch format.
Fri, May 14, 7:31 AM · Restricted Project

Apr 30 2021

adamcz committed rGfbfcfdbf6828: [clang] Fix assert() crash when checking undeduced arg alignment (authored by adamcz).
[clang] Fix assert() crash when checking undeduced arg alignment
Apr 30 2021, 7:47 AM
adamcz closed D100667: [clang] Fix assert() crash when checking undeduced arg alignment.
Apr 30 2021, 7:47 AM · Restricted Project
adamcz updated the diff for D100667: [clang] Fix assert() crash when checking undeduced arg alignment.

typeof

Apr 30 2021, 7:25 AM · Restricted Project

Apr 28 2021

adamcz updated the diff for D100667: [clang] Fix assert() crash when checking undeduced arg alignment.

moved the test

Apr 28 2021, 9:41 AM · Restricted Project

Apr 27 2021

adamcz added inline comments to D100667: [clang] Fix assert() crash when checking undeduced arg alignment.
Apr 27 2021, 5:49 AM · Restricted Project
adamcz updated the diff for D100667: [clang] Fix assert() crash when checking undeduced arg alignment.

review comments

Apr 27 2021, 5:23 AM · Restricted Project

Apr 26 2021

adamcz added inline comments to D100667: [clang] Fix assert() crash when checking undeduced arg alignment.
Apr 26 2021, 7:49 AM · Restricted Project
adamcz updated the diff for D100667: [clang] Fix assert() crash when checking undeduced arg alignment.

Added a fix in CreateRecoveryExpr

Apr 26 2021, 7:48 AM · Restricted Project

Apr 23 2021

adamcz committed rGddfbdbfefae0: [clang] Do not crash on template specialization following a fatal error (authored by adamcz).
[clang] Do not crash on template specialization following a fatal error
Apr 23 2021, 4:41 AM
adamcz closed D100675: [clang] Do not crash on template specialization following a fatal error.
Apr 23 2021, 4:41 AM · Restricted Project

Apr 19 2021

adamcz updated the diff for D100675: [clang] Do not crash on template specialization following a fatal error.

minor changes to test

Apr 19 2021, 5:48 AM · Restricted Project

Apr 16 2021

adamcz requested review of D100675: [clang] Do not crash on template specialization following a fatal error.
Apr 16 2021, 11:38 AM · Restricted Project
adamcz added a reviewer for D100667: [clang] Fix assert() crash when checking undeduced arg alignment: hokein.
Apr 16 2021, 11:34 AM · Restricted Project
adamcz requested review of D100667: [clang] Fix assert() crash when checking undeduced arg alignment.
Apr 16 2021, 11:29 AM · Restricted Project

Apr 9 2021

adamcz committed rG3b4936ba2905: [clangd] Add --check-lines to restrict --check to specific lines (authored by adamcz).
[clangd] Add --check-lines to restrict --check to specific lines
Apr 9 2021, 4:54 AM
adamcz closed D98970: [clangd] Add --check-range to restrict --check to specific lines.
Apr 9 2021, 4:53 AM · Restricted Project

Apr 6 2021

adamcz added inline comments to D98970: [clangd] Add --check-range to restrict --check to specific lines.
Apr 6 2021, 9:34 AM · Restricted Project
adamcz added inline comments to D98970: [clangd] Add --check-range to restrict --check to specific lines.
Apr 6 2021, 9:05 AM · Restricted Project
adamcz updated the diff for D98970: [clangd] Add --check-range to restrict --check to specific lines.

addressed review comments + rebase to latest version

Apr 6 2021, 9:05 AM · Restricted Project

Mar 19 2021

adamcz added a reviewer for D98970: [clangd] Add --check-range to restrict --check to specific lines: sammccall.

This has been annoying me for a while ;-)

Mar 19 2021, 11:01 AM · Restricted Project
adamcz requested review of D98970: [clangd] Add --check-range to restrict --check to specific lines.
Mar 19 2021, 10:59 AM · Restricted Project

Mar 9 2021

adamcz committed rG4e1c487004a2: [clang] Fix crash when creating deduction guide. (authored by adamcz).
[clang] Fix crash when creating deduction guide.
Mar 9 2021, 8:02 AM
adamcz closed D97965: [clang] Fix crash when creating deduction guide..
Mar 9 2021, 8:02 AM · Restricted Project
adamcz added inline comments to D97965: [clang] Fix crash when creating deduction guide..
Mar 9 2021, 7:41 AM · Restricted Project
adamcz updated the diff for D97965: [clang] Fix crash when creating deduction guide..

expanded a comment

Mar 9 2021, 7:41 AM · Restricted Project

Mar 4 2021

adamcz added a reviewer for D97965: [clang] Fix crash when creating deduction guide.: hokein.
Mar 4 2021, 9:27 AM · Restricted Project
adamcz updated the diff for D97965: [clang] Fix crash when creating deduction guide..

format

Mar 4 2021, 9:15 AM · Restricted Project
adamcz requested review of D97965: [clang] Fix crash when creating deduction guide..
Mar 4 2021, 9:14 AM · Restricted Project

Jan 25 2021

adamcz committed rG00054382b95a: [clangd] Fix a crash when indexing invalid ObjC method declaration (authored by adamcz).
[clangd] Fix a crash when indexing invalid ObjC method declaration
Jan 25 2021, 6:56 AM
adamcz closed D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 25 2021, 6:55 AM · Restricted Project
adamcz committed rGd462aa5a619a: [clang] Fix a nullptr dereference bug on invalid code (authored by adamcz).
[clang] Fix a nullptr dereference bug on invalid code
Jan 25 2021, 6:03 AM
adamcz closed D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 25 2021, 6:02 AM · Restricted Project

Jan 22 2021

adamcz added a comment to D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.

The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of using minimal repro case (i.e. you don't need to trigger code completion at all)

Jan 22 2021, 10:14 AM · Restricted Project
adamcz added a comment to D95145: [clang] Fix a nullptr dereference bug on invalid code.

PTAL

Jan 22 2021, 8:35 AM · Restricted Project
adamcz updated the diff for D95145: [clang] Fix a nullptr dereference bug on invalid code.

addressed review comments

Jan 22 2021, 8:35 AM · Restricted Project
adamcz added inline comments to D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 22 2021, 8:03 AM · Restricted Project
adamcz updated the diff for D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.

addressed review comments

Jan 22 2021, 8:03 AM · Restricted Project
adamcz added inline comments to D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 22 2021, 6:13 AM · Restricted Project

Jan 21 2021

adamcz requested review of D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 21 2021, 9:05 AM · Restricted Project

Jan 19 2021

adamcz accepted D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Jan 19 2021, 7:17 AM · Restricted Project
adamcz committed rGa6f9077b16da: [clang] Check for nullptr when instantiating late attrs (authored by adamcz).
[clang] Check for nullptr when instantiating late attrs
Jan 19 2021, 4:53 AM
adamcz closed D94933: [clang] Check for nullptr when instantiating late attrs.
Jan 19 2021, 4:53 AM · Restricted Project

Jan 18 2021

adamcz requested review of D94933: [clang] Check for nullptr when instantiating late attrs.
Jan 18 2021, 2:19 PM · Restricted Project
adamcz committed rG196cc96f9a64: [clang] Allow LifetimeExtendedTemporary to have no access specifier (authored by adamcz).
[clang] Allow LifetimeExtendedTemporary to have no access specifier
Jan 18 2021, 10:30 AM
adamcz closed D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 18 2021, 10:29 AM · Restricted Project
adamcz requested review of D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 18 2021, 9:19 AM · Restricted Project
adamcz accepted D94473: [clangd] Use AST-based signals in CodeCompletion..
Jan 18 2021, 8:30 AM · Restricted Project
adamcz added inline comments to D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 18 2021, 8:12 AM · Restricted Project

Jan 15 2021

adamcz requested review of D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 15 2021, 9:42 AM · Restricted Project
adamcz committed rGc77c3d1d18cd: [clangd] Set correct CWD when using compile_flags.txt (authored by adamcz).
[clangd] Set correct CWD when using compile_flags.txt
Jan 15 2021, 5:32 AM
adamcz closed D94699: [clangd] Set correct CWD when using compile_flags.txt.
Jan 15 2021, 5:32 AM · Restricted Project
adamcz committed rGaeaeb9e6bdc9: [clangd] Make ExpandAutoType not available on template params. (authored by adamcz).
[clangd] Make ExpandAutoType not available on template params.
Jan 15 2021, 5:26 AM
adamcz closed D94719: [clangd] Make ExpandAutoType not available on template params..
Jan 15 2021, 5:26 AM · Restricted Project
adamcz added inline comments to D94473: [clangd] Use AST-based signals in CodeCompletion..
Jan 15 2021, 5:17 AM · Restricted Project
adamcz accepted D94697: [clangd] Update CC Ranking model with better sampling..
Jan 15 2021, 4:33 AM · Restricted Project

Jan 14 2021

adamcz edited reviewers for D94699: [clangd] Set correct CWD when using compile_flags.txt, added: kadircet; removed: sammccall.
Jan 14 2021, 1:45 PM · Restricted Project
adamcz requested review of D94719: [clangd] Make ExpandAutoType not available on template params..
Jan 14 2021, 1:44 PM · Restricted Project
adamcz committed rGa71877edfbb7: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base. (authored by adamcz).
[clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.
Jan 14 2021, 12:28 PM
adamcz closed D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base..
Jan 14 2021, 12:28 PM · Restricted Project
adamcz requested review of D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base..
Jan 14 2021, 11:58 AM · Restricted Project
adamcz added a reviewer for D94699: [clangd] Set correct CWD when using compile_flags.txt: sammccall.
Jan 14 2021, 9:23 AM · Restricted Project
adamcz requested review of D94699: [clangd] Set correct CWD when using compile_flags.txt.
Jan 14 2021, 9:22 AM · Restricted Project

Jan 13 2021

adamcz accepted D94424: [clangd] Make AST-based signals available to runWithPreamble..
Jan 13 2021, 10:32 AM · Restricted Project

Jan 12 2021

adamcz added inline comments to D94424: [clangd] Make AST-based signals available to runWithPreamble..
Jan 12 2021, 8:15 AM · Restricted Project

Jan 10 2021

adamcz accepted D94359: [clangd] Remove ScratchFS from tests.

Thanks, that's better than my hacky workaround!

Jan 10 2021, 1:01 PM · Restricted Project

Jan 8 2021

adamcz added a reviewer for D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists: hokein.
Jan 8 2021, 10:17 AM · Restricted Project
adamcz requested review of D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists.
Jan 8 2021, 10:16 AM · Restricted Project
adamcz committed rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (authored by adamcz).
[clangd] Add missing "override" to fix the build.
Jan 8 2021, 8:26 AM
adamcz closed D94314: [clangd] Add missing "override" to fix the build..
Jan 8 2021, 8:26 AM · Restricted Project
adamcz added a reviewer for D94314: [clangd] Add missing "override" to fix the build.: kadircet.
Jan 8 2021, 8:22 AM · Restricted Project
adamcz requested review of D94314: [clangd] Add missing "override" to fix the build..
Jan 8 2021, 8:21 AM · Restricted Project
adamcz committed rGd4af86581e80: [clangd] Fix type printing in the presence of qualifiers (authored by adamcz).
[clangd] Fix type printing in the presence of qualifiers
Jan 8 2021, 8:06 AM
adamcz closed D94259: [clangd] Fix type printing in the presence of qualifiers.
Jan 8 2021, 8:06 AM · Restricted Project
adamcz updated the diff for D94259: [clangd] Fix type printing in the presence of qualifiers.

s/NS/DC

Jan 8 2021, 7:52 AM · Restricted Project
adamcz updated the diff for D94259: [clangd] Fix type printing in the presence of qualifiers.

final review comments

Jan 8 2021, 7:42 AM · Restricted Project
adamcz added a comment to D94259: [clangd] Fix type printing in the presence of qualifiers.

Thanks!

Jan 8 2021, 5:47 AM · Restricted Project