Page MenuHomePhabricator

adamcz (Adam Czachorowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2020, 5:57 AM (36 w, 11 h)

Recent Activity

Today

adamcz committed rG9d87739f664b: [clangd] AddUsing: do not crash on non-namespace using decls. (authored by adamcz).
[clangd] AddUsing: do not crash on non-namespace using decls.
Thu, Nov 26, 11:09 AM
adamcz closed D92186: [clangd] AddUsing: do not crash on non-namespace using decls..
Thu, Nov 26, 11:09 AM · Restricted Project
adamcz added a reviewer for D92186: [clangd] AddUsing: do not crash on non-namespace using decls.: hokein.
Thu, Nov 26, 8:52 AM · Restricted Project
adamcz requested review of D92186: [clangd] AddUsing: do not crash on non-namespace using decls..
Thu, Nov 26, 8:52 AM · Restricted Project

Yesterday

adamcz committed rGf6970503d291: [clangd] PopulateSwitch: disable on dependent enums. (authored by adamcz).
[clangd] PopulateSwitch: disable on dependent enums.
Wed, Nov 25, 5:20 AM
adamcz closed D92051: [clangd] PopulateSwitch: disable on dependent enums..
Wed, Nov 25, 5:20 AM · Restricted Project

Tue, Nov 24

adamcz committed rGa200501bca4d: [clangd] Addusing tweak: find insertion point after definition (authored by adamcz).
[clangd] Addusing tweak: find insertion point after definition
Tue, Nov 24, 2:02 PM
adamcz closed D92053: [clangd] Addusing tweak: find insertion point after definition.
Tue, Nov 24, 2:02 PM · Restricted Project
adamcz added inline comments to D92053: [clangd] Addusing tweak: find insertion point after definition.
Tue, Nov 24, 1:56 PM · Restricted Project
adamcz updated the diff for D92053: [clangd] Addusing tweak: find insertion point after definition.

addressed review comments

Tue, Nov 24, 1:56 PM · Restricted Project
adamcz added a reviewer for D92053: [clangd] Addusing tweak: find insertion point after definition: kadircet.
Tue, Nov 24, 12:03 PM · Restricted Project
adamcz updated the diff for D92053: [clangd] Addusing tweak: find insertion point after definition.

typo in description

Tue, Nov 24, 12:02 PM · Restricted Project
adamcz requested review of D92053: [clangd] Addusing tweak: find insertion point after definition.
Tue, Nov 24, 12:01 PM · Restricted Project
adamcz added a reviewer for D92051: [clangd] PopulateSwitch: disable on dependent enums.: hokein.
Tue, Nov 24, 11:53 AM · Restricted Project
adamcz requested review of D92051: [clangd] PopulateSwitch: disable on dependent enums..
Tue, Nov 24, 11:52 AM · Restricted Project
adamcz committed rGf6e59294b63e: [clangd] AddUsing: Used spelled text instead of type name. (authored by adamcz).
[clangd] AddUsing: Used spelled text instead of type name.
Tue, Nov 24, 10:00 AM
adamcz closed D91966: [clangd] AddUsing: Used spelled text instead of type name..
Tue, Nov 24, 10:00 AM · Restricted Project
adamcz added inline comments to D91966: [clangd] AddUsing: Used spelled text instead of type name..
Tue, Nov 24, 7:17 AM · Restricted Project
adamcz updated the diff for D91966: [clangd] AddUsing: Used spelled text instead of type name..

addressed review comments

Tue, Nov 24, 7:14 AM · Restricted Project

Mon, Nov 23

adamcz added a reviewer for D91966: [clangd] AddUsing: Used spelled text instead of type name.: kadircet.
Mon, Nov 23, 7:20 AM · Restricted Project
adamcz requested review of D91966: [clangd] AddUsing: Used spelled text instead of type name..
Mon, Nov 23, 7:19 AM · Restricted Project

Fri, Nov 20

adamcz committed rG95ce9fbc235a: [clang] Do not crash on pointer wchar_t pointer assignment. (authored by adamcz).
[clang] Do not crash on pointer wchar_t pointer assignment.
Fri, Nov 20, 6:33 AM
adamcz closed D91625: [clang] Do not crash on pointer wchar_t pointer assignment..
Fri, Nov 20, 6:33 AM · Restricted Project

Thu, Nov 19

adamcz accepted D91777: [clangd] No crash on "-verify" mode..
Thu, Nov 19, 6:35 AM · Restricted Project

Wed, Nov 18

adamcz added inline comments to D91625: [clang] Do not crash on pointer wchar_t pointer assignment..
Wed, Nov 18, 7:54 AM · Restricted Project
adamcz updated the diff for D91625: [clang] Do not crash on pointer wchar_t pointer assignment..

addressed review comment

Wed, Nov 18, 7:53 AM · Restricted Project
adamcz accepted D91694: [clangd] Remove the trailing "." in add-using message..
Wed, Nov 18, 4:33 AM · Restricted Project

Tue, Nov 17

adamcz added a reviewer for D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.: hokein.
Tue, Nov 17, 9:06 AM · Restricted Project
adamcz updated the diff for D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion..

Added [clang] in commit description

Tue, Nov 17, 9:06 AM · Restricted Project
adamcz added a reviewer for D91625: [clang] Do not crash on pointer wchar_t pointer assignment.: hokein.
Tue, Nov 17, 5:38 AM · Restricted Project
adamcz updated the diff for D91625: [clang] Do not crash on pointer wchar_t pointer assignment..

rebase

Tue, Nov 17, 5:28 AM · Restricted Project
adamcz requested review of D91625: [clang] Do not crash on pointer wchar_t pointer assignment..
Tue, Nov 17, 5:27 AM · Restricted Project

Fri, Nov 13

adamcz accepted D91380: [clang] Fix an assertion crash in delayed access check..
Fri, Nov 13, 3:31 AM · Restricted Project

Tue, Nov 10

adamcz added a reviewer for D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.: rsmith.
Tue, Nov 10, 7:10 AM · Restricted Project
adamcz requested review of D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion..
Tue, Nov 10, 7:02 AM · Restricted Project

Thu, Nov 5

adamcz accepted D90828: [clangd] Trivial: Log missing completion signals..
Thu, Nov 5, 8:00 AM · Restricted Project

Fri, Oct 30

adamcz accepted D90452: [clangd] Respect codeAction.isPreferredSupport in client capabilities.
Fri, Oct 30, 5:17 AM · Restricted Project

Thu, Oct 29

adamcz accepted D90014: [clangd] Add support for multiple DecisionForest model experiments..
Thu, Oct 29, 10:23 AM · Restricted Project
adamcz accepted D89571: [clangd] Add textDocument/ast extension method to dump the AST.
Thu, Oct 29, 9:31 AM · Restricted Project

Oct 26 2020

adamcz added inline comments to D89571: [clangd] Add textDocument/ast extension method to dump the AST.
Oct 26 2020, 10:46 AM · Restricted Project

Oct 13 2020

adamcz accepted D89307: [clangd] Disable extract variable for RHS of assignments.
Oct 13 2020, 4:48 AM · Restricted Project

Oct 9 2020

adamcz accepted D89119: [clangd] Update CC Ranking model to use SymbolCategory::Macro.
Oct 9 2020, 6:46 AM · Restricted Project

Oct 8 2020

adamcz accepted D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow..
Oct 8 2020, 6:01 AM · Restricted Project

Oct 7 2020

adamcz accepted D88985: [clangd] Temporary fix for bad inference in Decision Forest..

LG, but I'm not sure if we really need it. Up to you.

Oct 7 2020, 10:30 AM · Restricted Project
adamcz committed rGbcd8422d7506: [clangd] Fix argument type (bool->float). (authored by adamcz).
[clangd] Fix argument type (bool->float).
Oct 7 2020, 8:23 AM
adamcz closed D88970: [clangd] Fix argument type (bool->float)..
Oct 7 2020, 8:23 AM · Restricted Project
adamcz requested review of D88970: [clangd] Fix argument type (bool->float)..
Oct 7 2020, 8:09 AM · Restricted Project

Oct 2 2020

adamcz accepted D88590: [clangd] Add benchmark for measuring latency of DecisionForest model..

Still a couple of lint warnings, otherwise LGTM

Oct 2 2020, 7:01 AM · Restricted Project

Oct 1 2020

adamcz added a comment to D88590: [clangd] Add benchmark for measuring latency of DecisionForest model..

Also typo in commit description: bencmark

Oct 1 2020, 9:21 AM · Restricted Project
adamcz added a comment to D88590: [clangd] Add benchmark for measuring latency of DecisionForest model..

Would it make sense to set random seed to something fixed to make this more reproducible?

Oct 1 2020, 9:03 AM · Restricted Project
adamcz accepted D88536: [clangd] Split DecisionForest Evaluate() into one func per tree..
Oct 1 2020, 8:51 AM · Restricted Project

Sep 30 2020

adamcz added inline comments to D88536: [clangd] Split DecisionForest Evaluate() into one func per tree..
Sep 30 2020, 10:42 AM · Restricted Project

Sep 29 2020

adamcz accepted D88495: [clangd] Disable msan instrumentation for generated Evaluate()..
Sep 29 2020, 8:24 AM · Restricted Project

Sep 28 2020

adamcz accepted D88431: [clangd] Rename evaluate() to evaluateHeuristics().

Thanks!

Sep 28 2020, 10:29 AM · Restricted Project
adamcz added a comment to D88281: [clangd] Use Decision Forest to score code completions..

Just noticed: typo in commit description - compeltions

Sep 28 2020, 9:19 AM · Restricted Project
adamcz accepted D88281: [clangd] Use Decision Forest to score code completions..
Sep 28 2020, 6:45 AM · Restricted Project

Sep 25 2020

adamcz accepted D88281: [clangd] Use Decision Forest to score code completions..

Could you add a test that sets this flag? Perhaps we can run CodeCompletionTests.cpp twice, once with this flag, once without? Just to exercise these code paths, I think most expectations there are unordered, so it should work?

Sep 25 2020, 6:59 AM · Restricted Project

Sep 23 2020

adamcz accepted D88071: [clangd] Add a trained DecisionForest for code completion..
Sep 23 2020, 3:36 AM · Restricted Project

Sep 18 2020

adamcz committed rGc894bfd1f580: [clangd] Add option for disabling AddUsing tweak on some namespaces. (authored by adamcz).
[clangd] Add option for disabling AddUsing tweak on some namespaces.
Sep 18 2020, 8:01 AM
adamcz closed D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..
Sep 18 2020, 8:01 AM · Restricted Project
adamcz added inline comments to D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..
Sep 18 2020, 7:31 AM · Restricted Project
adamcz updated the diff for D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..

addressed review comments

Sep 18 2020, 7:31 AM · Restricted Project
adamcz accepted D83814: [clangd] Add Random Forest runtime for code completion..
Sep 18 2020, 6:27 AM · Restricted Project

Sep 17 2020

adamcz added inline comments to D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..
Sep 17 2020, 8:44 AM · Restricted Project
adamcz updated the diff for D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..

addressed review comments

Sep 17 2020, 8:44 AM · Restricted Project
adamcz accepted D87350: [AST][RecoveryExpr] Fix a crash on undeduced type..
Sep 17 2020, 5:20 AM · Restricted Project

Sep 16 2020

adamcz requested review of D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces..
Sep 16 2020, 9:19 AM · Restricted Project
adamcz committed rG7029e5d4ca20: [clangd] Actually parse Index section of the YAML file. (authored by adamcz).
[clangd] Actually parse Index section of the YAML file.
Sep 16 2020, 4:12 AM
adamcz closed D87710: [clangd] Actually parse Index section of the YAML file..
Sep 16 2020, 4:12 AM · Restricted Project

Sep 15 2020

adamcz requested review of D87710: [clangd] Actually parse Index section of the YAML file..
Sep 15 2020, 11:15 AM · Restricted Project
adamcz accepted D87673: [clangd] Don't use zlib when it's unavailable..
Sep 15 2020, 10:41 AM · Restricted Project
adamcz added a comment to D83814: [clangd] Add Random Forest runtime for code completion..

Looks good to me overall, some minor style comments included ;-)

Sep 15 2020, 7:46 AM · Restricted Project

Sep 14 2020

adamcz added inline comments to D83814: [clangd] Add Random Forest runtime for code completion..
Sep 14 2020, 8:05 AM · Restricted Project

Sep 11 2020

adamcz accepted D87501: [clangd] Track tweaks that fail the apply stage.
Sep 11 2020, 6:18 AM · Restricted Project

Sep 7 2020

adamcz added a reviewer for D87253: [libTooling] Change CDB heuristic to look further for files in a given language.: kadircet.

Hey Kadir

Sep 7 2020, 11:34 AM · Restricted Project
adamcz requested review of D87253: [libTooling] Change CDB heuristic to look further for files in a given language..
Sep 7 2020, 11:29 AM · Restricted Project
adamcz added a reviewer for D87244: [clang] Add fix-it for -Wreorder-ctor.: kadircet.
Sep 7 2020, 10:08 AM · Restricted Project
adamcz updated the diff for D87244: [clang] Add fix-it for -Wreorder-ctor..

Add a missing const

Sep 7 2020, 10:07 AM · Restricted Project
adamcz updated the diff for D87244: [clang] Add fix-it for -Wreorder-ctor..

fixed comment typo

Sep 7 2020, 10:06 AM · Restricted Project
adamcz requested review of D87244: [clang] Add fix-it for -Wreorder-ctor..
Sep 7 2020, 10:03 AM · Restricted Project

Aug 26 2020

adamcz committed rGeed0af6179ca: [clang] Exclude invalid destructors from lookups. (authored by adamcz).
[clang] Exclude invalid destructors from lookups.
Aug 26 2020, 10:37 AM
adamcz closed D86624: [clang] Exclude invalid destructors from lookups..
Aug 26 2020, 10:37 AM · Restricted Project
adamcz added inline comments to D86624: [clang] Exclude invalid destructors from lookups..
Aug 26 2020, 8:18 AM · Restricted Project
adamcz updated the diff for D86624: [clang] Exclude invalid destructors from lookups..

addressed review comments

Aug 26 2020, 8:18 AM · Restricted Project
adamcz requested review of D86624: [clang] Exclude invalid destructors from lookups..
Aug 26 2020, 7:46 AM · Restricted Project

Aug 25 2020

adamcz committed rG4d90ff59ac45: [clangd] When inserting "using", add "::" in front if that's the style. (authored by adamcz).
[clangd] When inserting "using", add "::" in front if that's the style.
Aug 25 2020, 5:12 AM
adamcz closed D86473: [clangd] When inserting "using", add "::" in front if that's the style..
Aug 25 2020, 5:12 AM · Restricted Project

Aug 24 2020

adamcz requested review of D86473: [clangd] When inserting "using", add "::" in front if that's the style..
Aug 24 2020, 10:19 AM · Restricted Project

Aug 21 2020

adamcz committed rGb4889353207a: [clangd] Discard diagnostics from another SourceManager. (authored by adamcz).
[clangd] Discard diagnostics from another SourceManager.
Aug 21 2020, 4:24 AM
adamcz closed D85753: [clangd] Discard diagnostics from another SourceManager..
Aug 21 2020, 4:24 AM · Restricted Project

Aug 20 2020

adamcz committed rG707138d67786: [clangd] Remove useless stderr logging. (authored by adamcz).
[clangd] Remove useless stderr logging.
Aug 20 2020, 5:52 AM
adamcz closed D86284: [clangd] Remove useless stderr logging..
Aug 20 2020, 5:52 AM · Restricted Project
adamcz requested review of D86284: [clangd] Remove useless stderr logging..
Aug 20 2020, 5:49 AM · Restricted Project
adamcz committed rGbaeff989b050: [clang] When loading preamble from AST file, re-export modules in Sema. (authored by adamcz).
[clang] When loading preamble from AST file, re-export modules in Sema.
Aug 20 2020, 5:33 AM
adamcz committed rG53b9199a5cdb: [clangd] Fix crash-bug in preamble indexing when using modules. (authored by adamcz).
[clangd] Fix crash-bug in preamble indexing when using modules.
Aug 20 2020, 5:33 AM
adamcz closed D86069: [clang] When loading preamble from AST file, re-export modules in Sema..
Aug 20 2020, 5:33 AM · Restricted Project
adamcz closed D85923: [clangd] Fix crash-bug in preamble indexing when using modules..
Aug 20 2020, 5:33 AM · Restricted Project

Aug 19 2020

adamcz updated the diff for D86069: [clang] When loading preamble from AST file, re-export modules in Sema..

Added comment in place of a FIXME

Aug 19 2020, 7:56 AM · Restricted Project

Aug 18 2020

adamcz added inline comments to D86069: [clang] When loading preamble from AST file, re-export modules in Sema..
Aug 18 2020, 6:14 AM · Restricted Project

Aug 17 2020

adamcz accepted D86077: [clangd] Add a way for exporting memory usage metrics.
Aug 17 2020, 9:20 AM · Restricted Project