Page MenuHomePhabricator

kuhnel (Christian Kühnel)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2019, 6:08 AM (92 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

kuhnel abandoned D94293: [clangd] automatically index STL.

thx for the review and feedback!

Fri, Jan 22, 5:58 AM · Restricted Project

Fri, Jan 8

kuhnel added a comment to D94293: [clangd] automatically index STL.

Yes, I was looking for feedback on this one as I wasn't happy with my design.

Fri, Jan 8, 4:28 AM · Restricted Project
kuhnel added a comment to D94293: [clangd] automatically index STL.

@sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one.

Fri, Jan 8, 4:10 AM · Restricted Project
kuhnel updated the summary of D94293: [clangd] automatically index STL.
Fri, Jan 8, 4:07 AM · Restricted Project
kuhnel requested review of D94293: [clangd] automatically index STL.
Fri, Jan 8, 3:51 AM · Restricted Project

Tue, Jan 5

kuhnel added inline comments to D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.
Tue, Jan 5, 12:16 PM

Dec 16 2020

kuhnel accepted D93340: Start Docker-izing sanitizer-windows.

I'm not using the current deployment of the "windows10_vs2019" any more. So feel free to just modify that image and re-use the worker-config. That way you don't have to configure another deployment.

Dec 16 2020, 1:58 AM
kuhnel abandoned D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

Not pursuing work on the windows buildbot any more

Dec 16 2020, 1:52 AM
kuhnel committed rZORGe95a9d734943: mlir-nvidia: set -DMLIR_BINDINGS_PYTHON_ENABLED=ON (authored by kuhnel).
mlir-nvidia: set -DMLIR_BINDINGS_PYTHON_ENABLED=ON
Dec 16 2020, 1:45 AM
kuhnel committed rZORG5a45da1464bb: added .pylintrc (authored by kuhnel).
added .pylintrc
Dec 16 2020, 1:45 AM

Dec 7 2020

kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 7 2020, 6:17 AM
kuhnel updated the diff for D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

removed backwards compatibility, directly replacing all clean actions

Dec 7 2020, 6:16 AM
kuhnel added a comment to D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.

Alright, change landed. It will take a while until that is deployed.

Dec 7 2020, 5:29 AM
kuhnel committed rZORG4ff41f5740f6: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON (authored by kuhnel).
mlir-nvidia: added -DBUILD_SHARED_LIBS=ON
Dec 7 2020, 5:26 AM
kuhnel closed D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 7 2020, 5:26 AM
kuhnel updated the diff for D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.

enabled ccache

Dec 7 2020, 5:25 AM
kuhnel committed rZORGc83a04176d10: mlir-nvidia: updating container (authored by kuhnel).
mlir-nvidia: updating container
Dec 7 2020, 5:23 AM

Dec 3 2020

kuhnel updated the summary of D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 3 2020, 1:28 AM
kuhnel requested review of D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 3 2020, 1:27 AM

Dec 2 2020

kuhnel added a comment to D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

I can't really reproduce the issue outside of buildbot. Deleting the files locally always works.

Dec 2 2020, 12:51 AM

Dec 1 2020

kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:47 AM
kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:46 AM
kuhnel updated the diff for D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

added empty last line

Dec 1 2020, 1:40 AM
kuhnel requested review of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:39 AM

Nov 24 2020

kuhnel committed rZORG5ce18db8739a: clang-x86-ninja-win10: reducing scopoe of builds to get bot stable (authored by kuhnel).
clang-x86-ninja-win10: reducing scopoe of builds to get bot stable
Nov 24 2020, 6:58 AM

Nov 23 2020

kuhnel updated the summary of D91945: Enable retry on failed git operations.
Nov 23 2020, 1:03 AM
kuhnel updated the summary of D91945: Enable retry on failed git operations.
Nov 23 2020, 1:02 AM
kuhnel requested review of D91945: Enable retry on failed git operations.
Nov 23 2020, 12:58 AM

Nov 20 2020

kuhnel committed rZORG0564bc60fc7e: clangd-ubuntu-clang: moved to production server (authored by kuhnel).
clangd-ubuntu-clang: moved to production server
Nov 20 2020, 4:07 AM

Nov 18 2020

kuhnel committed rZORG1bc9b3daf451: langd-ubuntu-clang: fixed typo in RAM usage (authored by kuhnel).
langd-ubuntu-clang: fixed typo in RAM usage
Nov 18 2020, 2:22 AM
kuhnel committed rZORGe58caeb94830: clangd-ubuntu-clang: reduced RAM requirements (authored by kuhnel).
clangd-ubuntu-clang: reduced RAM requirements
Nov 18 2020, 2:12 AM

Nov 17 2020

kuhnel committed rZORG90207140bdb9: clangd-ubuntu-clang: increased resource limits to cover TSan builds (authored by kuhnel).
clangd-ubuntu-clang: increased resource limits to cover TSan builds
Nov 17 2020, 3:00 AM
kuhnel committed rZORG946f7e8d2fe9: added RAM info to worker status (authored by kuhnel).
added RAM info to worker status
Nov 17 2020, 3:00 AM

Nov 12 2020

kuhnel committed rZORGc730af4375de: clangd-ubuntu-tsan fixed typo in release type (authored by kuhnel).
clangd-ubuntu-tsan fixed typo in release type
Nov 12 2020, 12:56 AM
kuhnel committed rZORG21a3fc662d08: clangd-ubuntu-clang: removed special character from admin name (authored by kuhnel).
clangd-ubuntu-clang: removed special character from admin name
Nov 12 2020, 12:56 AM

Nov 11 2020

kuhnel committed rZORGb84d69ba3b5e: new worker and builder for clangd (authored by kuhnel).
new worker and builder for clangd
Nov 11 2020, 12:40 AM
kuhnel closed D91128: new worker and builder for clangd.
Nov 11 2020, 12:40 AM
kuhnel committed rZORG2abb7f51d766: buildbot-clangd-ubuntu-clang improvements (authored by kuhnel).
buildbot-clangd-ubuntu-clang improvements
Nov 11 2020, 12:37 AM

Nov 10 2020

kuhnel added a comment to D91128: new worker and builder for clangd.

@kbobyrev Yes, the main.tf was a dirty working copy. I fixed that now.

Nov 10 2020, 2:52 AM
kuhnel committed rZORGdb2515d183b8: initial deployment of clangd-ubuntu-clang (authored by kuhnel).
initial deployment of clangd-ubuntu-clang
Nov 10 2020, 2:52 AM
kuhnel committed rZORGb55eb3e73c8e: updated clangd-ubuntu-clang (authored by kuhnel).
updated clangd-ubuntu-clang
Nov 10 2020, 1:31 AM
kuhnel committed rZORGb8bcb750df35: added .vscode to .gitignore (authored by kuhnel).
added .vscode to .gitignore
Nov 10 2020, 1:31 AM
kuhnel updated the diff for D91128: new worker and builder for clangd.

removed stray edit to Dockerfile

Nov 10 2020, 1:29 AM
kuhnel added inline comments to D91128: new worker and builder for clangd.
Nov 10 2020, 1:24 AM
kuhnel updated the diff for D91128: new worker and builder for clangd.

addressed Sam's comments

Nov 10 2020, 1:21 AM
kuhnel updated the diff for D91128: new worker and builder for clangd.

fixed typos

Nov 10 2020, 12:16 AM

Nov 9 2020

kuhnel updated the summary of D91128: new worker and builder for clangd.
Nov 9 2020, 11:49 PM
kuhnel requested review of D91128: new worker and builder for clangd.
Nov 9 2020, 11:48 PM
kuhnel committed rZORG6f5ddbf9e704: buildbot-ubuntu-clang: added missing libraries for clangd (authored by kuhnel).
buildbot-ubuntu-clang: added missing libraries for clangd
Nov 9 2020, 11:31 PM
kuhnel committed rZORG435f2322cb34: created new generic Linux container (authored by kuhnel).
created new generic Linux container
Nov 9 2020, 7:55 AM
kuhnel committed rZORG08a066e1edef: moved all volumes below /vol (authored by kuhnel).
moved all volumes below /vol
Nov 9 2020, 7:55 AM

Nov 8 2020

kuhnel accepted D90966: Add pybind11 to the mlir-nvidia Docker image to be able to enable the MLIR Python bindings.
Nov 8 2020, 10:55 PM
kuhnel added a comment to D90966: Add pybind11 to the mlir-nvidia Docker image to be able to enable the MLIR Python bindings.

Looking at the documentation, it seems like we also need to modify the cmake command line parameters: https://mlir.llvm.org/docs/Bindings/Python/

Nov 8 2020, 10:46 PM

Oct 19 2020

kuhnel committed rZORGe8ba87e92b85: Step-by-step instructions for a new worker (authored by kuhnel).
Step-by-step instructions for a new worker
Oct 19 2020, 1:27 AM

Oct 7 2020

kuhnel added a comment to D89014: Give attributes C++ namespaces..

Teh build error looks like a connection issue to github, the script can't git fetch. We already have an issue to retry in such cases.

Oct 7 2020, 11:20 PM · Restricted Project
kuhnel committed rZORG6bff6ac2dd4e: clang-x86-ninja-win10: added LLVM_LIT_TOOLS_DIR (authored by kuhnel).
clang-x86-ninja-win10: added LLVM_LIT_TOOLS_DIR
Oct 7 2020, 4:01 AM

Sep 24 2020

kuhnel committed rZORGb1195d908598: clang-x86-ninja-win10 enabling LLD (authored by kuhnel).
clang-x86-ninja-win10 enabling LLD
Sep 24 2020, 3:33 AM

Sep 23 2020

kuhnel committed rZORGc3a4cac8157d: clang-x86-ninja-win10 fixed MSVC version output (authored by kuhnel).
clang-x86-ninja-win10 fixed MSVC version output
Sep 23 2020, 4:05 AM
kuhnel committed rZORG3d28ab15412b: clang-x86-ninja-win10 fixed slash replacement (authored by kuhnel).
clang-x86-ninja-win10 fixed slash replacement
Sep 23 2020, 4:05 AM

Sep 22 2020

kuhnel committed rZORGbc6f110d29f3: clang-x86-ninja-win10 - replacing backslashes (authored by kuhnel).
clang-x86-ninja-win10 - replacing backslashes
Sep 22 2020, 2:49 AM

Sep 21 2020

kuhnel committed rZORGd8fcebd8ab9f: clang-x86-ninja-win10 - delete folder if it exists (authored by kuhnel).
clang-x86-ninja-win10 - delete folder if it exists
Sep 21 2020, 5:29 AM
kuhnel accepted D88007: Added x86_64-fedora-clang builder and fedora-llvm-x86_64 slave.

looks good to me

Sep 21 2020, 2:33 AM

Sep 18 2020

kuhnel committed rZORGafcad9888264: fixed compiler argument (authored by kuhnel).
fixed compiler argument
Sep 18 2020, 8:03 AM
kuhnel committed rZORG0e2cebb40db7: ang-x86-ninja removed MSVC environment setup (authored by kuhnel).
ang-x86-ninja removed MSVC environment setup
Sep 18 2020, 5:51 AM

Sep 17 2020

kuhnel committed rZORG3b3349e94a30: clang-x86-ninja-win10: removed DIA flag, added LIBZ flag (authored by kuhnel).
clang-x86-ninja-win10: removed DIA flag, added LIBZ flag
Sep 17 2020, 6:56 AM
kuhnel added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

It also broke pre-merge testing for everyone: https://buildkite.com/llvm-project/llvm-master-build/builds/1071#7bfa9e1f-a2fe-47aa-8263-d2646ac0a0f5

Sep 17 2020, 12:35 AM · Restricted Project

Aug 11 2020

kuhnel added a comment to D79219: [CMake] Simplify CMake handling for zlib.

@phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well.

Aug 11 2020, 11:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 7 2020

kuhnel added a comment to D79219: [CMake] Simplify CMake handling for zlib.

Looking at the error, it seems like you have a 32-bit version of zlib installed and in your search path on a 64-bit version of Windows. I'm not quite sure how to handle that in CMake.

Aug 7 2020, 1:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhnel added a comment to D79219: [CMake] Simplify CMake handling for zlib.

How can I test this change on pre-merge bots? I haven't seen any builds posted on this change before.

Aug 7 2020, 1:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhnel removed a reviewer for D85190: remove STLExtras.h: kuhnel.
Aug 7 2020, 12:51 AM · Restricted Project
kuhnel requested changes to D79219: [CMake] Simplify CMake handling for zlib.
Aug 7 2020, 12:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhnel reopened D79219: [CMake] Simplify CMake handling for zlib.
Aug 7 2020, 12:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhnel added a reverting change for rG1adc494bce44: [CMake] Simplify CMake handling for zlib: rGf3cc4df51da4: Revert "[CMake] Simplify CMake handling for zlib".
Aug 7 2020, 12:38 AM
kuhnel committed rGf3cc4df51da4: Revert "[CMake] Simplify CMake handling for zlib" (authored by kuhnel).
Revert "[CMake] Simplify CMake handling for zlib"
Aug 7 2020, 12:38 AM
kuhnel added a reverting change for D79219: [CMake] Simplify CMake handling for zlib: rGf3cc4df51da4: Revert "[CMake] Simplify CMake handling for zlib".
Aug 7 2020, 12:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhnel added a comment to D79219: [CMake] Simplify CMake handling for zlib.

This patch broke the Windows compilation on buildbot and pre-merge testing. So I'll revert it to get pre-merge testing back online. Otherwise this will cause false-positives for pre-merge testing.

Aug 7 2020, 12:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 5 2020

kuhnel committed rZORG74e099cb9569: Added automatic cluster config and deployment (authored by kuhnel).
Added automatic cluster config and deployment
Aug 5 2020, 5:34 AM
kuhnel committed rZORG9b433279a0b5: updated Windows container version (authored by kuhnel).
updated Windows container version
Aug 5 2020, 5:33 AM
kuhnel committed rZORGfe0d2ecc195d: Use more efficient "e2" machine types (authored by bkramer).
Use more efficient "e2" machine types
Aug 5 2020, 5:33 AM
kuhnel closed D85211: Use more efficient "e2" machine types.
Aug 5 2020, 5:33 AM

Aug 4 2020

kuhnel added a comment to D85211: Use more efficient "e2" machine types.

Nice. I'll give that a try tomorrow!

Aug 4 2020, 8:13 AM

Aug 3 2020

kuhnel committed rZORG876b25ef8b5d: fixed shortended paths (authored by kuhnel).
fixed shortended paths
Aug 3 2020, 8:19 AM
kuhnel committed rZORGb4acbb3a3217: upgraded windows10-vs2019 to 32 cores (authored by kuhnel).
upgraded windows10-vs2019 to 32 cores
Aug 3 2020, 12:39 AM
kuhnel committed rZORG223336397013: fixed script for Windows (authored by kuhnel).
fixed script for Windows
Aug 3 2020, 12:39 AM
kuhnel committed rZORGd86d26c34ccd: win32 builder - Shorted path length (authored by kuhnel).
win32 builder - Shorted path length
Aug 3 2020, 12:39 AM

Jul 31 2020

kuhnel committed rZORGf5229f92248f: moved buildbot working dir to volume (authored by kuhnel).
moved buildbot working dir to volume
Jul 31 2020, 1:38 AM
kuhnel committed rZORG7fbf1394aaff: registered 32bit msdia140.dll as well (authored by kuhnel).
registered 32bit msdia140.dll as well
Jul 31 2020, 1:38 AM
kuhnel committed rZORG94769cdc3448: updated container version, fixed volume mounts (authored by kuhnel).
updated container version, fixed volume mounts
Jul 31 2020, 1:23 AM

Jul 30 2020

kuhnel committed rZORG48a02487ae94: mlir-nvidia removing outdated DLLVM_ENABLE_CXX1Y (authored by kuhnel).
mlir-nvidia removing outdated DLLVM_ENABLE_CXX1Y
Jul 30 2020, 3:31 AM

Jul 29 2020

kuhnel closed D82890: initial windows deployment.
Jul 29 2020, 7:41 AM
kuhnel committed rZORGf7022d564ac8: Initial deployment of windows buildbot (authored by kuhnel).
Initial deployment of windows buildbot
Jul 29 2020, 7:41 AM

Jul 27 2020

kuhnel committed rZORGefa544b5b066: registered msdia140.dll (authored by kuhnel).
registered msdia140.dll
Jul 27 2020, 8:23 AM
kuhnel accepted D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.
Jul 27 2020, 7:24 AM

Jul 24 2020

kuhnel added a comment to D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

Well, then let's go with your proposal of merging the docker directory and separate the terraform directory.
At least for now. If we later figure out a way to work in the same terraform config, we can always invest some time to merge that later on.

Jul 24 2020, 7:54 AM
kuhnel added a comment to D84258: [buildbot] Added config files for CUDA build bots.
In D84258#2167464, @tra wrote:
Jul 24 2020, 7:52 AM
kuhnel committed rZORG960a6f0ff881: mlir-nvidia - parallel deployments to prod and staging (authored by kuhnel).
mlir-nvidia - parallel deployments to prod and staging
Jul 24 2020, 4:50 AM
kuhnel committed rZORG10bf6de9eea3: Set up Vulkan compute in mlir-nvidia docker (authored by antiagainst).
Set up Vulkan compute in mlir-nvidia docker
Jul 24 2020, 4:50 AM
kuhnel updated the diff for D82890: initial windows deployment.

fixed documentation on environment variables

Jul 24 2020, 1:30 AM
kuhnel updated the diff for D82890: initial windows deployment.

increased resourced, updated container version

Jul 24 2020, 1:27 AM
kuhnel committed rZORGbaf4a03abba2: limited sccache local cache size (authored by kuhnel).
limited sccache local cache size
Jul 24 2020, 1:09 AM