Page MenuHomePhabricator

kuhnel (Christian Kühnel)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2019, 6:08 AM (167 w, 6 d)
Roles
Administrator

Recent Activity

Mar 29 2022

Herald added a project to D109810: [doc] documentation of code review tools: Restricted Project.

ping @reames

Mar 29 2022, 8:42 AM · Restricted Project, Restricted Project

Mar 2 2022

kuhnel renamed testuser-please-delete-me from testuser to testuser-please-delete-me.
Mar 2 2022, 4:02 AM

Feb 21 2022

kuhnel updated subscribers of D108513: [docs] Update Getting Started with Visual Studio guide.

We're actually using chocolatey for all tools that it offers in pre-merge and that works very well, much better than downloading installers and executing them...

Which package are you using to get gnu tools?

Feb 21 2022, 1:34 AM · Restricted Project

Feb 17 2022

kuhnel added a comment to D108513: [docs] Update Getting Started with Visual Studio guide.

We're actually using chocolatey for all tools that it offers in pre-merge and that works very well, much better than downloading installers and executing them...

Feb 17 2022, 12:35 AM · Restricted Project

Feb 16 2022

kuhnel empowered aeubanks as an administrator.
Feb 16 2022, 4:37 AM

Feb 3 2022

kuhnel committed rG2f8da95e070e: [clangd][nfc] cleanup of remaining clang-tidy findings (authored by kuhnel).
[clangd][nfc] cleanup of remaining clang-tidy findings
Feb 3 2022, 4:07 AM
kuhnel closed D118698: [clangd][nfc] cleanup of remaining clang-tidy findings.
Feb 3 2022, 4:07 AM · Restricted Project

Feb 1 2022

kuhnel requested review of D118698: [clangd][nfc] cleanup of remaining clang-tidy findings.
Feb 1 2022, 5:47 AM · Restricted Project
kuhnel committed rG8edfc2f814fe: [clangd] Cleanup of readability-identifier-naming (authored by kuhnel).
[clangd] Cleanup of readability-identifier-naming
Feb 1 2022, 5:32 AM
kuhnel closed D115634: [clangd] Cleanup of readability-identifier-naming.
Feb 1 2022, 5:32 AM · Restricted Project
kuhnel added a comment to D115634: [clangd] Cleanup of readability-identifier-naming.

Thx @sammccall for your patience with this cleanup.

Feb 1 2022, 5:31 AM · Restricted Project
kuhnel updated the diff for D115634: [clangd] Cleanup of readability-identifier-naming.

fixed A_CC in BackgroundIndexTests.cpp

Feb 1 2022, 4:26 AM · Restricted Project
kuhnel updated the diff for D115634: [clangd] Cleanup of readability-identifier-naming.

re-created patch, then updated matcher macros

Feb 1 2022, 4:20 AM · Restricted Project
kuhnel updated the summary of D115634: [clangd] Cleanup of readability-identifier-naming.
Feb 1 2022, 4:18 AM · Restricted Project

Jan 27 2022

kuhnel updated the diff for D115634: [clangd] Cleanup of readability-identifier-naming.

addressed review comments

Jan 27 2022, 1:03 AM · Restricted Project
kuhnel added inline comments to D115634: [clangd] Cleanup of readability-identifier-naming.
Jan 27 2022, 1:03 AM · Restricted Project
kuhnel updated the summary of D115634: [clangd] Cleanup of readability-identifier-naming.
Jan 27 2022, 1:02 AM · Restricted Project
kuhnel updated the diff for D115634: [clangd] Cleanup of readability-identifier-naming.

Re-created the patch as there were too many changes in the repo.

Jan 27 2022, 12:55 AM · Restricted Project

Jan 25 2022

kuhnel committed rGc0e3c893aa09: [NFC][clangd] cleaning up llvm-qualified-auto (authored by kuhnel).
[NFC][clangd] cleaning up llvm-qualified-auto
Jan 25 2022, 5:27 AM
kuhnel closed D113898: [NFC][clangd] cleaning up llvm-qualified-auto.
Jan 25 2022, 5:26 AM · Restricted Project

Jan 24 2022

kuhnel added inline comments to D109810: [doc] documentation of code review tools.
Jan 24 2022, 5:44 AM · Restricted Project, Restricted Project
kuhnel updated the diff for D109810: [doc] documentation of code review tools.

Thx @reames and @xgupta for your review! I hopefully addressed all of them.

Jan 24 2022, 5:43 AM · Restricted Project, Restricted Project

Jan 20 2022

kuhnel added a reviewer for D117773: [clang-tidy] added JSON output to clang-tidy-diff.py: goncharov.
Jan 20 2022, 4:55 AM · Restricted Project
kuhnel added reviewers for D117773: [clang-tidy] added JSON output to clang-tidy-diff.py: kadircet, hokein.
Jan 20 2022, 4:32 AM · Restricted Project
kuhnel requested review of D117773: [clang-tidy] added JSON output to clang-tidy-diff.py.
Jan 20 2022, 4:31 AM · Restricted Project

Jan 18 2022

kuhnel added a comment to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

TODO: check for remaining const then submit.

Jan 18 2022, 4:42 AM · Restricted Project
kuhnel added a comment to D115634: [clangd] Cleanup of readability-identifier-naming.

Discussion in team sync, work for myself:

  • most changes are in unittests --> propose something for the matchers
  • cleaning up constants makes sense
  • clean up this patch, then do another round of reviews
Jan 18 2022, 4:39 AM · Restricted Project

Dec 13 2021

kuhnel retitled D115634: [clangd] Cleanup of readability-identifier-naming from Cleanup of readability-identifier-naming to [clangd] Cleanup of readability-identifier-naming.
Dec 13 2021, 7:38 AM · Restricted Project
kuhnel added inline comments to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.
Dec 13 2021, 7:37 AM · Restricted Project
kuhnel updated the diff for D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

more reverts of consts

Dec 13 2021, 7:36 AM · Restricted Project
kuhnel updated the diff for D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

fixed more const ClangdTests.cpp

Dec 13 2021, 7:25 AM · Restricted Project
kuhnel updated the diff for D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

reverted the const as advised in Sam's comment

Dec 13 2021, 7:22 AM · Restricted Project
kuhnel added a comment to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

Looking at the documentation, this looks like a bug in the clang-tidy check:
https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

The rule llvm-qualified-auto should not add a const qualifier.

I don't see how that is a bug: the docs specially cover the const auto * conversion in the first example by drawing the line between observe() (non-mutating function) and change() (possibly mutating function).

Dec 13 2021, 7:22 AM · Restricted Project
kuhnel updated the summary of D115634: [clangd] Cleanup of readability-identifier-naming.
Dec 13 2021, 7:06 AM · Restricted Project
kuhnel requested review of D115634: [clangd] Cleanup of readability-identifier-naming.
Dec 13 2021, 6:49 AM · Restricted Project

Dec 2 2021

kuhnel added a comment to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

Looking at the documentation, this looks like a bug in the clang-tidy check:
https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

Dec 2 2021, 8:19 AM · Restricted Project
kuhnel committed rG5bd643d31d11: [clangd] cleanup of header guard names (authored by kuhnel).
[clangd] cleanup of header guard names
Dec 2 2021, 7:59 AM
kuhnel closed D113896: [clangd] cleanup of header guard names.
Dec 2 2021, 7:59 AM · Restricted Project
kuhnel added a comment to D113896: [clangd] cleanup of header guard names.

@kadircet looks like clang-tidy does not detect missing comments in #endif. It does complain about missing comments for namespaces. E.g. in Serialization.h the #endif comment is missing, but without a finding.

Dec 2 2021, 6:15 AM · Restricted Project
kuhnel updated the diff for D113896: [clangd] cleanup of header guard names.

addressed review comments

Dec 2 2021, 6:15 AM · Restricted Project

Nov 18 2021

kuhnel added a comment to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

When trying to revert some of the changes, I just noticed there are a couple of if (const auto* ... in CodeComplete.cpp and AST.cpp (and maybe other files as well). So some folks seem to be using this right now. If we want to be consistent, we would have to remove these const as well.

Nov 18 2021, 8:15 AM · Restricted Project
kuhnel committed rG7aa2ce0fab3c: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull (authored by kuhnel).
[NFC][clangd] fix clang-tidy finding on isa_and_nonnull
Nov 18 2021, 1:26 AM
kuhnel closed D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull.
Nov 18 2021, 1:25 AM · Restricted Project

Nov 17 2021

kuhnel abandoned D113902: [NFC][clangd] exclude test data from clang-tidy.

thx for the explanation, makes sense
--> abandoning this change

Nov 17 2021, 6:39 AM · Restricted Project
kuhnel committed rGec4a2c956591: [NFC][clangd] cleanup llvm-else-after-return findings (authored by kuhnel).
[NFC][clangd] cleanup llvm-else-after-return findings
Nov 17 2021, 6:37 AM
kuhnel closed D113892: [NFC][clangd] cleanup llvm-else-after-return findings.
Nov 17 2021, 6:37 AM · Restricted Project
kuhnel added inline comments to D113896: [clangd] cleanup of header guard names.
Nov 17 2021, 6:36 AM · Restricted Project
kuhnel retitled D113896: [clangd] cleanup of header guard names from [NFC][clangd] cleanup of header guard names to [clangd] cleanup of header guard names.
Nov 17 2021, 6:36 AM · Restricted Project
kuhnel updated the diff for D113896: [clangd] cleanup of header guard names.

addresed Sam's comments

Nov 17 2021, 6:34 AM · Restricted Project
kuhnel added inline comments to D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull.
Nov 17 2021, 5:58 AM · Restricted Project
kuhnel updated the diff for D113892: [NFC][clangd] cleanup llvm-else-after-return findings.

addressed Sam's comments

Nov 17 2021, 5:44 AM · Restricted Project
kuhnel added a comment to D113902: [NFC][clangd] exclude test data from clang-tidy.

Hmm, clang-tidy should only be running on entries in compile_commands.json. are these files listed somehow?

Nov 17 2021, 4:51 AM · Restricted Project
kuhnel added a comment to D113898: [NFC][clangd] cleaning up llvm-qualified-auto.

Based on Sam's comments and our offline discussion, I would propose:

  1. abandon this patch
  2. start a discussion on the mailing list to disable this check for all of the llvm monorepo.
Nov 17 2021, 4:41 AM · Restricted Project

Nov 16 2021

kuhnel added a comment to D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h.

I just checked with my local clangd and it does not crash on this file...

Nov 16 2021, 7:28 AM · Restricted Project
kuhnel committed rG75a078455fc7: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h (authored by kuhnel).
[NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h
Nov 16 2021, 7:26 AM
kuhnel closed D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h.
Nov 16 2021, 7:26 AM · Restricted Project
kuhnel committed rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding (authored by kuhnel).
[NFC][clangd] fix llvm-namespace-comment finding
Nov 16 2021, 7:11 AM
kuhnel closed D113895: [NFC][clangd] fix llvm-namespace-comment finding.
Nov 16 2021, 7:11 AM · Restricted Project
kuhnel committed rGd2da1a2f400a: [NFC][clangd] cleaning up unused "using" (authored by kuhnel).
[NFC][clangd] cleaning up unused "using"
Nov 16 2021, 5:10 AM
kuhnel closed D113891: [NFC][clangd] cleaning up unused "using".
Nov 16 2021, 5:10 AM · Restricted Project

Nov 15 2021

kuhnel published D113892: [NFC][clangd] cleanup llvm-else-after-return findings for review.
Nov 15 2021, 8:08 AM · Restricted Project
kuhnel published D113895: [NFC][clangd] fix llvm-namespace-comment finding for review.
Nov 15 2021, 8:07 AM · Restricted Project
kuhnel published D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull for review.
Nov 15 2021, 8:07 AM · Restricted Project
kuhnel published D113902: [NFC][clangd] exclude test data from clang-tidy for review.
Nov 15 2021, 7:59 AM · Restricted Project
kuhnel published D113898: [NFC][clangd] cleaning up llvm-qualified-auto for review.
Nov 15 2021, 7:21 AM · Restricted Project
kuhnel published D113896: [clangd] cleanup of header guard names for review.
Nov 15 2021, 7:16 AM · Restricted Project
kuhnel published D113891: [NFC][clangd] cleaning up unused "using" for review.
Nov 15 2021, 6:55 AM · Restricted Project
kuhnel added a reviewer for D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h: hokein.
Nov 15 2021, 6:39 AM · Restricted Project
kuhnel published D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h for review.
Nov 15 2021, 6:39 AM · Restricted Project

Oct 27 2021

kuhnel accepted D95284: utils/release: Add script for building release documentation.

No more comments from me. However I'm not an expert on bash scripting...

Oct 27 2021, 6:33 AM · Restricted Project

Oct 19 2021

kuhnel committed rGdcc91dd2a798: first draft of a written policy around git repos (authored by kuhnel).
first draft of a written policy around git repos
Oct 19 2021, 1:06 AM
kuhnel closed D111723: first draft of a written policy around git repos.
Oct 19 2021, 1:06 AM · Restricted Project

Oct 15 2021

kuhnel added a comment to D111723: first draft of a written policy around git repos.

Thx everyone for the reviews, I updated the proposal accordingly.

Oct 15 2021, 4:49 AM · Restricted Project
kuhnel updated the diff for D111723: first draft of a written policy around git repos.

addressed review feedback

Oct 15 2021, 4:49 AM · Restricted Project

Oct 13 2021

kuhnel added reviewers for D111723: first draft of a written policy around git repos: asl, sqlbyme, mehdi_amini, tstellar.
Oct 13 2021, 8:23 AM · Restricted Project
kuhnel requested review of D111723: first draft of a written policy around git repos.
Oct 13 2021, 8:15 AM · Restricted Project
kuhnel updated the diff for D109810: [doc] documentation of code review tools.

2nd iteration of the patch

Oct 13 2021, 5:12 AM · Restricted Project, Restricted Project

Oct 12 2021

kuhnel added a comment to D109810: [doc] documentation of code review tools.

ping @reames

Oct 12 2021, 8:01 AM · Restricted Project, Restricted Project

Oct 6 2021

kuhnel committed rGbafdf2b1efb3: [docs] Fix typo and minor text changes in MyFirstTypoFix (authored by kinu).
[docs] Fix typo and minor text changes in MyFirstTypoFix
Oct 6 2021, 1:32 AM
kuhnel closed D111211: [docs] Fix typo and minor text changes in MyFirstTypoFix.
Oct 6 2021, 1:32 AM · Restricted Project
kuhnel accepted D111211: [docs] Fix typo and minor text changes in MyFirstTypoFix.

@xgupta @xzq0528 @gribozavr @meikeb
FYI, as you were working on this tutorial as well

Oct 6 2021, 1:13 AM · Restricted Project

Oct 1 2021

kuhnel added inline comments to D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..
Oct 1 2021, 3:53 AM · Restricted Project

Sep 22 2021

kuhnel added a comment to D105014: added some example code for llvm::Expected<T>.

Out of interest, did you see https://llvm.org/docs/ProgrammersManual.html#error-handling ? If not (and if you find it helpful) then maybe we need to make that document more discoverable. If that document is not helpful then we should improve it.

Sep 22 2021, 6:56 AM · Restricted Project, Restricted Project

Sep 15 2021

kuhnel retitled D109810: [doc] documentation of code review tools from documentation of code review tools to [doc] documentation of code review tools.
Sep 15 2021, 12:49 AM · Restricted Project, Restricted Project
kuhnel requested review of D109810: [doc] documentation of code review tools.
Sep 15 2021, 12:45 AM · Restricted Project, Restricted Project

Aug 31 2021

kuhnel added a comment to D108700: do not merge, just a demo.

Thx for pointing that out! I was not aware of such a feature.

Aug 31 2021, 7:57 AM · Restricted Project

Aug 30 2021

kuhnel added a comment to D108267: [docs] Add a new tutorial that talk about how to make a change to llvm.

Sorry, somehow the comments did not end up in my email inbox.
I just landed the patch.

Aug 30 2021, 12:05 AM · Restricted Project
kuhnel committed rG3a6b722db856: [docs] Add a new tutorial that talk about how to make a change to llvm (authored by xgupta).
[docs] Add a new tutorial that talk about how to make a change to llvm
Aug 30 2021, 12:04 AM
kuhnel closed D108267: [docs] Add a new tutorial that talk about how to make a change to llvm.
Aug 30 2021, 12:03 AM · Restricted Project

Aug 29 2021

kuhnel updated the summary of D108267: [docs] Add a new tutorial that talk about how to make a change to llvm.
Aug 29 2021, 11:57 PM · Restricted Project

Aug 25 2021

kuhnel abandoned D108700: do not merge, just a demo.

was just a demo

Aug 25 2021, 6:59 AM · Restricted Project
kuhnel added a reviewer for D108700: do not merge, just a demo: agerbes.
Aug 25 2021, 6:45 AM · Restricted Project
kuhnel requested review of D108700: do not merge, just a demo.
Aug 25 2021, 6:45 AM · Restricted Project
kuhnel accepted D108267: [docs] Add a new tutorial that talk about how to make a change to llvm.
Aug 25 2021, 2:21 AM · Restricted Project

Aug 23 2021

kuhnel accepted D108513: [docs] Update Getting Started with Visual Studio guide.

Thx for cleaning up the Windows instructions!

Aug 23 2021, 1:10 AM · Restricted Project

Aug 20 2021

kuhnel updated the diff for D105177: [clangd] Implemented indexing of standard library.

fixing windows build

Aug 20 2021, 7:07 AM · Restricted Project
kuhnel updated the diff for D108119: Wiring of standard library indexing into clangd..

addressed some review comments

Aug 20 2021, 2:04 AM · Restricted Project
kuhnel updated the diff for D105177: [clangd] Implemented indexing of standard library.

addressed code review comments

Aug 20 2021, 2:01 AM · Restricted Project
kuhnel added inline comments to D105177: [clangd] Implemented indexing of standard library.
Aug 20 2021, 1:23 AM · Restricted Project

Aug 19 2021

kuhnel added inline comments to D105177: [clangd] Implemented indexing of standard library.
Aug 19 2021, 9:16 AM · Restricted Project