Page MenuHomePhabricator

kuhnel (Christian Kühnel)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2019, 6:08 AM (113 w, 1 d)
Roles
Administrator

Recent Activity

Fri, Jun 11

kuhnel added a comment to D103811: [docs] Set Phabricator as the tool for pre-commit code reviews.

+1 on David and Mehdi

Fri, Jun 11, 12:39 AM · Restricted Project

Tue, Jun 8

kuhnel committed rZORGb83568a0e50f: Enable retry on failed git operations (authored by kuhnel).
Enable retry on failed git operations
Tue, Jun 8, 2:50 AM
kuhnel closed D91945: Enable retry on failed git operations.
Tue, Jun 8, 2:50 AM
kuhnel updated the diff for D91945: Enable retry on failed git operations.

added clobberOnFailure=True to the 2nd call as well

Tue, Jun 8, 2:49 AM
kuhnel updated the diff for D91945: Enable retry on failed git operations.

added clobberOnFailure=True

Tue, Jun 8, 2:47 AM
kuhnel added a comment to D91945: Enable retry on failed git operations.

no I haven't really investigated this. My gut feeling says it's just a connection issue with GitHub. Performing a clone might recover more cases at the expense of network traffic and build time. I would prioritize automatic build recovery higher, so I like your proposal.

Tue, Jun 8, 2:45 AM

Mon, Jun 7

kuhnel accepted D103811: [docs] Set Phabricator as the tool for pre-commit code reviews.
Mon, Jun 7, 8:47 AM · Restricted Project
kuhnel committed rZORGe80b3b9a5595: [buildbot-clangd-ubuntu-clang] deployed new docker image (authored by kuhnel).
[buildbot-clangd-ubuntu-clang] deployed new docker image
Mon, Jun 7, 4:23 AM

May 10 2021

kuhnel added a comment to rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks..

2x sorry, that is actually still an open issue.

May 10 2021, 8:31 AM
kuhnel added a comment to rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks..

Sorry, that seems to have been fixed already. I was looking at an old build.

May 10 2021, 8:29 AM
kuhnel updated subscribers of rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks..
May 10 2021, 8:25 AM
kuhnel added a comment to rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks..

I think this commit or the next one (7f9a89f9a2cc55dbfc315aa11416fe3609918199) broke the compilation of the examples. Can you please take a look?

May 10 2021, 8:25 AM
kuhnel accepted D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..
May 10 2021, 6:54 AM · Restricted Project

May 4 2021

kuhnel added a comment to rG4dc6763289a0: [doc] added documentation for pre-merge testing.

Added @goncharov as he's working on pre-merge testing.

May 4 2021, 4:30 AM
kuhnel updated subscribers of rG4dc6763289a0: [doc] added documentation for pre-merge testing.
May 4 2021, 4:16 AM

May 3 2021

kuhnel added a comment to rG7f9717b922d4: added section on CI system.

Thx, fixed in https://reviews.llvm.org/rG91607dce615a7837cd094247aa4620cad95f741c

May 3 2021, 2:01 AM
kuhnel committed rG91607dce615a: [doc] typo fixes (authored by kuhnel).
[doc] typo fixes
May 3 2021, 2:00 AM

Apr 28 2021

kuhnel added a comment to D101432: [DO NOT MERGE!] dummy change to test herald rules.

Nice! Quoting and markup from emails seems to be working as expected.

Apr 28 2021, 3:09 AM · Restricted Project
kuhnel added a comment to D101432: [DO NOT MERGE!] dummy change to test herald rules.

Trying some markup:

Apr 28 2021, 3:08 AM · Restricted Project
kuhnel added a comment to D101432: [DO NOT MERGE!] dummy change to test herald rules.

kuhnel added subscribers: myler, bhuvanendrakumarn, dougpuob.

kuhnel added a comment.

Apr 28 2021, 2:07 AM · Restricted Project
kuhnel updated subscribers of D101432: [DO NOT MERGE!] dummy change to test herald rules.

reply via email

Apr 28 2021, 2:04 AM · Restricted Project
kuhnel added a comment to D101432: [DO NOT MERGE!] dummy change to test herald rules.

2nd test from the UI

Apr 28 2021, 2:03 AM · Restricted Project
kuhnel added a comment to D101432: [DO NOT MERGE!] dummy change to test herald rules.

test comment from the UI

Apr 28 2021, 2:01 AM · Restricted Project
kuhnel retitled D101432: [DO NOT MERGE!] dummy change to test herald rules from dummy change to test herald rules to [DO NOT MERGE!] dummy change to test herald rules.
Apr 28 2021, 1:58 AM · Restricted Project
kuhnel requested review of D101432: [DO NOT MERGE!] dummy change to test herald rules.
Apr 28 2021, 1:57 AM · Restricted Project

Apr 27 2021

kuhnel added inline comments to D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..
Apr 27 2021, 9:16 AM · Restricted Project
kuhnel added inline comments to D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..
Apr 27 2021, 9:07 AM · Restricted Project
kuhnel committed rG4dc6763289a0: [doc] added documentation for pre-merge testing (authored by kuhnel).
[doc] added documentation for pre-merge testing
Apr 27 2021, 7:57 AM
kuhnel closed D100936: [doc] added documentation for pre-merge testing.
Apr 27 2021, 7:57 AM · Restricted Project

Apr 23 2021

kuhnel added inline comments to D95284: utils/release: Add script for building release documentation.
Apr 23 2021, 2:46 AM · Restricted Project

Apr 21 2021

kuhnel requested review of D100943: [doc] added links to discord and discourse.
Apr 21 2021, 4:36 AM · Restricted Project
kuhnel updated the diff for D100936: [doc] added documentation for pre-merge testing.

resolved Mikhails comment

Apr 21 2021, 3:50 AM · Restricted Project
kuhnel updated the summary of D100936: [doc] added documentation for pre-merge testing.
Apr 21 2021, 2:40 AM · Restricted Project
kuhnel requested review of D100936: [doc] added documentation for pre-merge testing.
Apr 21 2021, 2:39 AM · Restricted Project
kuhnel added a comment to D91945: Enable retry on failed git operations.

@gkistanova ping

Apr 21 2021, 2:18 AM
kuhnel committed rGcf61cf07248a: [NFC] fixed link in documentation (authored by kuhnel).
[NFC] fixed link in documentation
Apr 21 2021, 1:17 AM
kuhnel committed rG7f9717b922d4: added section on CI system (authored by kuhnel).
added section on CI system
Apr 21 2021, 1:00 AM
kuhnel closed D97389: added section on CI system.
Apr 21 2021, 1:00 AM · Restricted Project
kuhnel updated the diff for D97389: added section on CI system.

addressed azharudd's comments

Apr 21 2021, 12:37 AM · Restricted Project
kuhnel added inline comments to D97389: added section on CI system.
Apr 21 2021, 12:36 AM · Restricted Project

Apr 19 2021

kuhnel accepted D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..
Apr 19 2021, 4:43 AM · Restricted Project
kuhnel added a comment to D100714: [docs] Add a new tutorial that talk about how to make a change to llvm..

LGTM, thx for converting this!
I guess we should also link to this tutorial from the getting involved page, what do you think?

Apr 19 2021, 4:43 AM · Restricted Project
kuhnel added a reviewer for D100714: [docs] Add a new tutorial that talk about how to make a change to llvm.: meikeb.
Apr 19 2021, 4:40 AM · Restricted Project

Apr 9 2021

kuhnel updated the diff for D97389: added section on CI system.

added link to revert policy

Apr 9 2021, 1:38 AM · Restricted Project
kuhnel added a comment to D97389: added section on CI system.

@tschuett, thx I missed that update, just added a link to that...

Apr 9 2021, 1:37 AM · Restricted Project
kuhnel added inline comments to D97389: added section on CI system.
Apr 9 2021, 1:10 AM · Restricted Project
kuhnel updated the diff for D97389: added section on CI system.

addressed Galinas comments

Apr 9 2021, 1:10 AM · Restricted Project

Apr 3 2021

kuhnel added a comment to D97389: added section on CI system.

@gkistanova are you OK with this documentation change?

Apr 3 2021, 3:15 AM · Restricted Project

Mar 19 2021

kuhnel added a reviewer for D97389: added section on CI system: gkistanova.
Mar 19 2021, 8:43 AM · Restricted Project
kuhnel added a comment to D97389: added section on CI system.

@reames I added a screenshot as you wanted. Please let me know if that addresses your usecase.

Mar 19 2021, 8:43 AM · Restricted Project
kuhnel updated the diff for D97389: added section on CI system.

added screenshot

Mar 19 2021, 8:42 AM · Restricted Project
kuhnel committed rG4532ab76c9e8: propose Chocolately as package manager (authored by kuhnel).
propose Chocolately as package manager
Mar 19 2021, 8:18 AM
kuhnel closed D97387: propose Chocolately as package manager for Windows.
Mar 19 2021, 8:18 AM · Restricted Project
kuhnel added a comment to D97387: propose Chocolately as package manager for Windows.

fixed and submitted

Mar 19 2021, 8:15 AM · Restricted Project
kuhnel updated the diff for D97387: propose Chocolately as package manager for Windows.

fixed typos

Mar 19 2021, 8:14 AM · Restricted Project
kuhnel added a comment to D91945: Enable retry on failed git operations.

@gkistanova ping

Mar 19 2021, 8:02 AM

Mar 8 2021

kuhnel added inline comments to D97387: propose Chocolately as package manager for Windows.
Mar 8 2021, 7:16 AM · Restricted Project

Mar 2 2021

kuhnel added a comment to D97389: added section on CI system.

ping @reames

Mar 2 2021, 1:56 AM · Restricted Project

Feb 24 2021

kuhnel added a reviewer for D97387: propose Chocolately as package manager for Windows: rnk.
Feb 24 2021, 8:04 AM · Restricted Project
kuhnel added a reviewer for D97389: added section on CI system: reames.
Feb 24 2021, 7:48 AM · Restricted Project
kuhnel updated the diff for D97389: added section on CI system.

added missing information on worker tab

Feb 24 2021, 7:48 AM · Restricted Project
kuhnel requested review of D97389: added section on CI system.
Feb 24 2021, 7:34 AM · Restricted Project
kuhnel retitled D97387: propose Chocolately as package manager for Windows from propose Chocolately as package manager to propose Chocolately as package manager for Windows.
Feb 24 2021, 7:30 AM · Restricted Project
kuhnel requested review of D97387: propose Chocolately as package manager for Windows.
Feb 24 2021, 7:29 AM · Restricted Project

Feb 23 2021

kuhnel committed rZORG41846a7dad69: [clangd-ubuntu-clang] improved startup error logging (authored by kuhnel).
[clangd-ubuntu-clang] improved startup error logging
Feb 23 2021, 2:40 AM
kuhnel committed rZORGc3af800b7ac0: fixed typo in comment (authored by kuhnel).
fixed typo in comment
Feb 23 2021, 2:04 AM

Feb 22 2021

kuhnel committed rZORG03210ece0216: deployed new mlir-nvidia image (authored by kuhnel).
deployed new mlir-nvidia image
Feb 22 2021, 10:13 AM
kuhnel committed rZORGb7a5b46b65e7: [clangd-ubuntu-clang] increased RAM (authored by kuhnel).
[clangd-ubuntu-clang] increased RAM
Feb 22 2021, 10:13 AM

Jan 22 2021

kuhnel abandoned D94293: [clangd] automatically index STL.

thx for the review and feedback!

Jan 22 2021, 5:58 AM · Restricted Project

Jan 8 2021

kuhnel added a comment to D94293: [clangd] automatically index STL.

Yes, I was looking for feedback on this one as I wasn't happy with my design.

Jan 8 2021, 4:28 AM · Restricted Project
kuhnel added a comment to D94293: [clangd] automatically index STL.

@sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one.

Jan 8 2021, 4:10 AM · Restricted Project
kuhnel updated the summary of D94293: [clangd] automatically index STL.
Jan 8 2021, 4:07 AM · Restricted Project
kuhnel requested review of D94293: [clangd] automatically index STL.
Jan 8 2021, 3:51 AM · Restricted Project

Jan 5 2021

kuhnel added inline comments to D93960: Install Numpy in the MLIR Docker image, this is required for the python bindings.
Jan 5 2021, 12:16 PM

Dec 16 2020

kuhnel accepted D93340: Start Docker-izing sanitizer-windows.

I'm not using the current deployment of the "windows10_vs2019" any more. So feel free to just modify that image and re-use the worker-config. That way you don't have to configure another deployment.

Dec 16 2020, 1:58 AM
kuhnel abandoned D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

Not pursuing work on the windows buildbot any more

Dec 16 2020, 1:52 AM
kuhnel committed rZORGe95a9d734943: mlir-nvidia: set -DMLIR_BINDINGS_PYTHON_ENABLED=ON (authored by kuhnel).
mlir-nvidia: set -DMLIR_BINDINGS_PYTHON_ENABLED=ON
Dec 16 2020, 1:45 AM
kuhnel committed rZORG5a45da1464bb: added .pylintrc (authored by kuhnel).
added .pylintrc
Dec 16 2020, 1:45 AM

Dec 7 2020

kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 7 2020, 6:17 AM
kuhnel updated the diff for D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

removed backwards compatibility, directly replacing all clean actions

Dec 7 2020, 6:16 AM
kuhnel added a comment to D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.

Alright, change landed. It will take a while until that is deployed.

Dec 7 2020, 5:29 AM
kuhnel committed rZORG4ff41f5740f6: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON (authored by kuhnel).
mlir-nvidia: added -DBUILD_SHARED_LIBS=ON
Dec 7 2020, 5:26 AM
kuhnel closed D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 7 2020, 5:26 AM
kuhnel updated the diff for D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.

enabled ccache

Dec 7 2020, 5:25 AM
kuhnel committed rZORGc83a04176d10: mlir-nvidia: updating container (authored by kuhnel).
mlir-nvidia: updating container
Dec 7 2020, 5:23 AM

Dec 3 2020

kuhnel updated the summary of D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 3 2020, 1:28 AM
kuhnel requested review of D92555: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
Dec 3 2020, 1:27 AM

Dec 2 2020

kuhnel added a comment to D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

I can't really reproduce the issue outside of buildbot. Deleting the files locally always works.

Dec 2 2020, 12:51 AM

Dec 1 2020

kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:47 AM
kuhnel updated the summary of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:46 AM
kuhnel updated the diff for D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.

added empty last line

Dec 1 2020, 1:40 AM
kuhnel requested review of D92372: replacing `rm -rf` with RemoveDirectory step in ClangBuilders.
Dec 1 2020, 1:39 AM

Nov 24 2020

kuhnel committed rZORG5ce18db8739a: clang-x86-ninja-win10: reducing scopoe of builds to get bot stable (authored by kuhnel).
clang-x86-ninja-win10: reducing scopoe of builds to get bot stable
Nov 24 2020, 6:58 AM

Nov 23 2020

kuhnel updated the summary of D91945: Enable retry on failed git operations.
Nov 23 2020, 1:03 AM
kuhnel updated the summary of D91945: Enable retry on failed git operations.
Nov 23 2020, 1:02 AM
kuhnel requested review of D91945: Enable retry on failed git operations.
Nov 23 2020, 12:58 AM

Nov 20 2020

kuhnel committed rZORG0564bc60fc7e: clangd-ubuntu-clang: moved to production server (authored by kuhnel).
clangd-ubuntu-clang: moved to production server
Nov 20 2020, 4:07 AM

Nov 18 2020

kuhnel committed rZORG1bc9b3daf451: langd-ubuntu-clang: fixed typo in RAM usage (authored by kuhnel).
langd-ubuntu-clang: fixed typo in RAM usage
Nov 18 2020, 2:22 AM
kuhnel committed rZORGe58caeb94830: clangd-ubuntu-clang: reduced RAM requirements (authored by kuhnel).
clangd-ubuntu-clang: reduced RAM requirements
Nov 18 2020, 2:12 AM

Nov 17 2020

kuhnel committed rZORG90207140bdb9: clangd-ubuntu-clang: increased resource limits to cover TSan builds (authored by kuhnel).
clangd-ubuntu-clang: increased resource limits to cover TSan builds
Nov 17 2020, 3:00 AM