ping @reames

In D108513#3330373, @aeubanks wrote:

In D108513#3328480, @kuhnel wrote:

We're actually using chocolatey for all tools that it offers in pre-merge and that works very well, much better than downloading installers and executing them...

Which package are you using to get gnu tools?

We're actually using chocolatey for all tools that it offers in pre-merge and that works very well, much better than downloading installers and executing them...

Thx @sammccall for your patience with this cleanup.

fixed A_CC in BackgroundIndexTests.cpp

re-created patch, then updated matcher macros

addressed review comments

Re-created the patch as there were too many changes in the repo.

Thx @reames and @xgupta for your review! I hopefully addressed all of them.

TODO: check for remaining const then submit.

Discussion in team sync, work for myself:

• most changes are in unittests --> propose something for the matchers
• cleaning up constants makes sense
• clean up this patch, then do another round of reviews

more reverts of consts

fixed more const ClangdTests.cpp

reverted the const as advised in Sam's comment

In D113898#3167215, @kbobyrev wrote:

In D113898#3167050, @kuhnel wrote:

Looking at the documentation, this looks like a bug in the clang-tidy check:
https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

The rule llvm-qualified-auto should not add a const qualifier.

I don't see how that is a bug: the docs specially cover the const auto * conversion in the first example by drawing the line between observe() (non-mutating function) and change() (possibly mutating function).

Looking at the documentation, this looks like a bug in the clang-tidy check:
https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

@kadircet looks like clang-tidy does not detect missing comments in #endif. It does complain about missing comments for namespaces. E.g. in Serialization.h the #endif comment is missing, but without a finding.

addressed review comments

When trying to revert some of the changes, I just noticed there are a couple of if (const auto* ... in CodeComplete.cpp and AST.cpp (and maybe other files as well). So some folks seem to be using this right now. If we want to be consistent, we would have to remove these const as well.

thx for the explanation, makes sense
--> abandoning this change

addresed Sam's comments

addressed Sam's comments

In D113902#3131707, @sammccall wrote:

Hmm, clang-tidy should only be running on entries in compile_commands.json. are these files listed somehow?

Based on Sam's comments and our offline discussion, I would propose:

1. abandon this patch
2. start a discussion on the mailing list to disable this check for all of the llvm monorepo.

I just checked with my local clangd and it does not crash on this file...

No more comments from me. However I'm not an expert on bash scripting...

Thx everyone for the reviews, I updated the proposal accordingly.

addressed review feedback

2nd iteration of the patch

ping @reames

@xgupta @xzq0528 @gribozavr @meikeb
FYI, as you were working on this tutorial as well

Out of interest, did you see https://llvm.org/docs/ProgrammersManual.html#error-handling ? If not (and if you find it helpful) then maybe we need to make that document more discoverable. If that document is not helpful then we should improve it.

Thx for pointing that out! I was not aware of such a feature.

Sorry, somehow the comments did not end up in my email inbox.
I just landed the patch.

was just a demo

Thx for cleaning up the Windows instructions!

fixing windows build

addressed some review comments

addressed code review comments