This is an archive of the discontinued LLVM Phabricator instance.

Differential D113605

[lldb][NFC] Fix documentation for EncodingDataType
ClosedPublic

Authored by ljmf00 on Nov 10 2021, 12:53 PM.

Details

Reviewers
teemperor
Commits
rG1695dd175242: [lldb][NFC] Fix documentation for EncodingDataType

Diff Detail

Event Timeline

ljmf00 requested review of this revision.Nov 10 2021, 12:53 PM
ljmf00 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 12:53 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
ljmf00 added a parent revision: D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.Nov 10 2021, 12:53 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptNov 10 2021, 12:53 PM
Harbormaster completed remote builds in B133565: Diff 386290.Nov 10 2021, 12:56 PM
ljmf00 updated this revision to Diff 386362.Nov 10 2021, 5:03 PM
ljmf00 retitled this revision from [lldb] Add documentation for eEncodingIsSyntheticUID to [lldb] Fix documentation for EncodingDataType.
ljmf00 added a reviewer: teemperor.
Harbormaster completed remote builds in B133624: Diff 386362.Nov 10 2021, 5:06 PM
ljmf00 added a child revision: D113634: [lldb] Add support for DW_TAG_immutable_type.Nov 10 2021, 5:31 PM
teemperor accepted this revision.Nov 11 2021, 6:33 AM

LGTM, thanks!

lldb/include/lldb/Symbol/Type.h
69

nit: LLVM comments end in a period.

This revision is now accepted and ready to land.Nov 11 2021, 6:33 AM
ljmf00 retitled this revision from [lldb] Fix documentation for EncodingDataType to [lldb][NFC] Fix documentation for EncodingDataType.Nov 29 2021, 3:42 PM
ljmf00 removed a parent revision: D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.Dec 14 2021, 12:13 PM
Closed by commit rG1695dd175242: [lldb][NFC] Fix documentation for EncodingDataType (authored by ljmf00). · Explain WhyDec 14 2021, 12:15 PM
This revision was automatically updated to reflect the committed changes.
ljmf00 added a commit: rG1695dd175242: [lldb][NFC] Fix documentation for EncodingDataType.
ljmf00 added inline comments.Dec 14 2021, 12:16 PM
lldb/include/lldb/Symbol/Type.h
69

Fixed on push.

Revision Contents

PathSize
lldb/
include/
lldb/
Symbol/
3 lines

Diff 386290

lldb/include/lldb/Symbol/Type.h

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
protected: protected:
SymbolFile &m_symbol_file; SymbolFile &m_symbol_file;
lldb::TypeSP m_type_sp; lldb::TypeSP m_type_sp;
}; };
class Type : public std::enable_shared_from_this<Type>, public UserID { class Type : public std::enable_shared_from_this<Type>, public UserID {
public: public:
enum EncodingDataType { enum EncodingDataType {
eEncodingInvalid, eEncodingInvalid,
teemperorUnsubmitted
Not Done
ReplyInline Actions

nit: LLVM comments end in a period.

teemperor: nit: LLVM comments end in a period.
ljmf00AuthorUnsubmitted
Done
ReplyInline Actions

Fixed on push.

ljmf00: Fixed on push.
eEncodingIsUID, ///< This type is the type whose UID is m_encoding_uid eEncodingIsUID, ///< This type is the type whose UID is m_encoding_uid
eEncodingIsConstUID, ///< This type is the type whose UID is m_encoding_uid eEncodingIsConstUID, ///< This type is the type whose UID is m_encoding_uid
/// with the const qualifier added /// with the const qualifier added
eEncodingIsRestrictUID, ///< This type is the type whose UID is eEncodingIsRestrictUID, ///< This type is the type whose UID is
/// m_encoding_uid with the restrict qualifier added /// m_encoding_uid with the restrict qualifier added
eEncodingIsVolatileUID, ///< This type is the type whose UID is eEncodingIsVolatileUID, ///< This type is the type whose UID is
/// m_encoding_uid with the volatile qualifier added /// m_encoding_uid with the volatile qualifier added
eEncodingIsTypedefUID, ///< This type is pointer to a type whose UID is eEncodingIsTypedefUID, ///< This type is pointer to a type whose UID is
/// m_encoding_uid /// m_encoding_uid
eEncodingIsPointerUID, ///< This type is pointer to a type whose UID is eEncodingIsPointerUID, ///< This type is pointer to a type whose UID is
/// m_encoding_uid /// m_encoding_uid
eEncodingIsLValueReferenceUID, ///< This type is L value reference to a type eEncodingIsLValueReferenceUID, ///< This type is L value reference to a type
/// whose UID is m_encoding_uid /// whose UID is m_encoding_uid
eEncodingIsRValueReferenceUID, ///< This type is R value reference to a type eEncodingIsRValueReferenceUID, ///< This type is R value reference to a type
/// whose UID is m_encoding_uid, /// whose UID is m_encoding_uid,
eEncodingIsAtomicUID, ///< This type is the type whose UID is eEncodingIsAtomicUID, ///< This type is the type whose UID is
/// m_encoding_uid as an atomic type. /// m_encoding_uid as an atomic type.
eEncodingIsSyntheticUID eEncodingIsSyntheticUID ///< This type is the synthetic type whose UID is
/// m_encoding_uid
}; };
enum class ResolveState : unsigned char { enum class ResolveState : unsigned char {
Unresolved = 0, Unresolved = 0,
Forward = 1, Forward = 1,
Layout = 2, Layout = 2,
Full = 3 Full = 3
}; };
▲ Show 20 Lines • Show All 430 Lines • Show Last 20 Lines