[test][objcopy] Replace GNU sed extension with BSD compatible syntax.

[drodriguez]

Summary

GNU sed offers the ,+4d to delete the line a next four lines, but BSD
sed doesn't seem to support it (at least in macOS 10.15, but seems to do
in my 11.6 version).

Replace the usage of the extension with the equivalent syntax that works
both in BSD and GNU sed. I don't have a macOS 10.15 to check, but this
works in both my macOS 11.6 and Linux machines.

The problem was introduced in D111164. It also contains a small change to
not use cat proposed in feedback in that other diff.

[smeenai]

LGTM

[drodriguez]

The LLD test compact-unwind-bad-reloc.s failed during the checks, but seems to be fixed in https://reviews.llvm.org/rG1d2a4cd57df590a5d9a6aec9ecdf93a523c8b64b

[thakis]

This breaks tests on macOS: http://45.33.8.238/mac/37731/step_11.txt

Please take a look, and revert for now if it takes a while to fix.

[thakis]

I attempted to fix this in 3c0cf7e1a9a3. We'll know if it worked in 15 min or so.

[thakis]

Looks like that worked. All my bots are happy now.

[drodriguez]

Sorry about more breakage. I don’t understand how I was testing for these to pass over and over before submitting.

Thanks for the fix.

llvm/test/tools/llvm-objcopy/MachO/code_signature_lc.test

 # RUN: yaml2obj %s -o %t
 
 ## Verify that the input file is valid and contains the expected load command.
 # RUN: llvm-objdump --private-headers %t | FileCheck %s --check-prefix=CHECK-ORIGINAL
 
 # CHECK-ORIGINAL:      cmd LC_CODE_SIGNATURE
 # CHECK-ORIGINAL-NEXT: cmdsize 16
 # CHECK-ORIGINAL-NEXT: dataoff 16544
 # CHECK-ORIGINAL-NEXT: datasize 280
 
 # RUN: llvm-objcopy %t %t.copy
 # RUN: obj2yaml %t > %t.yaml
 # RUN: obj2yaml %t.copy > %t.copy.yaml
 
 ## Verify that the copy still includes the load command
-# RUN: cat %t.copy.yaml | FileCheck %s --check-prefix=CHECK-COPY
+# RUN: FileCheck %s --check-prefix=CHECK-COPY < %t.copy.yaml
 # CHECK-COPY:      - cmd:             LC_CODE_SIGNATURE
 # CHECK-COPY-NEXT:   cmdsize:         16
 # CHECK-COPY-NEXT:   dataoff:         16544
 # CHECK-COPY-NEXT:   datasize:        304
 
 ## Remove information changed by regeneration of load command:
-## - __LINKEDIT segment filesize may change
-## - LC_CODE_SIGNATURE command dataoff and datasize may change
+## - __LINKEDIT segment filesize may change (4 lines)
+## - LC_CODE_SIGNATURE command dataoff and datasize may change (3 lines)
 ## - __LINKEDIT data locations may change
+## NOTE: The {N;N;N;N;d} means delete the next four lines for BSD and GNU sed.
+##       The ,+4d is a GNU extension which seems not to work in macOS 10.15
 
-# RUN: sed -e '/__LINKEDIT/,+4d' \
-# RUN:     -e '/LC_CODE_SIGNATURE/,+3d' \ 
+# RUN: sed -e '/__LINKEDIT/{N;N;N;N;d;}' \
+# RUN:     -e '/LC_CODE_SIGNATURE/{N;N;N;d}' \
 # RUN:     -e '/n_strx/d' \ 
 # RUN:     -e '/dyld_stub_binder/d' %t.yaml > %t.clean.yaml
 
-# RUN: sed -e '/__LINKEDIT/,+4d' \
-# RUN:     -e '/LC_CODE_SIGNATURE/,+3d' \ 
+# RUN: sed -e '/__LINKEDIT/{N;N;N;N;d;}' \
+# RUN:     -e '/LC_CODE_SIGNATURE/{N;N;N;d;}' \
 # RUN:     -e '/n_strx/d' \ 
 # RUN:     -e '/dyld_stub_binder/d' %t.copy.yaml > %t.copy.clean.yaml
 
 ## Verify the remainder of the object file remains unchanged
 # RUN: diff %t.clean.yaml %t.copy.clean.yaml
 
 ## Verify the new signature is valid
 # RUN: %python %p/Inputs/code-signature-check.py %t.copy 16544 304 0 16544