Constexpr C strings

I expanded updateLoadCommandIndexes to update the CodeSignatureCommandIndex and TextSegmentCommandIndex values. In the new test, I check that the text segment size and offset values included in the code signature header are accurate. I also added asserts to make sure TextSegmentCommandIndex does in fact point to the correct load command, and not just another segment load command with identical size and offset. I was unable to get the text segment offset to change (it remains at 0 even after inserting more commands), but I think this is expected and so long as TextSegmentCommandIndex is accurate, the rest should also be accurate.

Update updateLoadCommandIndexes to include TextSegment/CodeSignature commands, add test inserting load command shifting load commands around

In D111164#3052797, @alexander-shaposhnikov wrote:

adding / removing load commands (e.g. rpath) can trigger such changes (but beware the alignment + the order of load commands matters) so the test needs to be specifically designed for these purposes

(I would use llvm-objdump or llvm-readobj to verify that the offset of __TEXT has changed etc)

P.S. btw - you probably want to update TextSegmentCommandIndex inside updateLoadCommandIndexes(..) and such a test would catch it, alternatively, it can be calculated where it's actually used (and the field can be dropped)

Copy test script, remove getSegment* declarations, add const ref getter

In D111164#3048090, @tschuett wrote:

The symlink creates a dependency from LLVM to lld, while lld depends on LLVM ^^

Remove "Section" in variable names, move CodeSignature to MachOLayoutBuilder, move text segment helpers

Correct output file name resolution for windows

Construct object::CodeSignature object once

Use FileCheck variables in test

In D109840#3003027, @oontvoo wrote:

In D109840#3002816, @int3 wrote:

What @oontvoo left out was how to define variables for FileCheck :) you'll want something like -D#DATAOFF=16400 here for the substitution to work. Then you can reference it via #DATAOFF. (The # indicates that the value is an integer. It only matters if you want to do arithmetic on the values, which doesn't apply in this case, but it's nice to use # anyway for clarity.)

Ah, yes - I'd forgot that part. Thanks for clarifying it!

not sure why this comment is not in-lined anymore. 🤔 @nuriamari : Do you use arc to update this patch?

Restore static asserts

Satisfy clang-tidy / clang-format

Correct docstring argument description

Fix stray comment, rearrange type definition and clean up static asserts

Address shebang, comment and spacing related feeback

In D109803#3001996, @thakis wrote:

In D109803#3001885, @nuriamari wrote:

In D109803#3001863, @thakis wrote:

Move itself looks fine, but why is there a new lld test in here? This should be behavior-preserving, so I wouldn't expect test updates.

If you want to add a new test to lld independently from this change (?), I'd put that in a separate patch.

The new test is to ensure no behavior is broken. The existing code signature related test does not test that the hash was performed properly, just that the load command is included. This test is to make sure the move doesn't break the signature generation.

Can we land that in its own patch? :)

Remove new test, now included in separate patch

In D109803#3001863, @thakis wrote:

Move itself looks fine, but why is there a new lld test in here? This should be behavior-preserving, so I wouldn't expect test updates.

If you want to add a new test to lld independently from this change (?), I'd put that in a separate patch.