Page MenuHomePhabricator

drodriguez (Daniel Rodríguez Troitiño)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 3:35 PM (184 w, 5 d)

Recent Activity

Tue, Nov 22

drodriguez committed rG652713e268d8: [MachO][ObjCopy] Handle exports trie in LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE (authored by drodriguez).
[MachO][ObjCopy] Handle exports trie in LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE
Tue, Nov 22, 6:52 PM · Restricted Project, Restricted Project
drodriguez closed D137879: [MachO][ObjCopy] Handle exports trie in LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Tue, Nov 22, 6:51 PM · Restricted Project, Restricted Project
drodriguez committed rG42ad9bf95fd5: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE (authored by drodriguez).
[MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE
Tue, Nov 22, 5:47 PM · Restricted Project, Restricted Project
drodriguez closed D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Tue, Nov 22, 5:47 PM · Restricted Project, Restricted Project

Mon, Nov 21

drodriguez updated the diff for D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.

Rename test cases

Mon, Nov 21, 2:52 PM · Restricted Project, Restricted Project

Fri, Nov 11

drodriguez requested review of D137879: [MachO][ObjCopy] Handle exports trie in LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Fri, Nov 11, 5:19 PM · Restricted Project, Restricted Project
drodriguez updated the summary of D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Fri, Nov 11, 5:13 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.

Isolate ObjectYAML and libObject changes from ObjCopy changes. Add test for ObjectYAML changes.

Fri, Nov 11, 5:12 PM · Restricted Project, Restricted Project
drodriguez committed rGdd2165ef8892: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout (authored by drodriguez).
[objcopy] Fix order of Mach-O LINKEDIT pieces during layout
Fri, Nov 11, 12:07 PM · Restricted Project, Restricted Project
drodriguez closed D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.
Fri, Nov 11, 12:07 PM · Restricted Project, Restricted Project
drodriguez committed rGcf15d23e80af: [ObjectYAML] Basic support for chained fixups. (authored by drodriguez).
[ObjectYAML] Basic support for chained fixups.
Fri, Nov 11, 10:26 AM · Restricted Project, Restricted Project
drodriguez closed D134250: [ObjectYAML] Basic support for chained fixups..
Fri, Nov 11, 10:26 AM · Restricted Project, Restricted Project

Wed, Nov 9

drodriguez added a comment to D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.

I will try to split them. Not breaking anything with two separate changes might be complicated.

Wed, Nov 9, 6:00 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Rewrite without depending on D134571

Wed, Nov 9, 5:58 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D134250: [ObjectYAML] Basic support for chained fixups..

Remove pieces related to the export trie to avoid dependency in previous diff.

Wed, Nov 9, 1:24 PM · Restricted Project, Restricted Project
drodriguez added a comment to D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.

I am going to try to rewrite the diffs on top of this one to avoid the dependency, but if someone has some opinion about how to do this properly or what can I improve to make it better, I will appreciate it.

Wed, Nov 9, 1:22 PM · Restricted Project, Restricted Project

Fri, Nov 4

drodriguez added a comment to D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

gentle ping. @drodriguez , @smeenai

Fri, Nov 4, 7:13 PM · Restricted Project, Restricted Project

Oct 14 2022

drodriguez committed rGd11b9fa3bfb9: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as (authored by drodriguez).
[clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as
Oct 14 2022, 2:35 PM · Restricted Project, Restricted Project
drodriguez closed D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as.
Oct 14 2022, 2:35 PM · Restricted Project, Restricted Project
drodriguez added inline comments to D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Oct 14 2022, 10:02 AM · Restricted Project, Restricted Project

Oct 13 2022

drodriguez updated the diff for D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as.

clang-format

Oct 13 2022, 5:28 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as.

From internal review: use virtual method in ToolChain instead of static_cast.

Oct 13 2022, 3:14 PM · Restricted Project, Restricted Project
drodriguez added a comment to D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.

Can someone have a look at this one? Thanks!

Oct 13 2022, 2:06 PM · Restricted Project, Restricted Project

Oct 11 2022

drodriguez requested review of D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as.
Oct 11 2022, 4:48 PM · Restricted Project, Restricted Project

Oct 5 2022

drodriguez committed rG1a5116794def: [NFC] Fix typo in error message. (authored by drodriguez).
[NFC] Fix typo in error message.
Oct 5 2022, 5:11 PM · Restricted Project, Restricted Project
drodriguez closed D135318: [NFC] Fix typo in error message..
Oct 5 2022, 5:10 PM · Restricted Project, Restricted Project
drodriguez requested review of D135318: [NFC] Fix typo in error message..
Oct 5 2022, 1:40 PM · Restricted Project, Restricted Project

Oct 4 2022

drodriguez committed rG86bf43d2ab13: [ObjectYAML] Support for basic data in code. (authored by drodriguez).
[ObjectYAML] Support for basic data in code.
Oct 4 2022, 9:37 AM · Restricted Project, Restricted Project
drodriguez closed D134569: [ObjectYAML] Support for basic data in code..
Oct 4 2022, 9:37 AM · Restricted Project, Restricted Project
drodriguez committed rG57bd11f047d0: [ObjectYAML][MachO] Encode export trie address as ULEB128, not as SLEB128 (authored by drodriguez).
[ObjectYAML][MachO] Encode export trie address as ULEB128, not as SLEB128
Oct 4 2022, 9:24 AM · Restricted Project, Restricted Project
drodriguez closed D134563: [ObjectYAML][MachO] Encode export trie address as ULEB128, not as SLEB128.
Oct 4 2022, 9:23 AM · Restricted Project, Restricted Project

Oct 3 2022

drodriguez added reviewers for D134563: [ObjectYAML][MachO] Encode export trie address as ULEB128, not as SLEB128: jhenderson, rupprecht.
Oct 3 2022, 5:42 PM · Restricted Project, Restricted Project

Sep 26 2022

drodriguez added inline comments to D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.
Sep 26 2022, 5:30 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Use FileCheck mul() for multiplying. Improve test by checking the output several times. Add tests for both chained fixups and non-chained fixups.

Sep 26 2022, 5:28 PM · Restricted Project, Restricted Project

Sep 23 2022

drodriguez committed rG74150a0afa2d: [objdump] Fix typo in error message. (authored by drodriguez).
[objdump] Fix typo in error message.
Sep 23 2022, 4:29 PM · Restricted Project, Restricted Project
drodriguez closed D134562: [objdump] Fix typo in error message..
Sep 23 2022, 4:28 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Fix typo

Sep 23 2022, 4:08 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Rebase on top of changes from D134569, D134571 and D134250

Sep 23 2022, 4:06 PM · Restricted Project, Restricted Project
drodriguez retitled D134250: [ObjectYAML] Basic support for chained fixups. from [ObjectYAML] Support chained fixups, dyld exports trie, data in code to [ObjectYAML] Basic support for chained fixups..
Sep 23 2022, 4:03 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D134250: [ObjectYAML] Basic support for chained fixups..

Split into D134569, D134571 and this. Use the feedback provided by Higuoxing

Sep 23 2022, 4:03 PM · Restricted Project, Restricted Project
drodriguez requested review of D134571: [MachO] Support exports trie in both LC_DYLD_INFO and LC_DYLD_EXPORTS_TRIE.
Sep 23 2022, 3:56 PM · Restricted Project, Restricted Project
drodriguez requested review of D134569: [ObjectYAML] Support for basic data in code..
Sep 23 2022, 2:56 PM · Restricted Project, Restricted Project
drodriguez requested review of D134563: [ObjectYAML][MachO] Encode export trie address as ULEB128, not as SLEB128.
Sep 23 2022, 1:30 PM · Restricted Project, Restricted Project
drodriguez requested review of D134562: [objdump] Fix typo in error message..
Sep 23 2022, 1:26 PM · Restricted Project, Restricted Project

Sep 20 2022

drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Correctly handle DyldExportsTrie

Sep 20 2022, 3:50 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D134250: [ObjectYAML] Basic support for chained fixups..

Fix incorrect mapping. Fix code for dumping the right LC. Fix test

Sep 20 2022, 3:49 PM · Restricted Project, Restricted Project
drodriguez added a comment to D134250: [ObjectYAML] Basic support for chained fixups..

Amusingly the only documentation I'm aware of that documents the format of the export trie... is in a file you modified in this change: https://github.com/llvm/llvm-project/blob/main/llvm/tools/obj2yaml/macho2yaml.cpp#L473

Sep 20 2022, 3:46 PM · Restricted Project, Restricted Project
drodriguez added a comment to D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

see a small nit above, otherwise - looks good to me.
p.s. https://reviews.llvm.org/D119671 seems to be relevant, don't know the current status of that effort though.
It would be good to review/land D134250 or D119671, alternatively i think it's reasonable to add a TODO (that we should add a test once ObjectYAML is ready) and commit this fix now.
cc: @thakis , @keith

Sep 20 2022, 11:45 AM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

More code style

Sep 20 2022, 11:42 AM · Restricted Project, Restricted Project
drodriguez updated the diff for D134250: [ObjectYAML] Basic support for chained fixups..

More code style.

Sep 20 2022, 11:41 AM · Restricted Project, Restricted Project
drodriguez added a comment to D134250: [ObjectYAML] Basic support for chained fixups..

When I added the initial mach-o support the emphasis was on representing the binary accurately enough to reproduce binary-accurate transformations, but to also have the YAML representation be human readable wherever it could be. This patch really just treats it as binary data, which makes it pretty unreadable.

Sep 20 2022, 10:39 AM · Restricted Project, Restricted Project

Sep 19 2022

drodriguez added inline comments to D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.
Sep 19 2022, 7:16 PM · Restricted Project, Restricted Project
drodriguez updated the diff for D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.

Follow code style. Add a test. Needs D134250.

Sep 19 2022, 7:16 PM · Restricted Project, Restricted Project
drodriguez requested review of D134250: [ObjectYAML] Basic support for chained fixups..
Sep 19 2022, 7:14 PM · Restricted Project, Restricted Project

Sep 15 2022

drodriguez requested review of D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout.
Sep 15 2022, 1:58 PM · Restricted Project, Restricted Project

Jun 24 2022

drodriguez committed rG146f486ba337: [ObjCopy] Fix type mismatch in writeCodeSignatureData() (authored by jmroot).
[ObjCopy] Fix type mismatch in writeCodeSignatureData()
Jun 24 2022, 9:26 AM · Restricted Project, Restricted Project
drodriguez closed D128117: [ObjCopy] Fix type mismatch in writeCodeSignatureData().
Jun 24 2022, 9:26 AM · Restricted Project, Restricted Project

Jun 22 2022

drodriguez added a comment to D128117: [ObjCopy] Fix type mismatch in writeCodeSignatureData().

Thanks for the reviews. I don't have commit access, so could someone who does please commit at your convenience?

Jun 22 2022, 10:36 PM · Restricted Project, Restricted Project

Jun 21 2022

drodriguez accepted D128117: [ObjCopy] Fix type mismatch in writeCodeSignatureData().
Jun 21 2022, 1:58 PM · Restricted Project, Restricted Project

Jun 20 2022

drodriguez added a comment to D128117: [ObjCopy] Fix type mismatch in writeCodeSignatureData().

My comment about using size_t instead are not a blocker, just an opinion.

Jun 20 2022, 10:02 AM · Restricted Project, Restricted Project

Apr 28 2022

drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

In my tests with cctools I do not think I ever used a externally signed binary. I was more worried about adhoc signed binaries from the toolchain itself. I do not think adding a warning will influence our usage, so if that compatibility with cctools is needed, I will be happy to review and approve those changes.

Apr 28 2022, 3:43 PM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

drodriguez committed rG94fba14f9723: [llvm] add -r functionality to llvm-bitcode-strip (authored by rmaz).
[llvm] add -r functionality to llvm-bitcode-strip
Mar 4 2022, 1:28 PM · Restricted Project
drodriguez closed D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 4 2022, 1:28 PM · Restricted Project, Restricted Project
drodriguez committed rG8ba84ceda002: [llvm] fix bitcode-strip.test on windows (authored by rmaz).
[llvm] fix bitcode-strip.test on windows
Mar 4 2022, 8:31 AM · Restricted Project
drodriguez closed D121000: [llvm] fix bitcode-strip.test on windows.
Mar 4 2022, 8:31 AM · Restricted Project, Restricted Project
drodriguez accepted D121000: [llvm] fix bitcode-strip.test on windows.
Mar 4 2022, 8:29 AM · Restricted Project, Restricted Project
drodriguez committed rG8e6d2fe4d403: [llvm] add -o flag to llvm-bitcode-strip (authored by rmaz).
[llvm] add -o flag to llvm-bitcode-strip
Mar 4 2022, 8:04 AM · Restricted Project
drodriguez closed D120731: [llvm] add -o flag to llvm-bitcode-strip.
Mar 4 2022, 8:04 AM · Restricted Project, Restricted Project

Nov 29 2021

drodriguez accepted D114410: [ObjectYAML/obj2yaml/yaml2obj][MachO] Support indirect symbol table.
Nov 29 2021, 10:26 AM · Restricted Project

Nov 23 2021

drodriguez added inline comments to D114410: [ObjectYAML/obj2yaml/yaml2obj][MachO] Support indirect symbol table.
Nov 23 2021, 10:26 AM · Restricted Project

Nov 5 2021

drodriguez accepted D113301: [NFC][llvm-libtool-darwin]Remove unnecessary conditionals around errors..
Nov 5 2021, 1:15 PM · Restricted Project

Oct 28 2021

drodriguez committed rG8fbe1e760224: [llvm-objcopy] Fix misaligned access to load command data. (authored by drodriguez).
[llvm-objcopy] Fix misaligned access to load command data.
Oct 28 2021, 10:17 PM
drodriguez closed D112744: [llvm-objcopy] Fix misaligned access to load command data..
Oct 28 2021, 10:17 PM · Restricted Project
drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Fix in https://reviews.llvm.org/D112744

Oct 28 2021, 11:51 AM · Restricted Project, Restricted Project, Restricted Project
drodriguez requested review of D112744: [llvm-objcopy] Fix misaligned access to load command data..
Oct 28 2021, 11:51 AM · Restricted Project
drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

@uabelho: Thanks for pointing it out. I think I found a possible solution. It seems to me that llvm-objcopy might store data unaligned temporarily, and we did not realize.

Oct 28 2021, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2021

drodriguez added a comment to D112583: [test][objcopy] Replace GNU sed extension with BSD compatible syntax..

Sorry about more breakage. I don’t understand how I was testing for these to pass over and over before submitting.

Oct 26 2021, 7:23 PM · Restricted Project
drodriguez committed rG911be05743eb: [test][objcopy] Replace GNU sed extension with BSD compatible syntax. (authored by drodriguez).
[test][objcopy] Replace GNU sed extension with BSD compatible syntax.
Oct 26 2021, 5:37 PM
drodriguez closed D112583: [test][objcopy] Replace GNU sed extension with BSD compatible syntax..
Oct 26 2021, 5:37 PM · Restricted Project
drodriguez added a comment to D112583: [test][objcopy] Replace GNU sed extension with BSD compatible syntax..

The LLD test compact-unwind-bad-reloc.s failed during the checks, but seems to be fixed in https://reviews.llvm.org/rG1d2a4cd57df590a5d9a6aec9ecdf93a523c8b64b

Oct 26 2021, 5:36 PM · Restricted Project
drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Created D112583 with a possible fix. My macOS does not fail the same as in CI, and I don't have a 10.15 machine at hand to actually check.

Oct 26 2021, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
drodriguez updated the summary of D112583: [test][objcopy] Replace GNU sed extension with BSD compatible syntax..
Oct 26 2021, 5:08 PM · Restricted Project
drodriguez requested review of D112583: [test][objcopy] Replace GNU sed extension with BSD compatible syntax..
Oct 26 2021, 5:06 PM · Restricted Project
drodriguez added inline comments to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Oct 26 2021, 4:29 PM · Restricted Project, Restricted Project, Restricted Project
drodriguez committed rGa299b24712cc: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations (authored by nuriamari).
Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations
Oct 26 2021, 2:52 PM
drodriguez closed D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Oct 26 2021, 2:52 PM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2021

drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

adding / removing load commands (e.g. rpath) can trigger such changes (but beware the alignment + the order of load commands matters) so the test needs to be specifically designed for these purposes

(I would use llvm-objdump or llvm-readobj to verify that the offset of __TEXT has changed etc)

P.S. btw - you probably want to update TextSegmentCommandIndex inside updateLoadCommandIndexes(..) and such a test would catch it, alternatively, it can be calculated where it's actually used (and the field can be dropped)

Oct 13 2021, 5:07 PM · Restricted Project, Restricted Project, Restricted Project

Oct 8 2021

drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Just in case - do we have a test (for the new functionality) where the index of LC_SEGMENT* and the offset of __TEXT are modified ? (to ensure that the signature is calculated correctly in this case)

Oct 8 2021, 4:19 PM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2021

drodriguez added inline comments to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Oct 7 2021, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
drodriguez added inline comments to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Oct 7 2021, 9:21 AM · Restricted Project, Restricted Project, Restricted Project

Oct 1 2021

drodriguez added a reverting change for rGcc8229603b67: Extract LC_CODE_SIGNATURE related implementation out of LLD: rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 5:22 PM
drodriguez committed rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD" (authored by drodriguez).
Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD"
Oct 1 2021, 5:22 PM
drodriguez added a reverting change for D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD: rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 5:22 PM · Restricted Project, Restricted Project
drodriguez closed D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 5:21 PM · Restricted Project, Restricted Project
drodriguez added a comment to D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD.

Reverted in https://reviews.llvm.org/D110974

Oct 1 2021, 2:35 PM · Restricted Project, Restricted Project
drodriguez abandoned D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Oct 1 2021, 2:35 PM · Restricted Project
drodriguez commandeered D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Reverted the previous one in https://reviews.llvm.org/D110974

Oct 1 2021, 2:35 PM · Restricted Project
drodriguez added a reverting change for rGcc8229603b67: Extract LC_CODE_SIGNATURE related implementation out of LLD: D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 2:34 PM
drodriguez added a reverting change for D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD: D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 2:34 PM · Restricted Project, Restricted Project
drodriguez requested review of D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Oct 1 2021, 2:34 PM · Restricted Project, Restricted Project