Page MenuHomePhabricator

drodriguez (Daniel Rodríguez Troitiño)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 3:35 PM (30 w, 17 h)

Recent Activity

Tue, Dec 3

drodriguez added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

@aemerson: Thank you very much for accepting. I think I reduced the test case correctly. I needed to use the result of the G_LOAD, or the code was not being generated with the necessary G_TRUNC. I didn't imagine that it was as easy as returning the result. I hope the new test is better than the last.

Tue, Dec 3, 6:55 PM · Restricted Project
drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Reduced the test case.

Tue, Dec 3, 6:54 PM · Restricted Project

Mon, Dec 2

drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Generate the checks in the test with update_mir_test_checks.py. Check with FileCheck that the test actually passes.

Mon, Dec 2, 6:31 PM · Restricted Project
drodriguez added inline comments to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Mon, Dec 2, 6:31 PM · Restricted Project
drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Provide more context. Rebase on top of master, just in case.

Mon, Dec 2, 4:07 PM · Restricted Project

Wed, Nov 27

drodriguez created D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Wed, Nov 27, 11:23 AM · Restricted Project

Jun 5 2019

drodriguez added a comment to D62022: [lit] Improve globbing in Windows with long paths.

100% agree with you that handling long paths on Windows is a battle that I cannot win. Sadly, even if I can modify a little where my checkout is, and I can reduce that path the best I can, but when CMake and a lot more pieces start creating directories, they will not take care of the length, and they might end up creating very long paths (inside my short path). The problem appeared when a tool started creating a directory (with a long-ish name which cannot be easily modified) inside the temporal directory for a test. Short path + short path + short path ended up being long path.

Jun 5 2019, 1:06 PM · Restricted Project

May 31 2019

drodriguez added a comment to D62022: [lit] Improve globbing in Windows with long paths.

I will hold this for a moment. The review can happen, but I would not merge it directly. I think I would need to return the results with the prefix in the cases I know it is necessary.

May 31 2019, 11:49 AM · Restricted Project

May 16 2019

drodriguez created D62022: [lit] Improve globbing in Windows with long paths.
May 16 2019, 11:40 AM · Restricted Project