Page MenuHomePhabricator

drodriguez (Daniel Rodríguez Troitiño)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 3:35 PM (126 w, 3 d)

Recent Activity

Wed, Oct 13

drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

adding / removing load commands (e.g. rpath) can trigger such changes (but beware the alignment + the order of load commands matters) so the test needs to be specifically designed for these purposes

(I would use llvm-objdump or llvm-readobj to verify that the offset of __TEXT has changed etc)

P.S. btw - you probably want to update TextSegmentCommandIndex inside updateLoadCommandIndexes(..) and such a test would catch it, alternatively, it can be calculated where it's actually used (and the field can be dropped)

Wed, Oct 13, 5:07 PM · Restricted Project, Restricted Project

Fri, Oct 8

drodriguez added a comment to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Just in case - do we have a test (for the new functionality) where the index of LC_SEGMENT* and the offset of __TEXT are modified ? (to ensure that the signature is calculated correctly in this case)

Fri, Oct 8, 4:19 PM · Restricted Project, Restricted Project

Thu, Oct 7

drodriguez added inline comments to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Thu, Oct 7, 2:16 PM · Restricted Project, Restricted Project
drodriguez added inline comments to D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Thu, Oct 7, 9:21 AM · Restricted Project, Restricted Project

Fri, Oct 1

drodriguez added a reverting change for rGcc8229603b67: Extract LC_CODE_SIGNATURE related implementation out of LLD: rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 5:22 PM
drodriguez committed rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD" (authored by drodriguez).
Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD"
Fri, Oct 1, 5:22 PM
drodriguez added a reverting change for D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD: rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 5:22 PM · Restricted Project, Restricted Project
drodriguez closed D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 5:21 PM · Restricted Project, Restricted Project
drodriguez added a comment to D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD.

Reverted in https://reviews.llvm.org/D110974

Fri, Oct 1, 2:35 PM · Restricted Project, Restricted Project
drodriguez abandoned D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Fri, Oct 1, 2:35 PM · Restricted Project
drodriguez commandeered D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

Reverted the previous one in https://reviews.llvm.org/D110974

Fri, Oct 1, 2:35 PM · Restricted Project
drodriguez added a reverting change for rGcc8229603b67: Extract LC_CODE_SIGNATURE related implementation out of LLD: D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 2:34 PM
drodriguez added a reverting change for D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD: D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 2:34 PM · Restricted Project, Restricted Project
drodriguez requested review of D110974: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".
Fri, Oct 1, 2:34 PM · Restricted Project, Restricted Project

Thu, Sep 30

drodriguez added a comment to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

A follow up: after some discussion internally, we have decided that the best way forward should be the following:

Thu, Sep 30, 2:49 PM · Restricted Project

Tue, Sep 21

drodriguez added a comment to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

@mtrent: I noticed that change around the time of Xcode 12 (thanks!). However, even if the headers were available, I don't think LLVM would accept it as a dependency. What we are trying to do here is similar, with a common piece of code that handles the generation of these parts of the MachO binary. In the future, if it needs to be modified for some reason, all the tools should enjoy the improvements after a recompilation, instead of chasing down every tool implementation and modifying them.

Tue, Sep 21, 5:43 PM · Restricted Project
drodriguez added a comment to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

@steven_wu: Thanks for the feedback. I think at this point we are completely conviced that libObject was not the right place. We are trying to find a good place, and we would like, as much as possible to not duplicate the same code or logic in two tools. It is not a lot of code right now, but the potential divergence in the future scares us a little.

Tue, Sep 21, 2:14 PM · Restricted Project
drodriguez added inline comments to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Tue, Sep 21, 12:07 PM · Restricted Project

Mon, Sep 20

drodriguez added a comment to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.

@jhenderson: thanks for the feedback, we will apply those when we figure out the best shape for these changes.

Mon, Sep 20, 1:01 PM · Restricted Project

Fri, Sep 17

drodriguez added inline comments to D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.
Fri, Sep 17, 6:53 PM · Restricted Project

Sep 16 2021

drodriguez committed rGaaf00f3f19c1: Add MachO signature verification test (authored by nuriamari).
Add MachO signature verification test
Sep 16 2021, 5:57 PM
drodriguez closed D109840: Add MachO signature verification test.
Sep 16 2021, 5:56 PM · Restricted Project, Restricted Project
drodriguez committed rGcc8229603b67: Extract LC_CODE_SIGNATURE related implementation out of LLD (authored by nuriamari).
Extract LC_CODE_SIGNATURE related implementation out of LLD
Sep 16 2021, 5:45 PM
drodriguez closed D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD.
Sep 16 2021, 5:45 PM · Restricted Project, Restricted Project
drodriguez committed rGe6020b2a4224: [clang][NFC] refactor GlobalMethodPool to encapsulate its map (authored by rmaz).
[clang][NFC] refactor GlobalMethodPool to encapsulate its map
Sep 16 2021, 2:12 PM
drodriguez closed D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map.
Sep 16 2021, 2:12 PM · Restricted Project

Jul 28 2021

drodriguez committed rGd6704e5ed914: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands. (authored by drodriguez).
[llvm-objcopy][MachO] Ignore all LC_SUB_* commands.
Jul 28 2021, 5:36 PM
drodriguez closed D106412: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands..
Jul 28 2021, 5:36 PM · Restricted Project

Jul 26 2021

drodriguez updated the diff for D106412: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands..
  • Rebase
  • Use Content instead of PayloadString (adopting D106759)
  • Use cmp in the test to check that objcopy does a perfect copy.
Jul 26 2021, 6:26 PM · Restricted Project
drodriguez added a comment to D106412: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands..

I'll rename PayloadString to Content in D106759

Jul 26 2021, 9:19 AM · Restricted Project

Jul 20 2021

drodriguez requested review of D106412: [llvm-objcopy][MachO] Ignore all LC_SUB_* commands..
Jul 20 2021, 4:50 PM · Restricted Project

Jul 15 2021

drodriguez committed rG3c4023b225ac: [test] Use double pound to denote comments. (authored by drodriguez).
[test] Use double pound to denote comments.
Jul 15 2021, 5:42 PM
drodriguez closed D106103: [test] Use double pound to denote comments..
Jul 15 2021, 5:41 PM · Restricted Project
drodriguez requested review of D106103: [test] Use double pound to denote comments..
Jul 15 2021, 2:53 PM · Restricted Project

Jul 6 2021

drodriguez added inline comments to D105249: [llvm-strip] Support grouped options in llvm-strip.
Jul 6 2021, 9:09 AM · Restricted Project

Jul 1 2021

drodriguez updated the diff for D105249: [llvm-strip] Support grouped options in llvm-strip.

Lint

Jul 1 2021, 9:45 AM · Restricted Project
drodriguez updated the diff for D105249: [llvm-strip] Support grouped options in llvm-strip.

Move configuration to constructors. Enable grouped options in llvm-objcopy. Add comment about the intention of the test. Remove blank line.

Jul 1 2021, 9:44 AM · Restricted Project

Jun 30 2021

drodriguez updated the diff for D105249: [llvm-strip] Support grouped options in llvm-strip.

Remove .zdebugGlobal and .gdb_index from the test

Jun 30 2021, 7:03 PM · Restricted Project
drodriguez added a comment to D105243: [cmake] Invoke strip without -l and with non-grouped flags..

https://reviews.llvm.org/D105249 adds the support for grouped options. I will keep the options separated in this commit (if nobody has any concerns), since it seems more portable at this point.

Jun 30 2021, 5:13 PM · Restricted Project
drodriguez requested review of D105249: [llvm-strip] Support grouped options in llvm-strip.
Jun 30 2021, 4:57 PM · Restricted Project
drodriguez requested review of D105243: [cmake] Invoke strip without -l and with non-grouped flags..
Jun 30 2021, 4:06 PM · Restricted Project

May 20 2021

drodriguez requested review of D102889: [lldb] Match test dependencies name to other LLVM projects..
May 20 2021, 4:45 PM · Restricted Project

Apr 2 2021

drodriguez added a comment to D99690: [builtins] Build for arm64_32 for watchOS (Darwin).

@delcypher: I will. Is there any concerns about the code as landed?

Apr 2 2021, 9:26 AM · Restricted Project

Mar 31 2021

drodriguez requested review of D99690: [builtins] Build for arm64_32 for watchOS (Darwin).
Mar 31 2021, 2:30 PM · Restricted Project
drodriguez requested review of D99673: [TextAPI] Add support for arm64_32.
Mar 31 2021, 10:14 AM · Restricted Project

Dec 3 2019

drodriguez added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

@aemerson: Thank you very much for accepting. I think I reduced the test case correctly. I needed to use the result of the G_LOAD, or the code was not being generated with the necessary G_TRUNC. I didn't imagine that it was as easy as returning the result. I hope the new test is better than the last.

Dec 3 2019, 6:55 PM · Restricted Project
drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Reduced the test case.

Dec 3 2019, 6:54 PM · Restricted Project

Dec 2 2019

drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Generate the checks in the test with update_mir_test_checks.py. Check with FileCheck that the test actually passes.

Dec 2 2019, 6:31 PM · Restricted Project
drodriguez added inline comments to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Dec 2 2019, 6:31 PM · Restricted Project
drodriguez updated the diff for D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Provide more context. Rebase on top of master, just in case.

Dec 2 2019, 4:07 PM · Restricted Project

Nov 27 2019

drodriguez created D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Nov 27 2019, 11:23 AM · Restricted Project

Jun 5 2019

drodriguez added a comment to D62022: [lit] Improve globbing in Windows with long paths.

100% agree with you that handling long paths on Windows is a battle that I cannot win. Sadly, even if I can modify a little where my checkout is, and I can reduce that path the best I can, but when CMake and a lot more pieces start creating directories, they will not take care of the length, and they might end up creating very long paths (inside my short path). The problem appeared when a tool started creating a directory (with a long-ish name which cannot be easily modified) inside the temporal directory for a test. Short path + short path + short path ended up being long path.

Jun 5 2019, 1:06 PM · Restricted Project

May 31 2019

drodriguez added a comment to D62022: [lit] Improve globbing in Windows with long paths.

I will hold this for a moment. The review can happen, but I would not merge it directly. I think I would need to return the results with the prefix in the cases I know it is necessary.

May 31 2019, 11:49 AM · Restricted Project

May 16 2019

drodriguez created D62022: [lit] Improve globbing in Windows with long paths.
May 16 2019, 11:40 AM · Restricted Project