This is an archive of the discontinued LLVM Phabricator instance.

Differential D112184

[test][Attributor] Remove legacy PM RUN lines
AbandonedPublic

Authored by aeubanks on Oct 20 2021, 2:24 PM.

Details

Reviewers
uenoku
homerdin
ctetreau
jdoerfert
sstefan1
baziotis
arsenm

Diff Detail

Event Timeline

aeubanks created this revision.Oct 20 2021, 2:24 PM
Herald added a reviewer: uenoku. · View Herald TranscriptOct 20 2021, 2:24 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added subscribers: ormris, okura, jdoerfert and 3 others. · View Herald Transcript
aeubanks added a reviewer: jdoerfert.Oct 20 2021, 2:27 PM
aeubanks updated this revision to Diff 381101.Oct 20 2021, 2:53 PM

update

aeubanks published this revision for review.Oct 20 2021, 2:56 PM
Herald added a reviewer: sstefan1. · View Herald TranscriptOct 20 2021, 2:56 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
jdoerfert added a comment.Oct 20 2021, 3:31 PM

I'm a bit worried about this as the backend still used the old pm, right? The backend also uses the Attributor now, so we should test it.

Harbormaster completed remote builds in B129840: Diff 381101.Oct 20 2021, 3:34 PM
aeubanks added a comment.Oct 20 2021, 3:38 PM
In D112184#3076608, @jdoerfert wrote:

I'm a bit worried about this as the backend still used the old pm, right? The backend also uses the Attributor now, so we should test it.

yeah codegen still uses the legacy PM
where are we using the Attributor in the codegen pipeline?

aeubanks added a comment.Oct 20 2021, 3:45 PM

createAttributorLegacyPass() and createAttributorCGSCCLegacyPass() are only used in PassManagerBuilder, which is the legacy PM's optimization pipeline (not codegen pipeline), which is deprecated

jdoerfert added a comment.Oct 20 2021, 3:59 PM
In D112184#3076635, @aeubanks wrote:

createAttributorLegacyPass() and createAttributorCGSCCLegacyPass() are only used in PassManagerBuilder, which is the legacy PM's optimization pipeline (not codegen pipeline), which is deprecated

AMDGPU backend creates an Attributor instance explicitly: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp

aeubanks added a reviewer: arsenm.Oct 20 2021, 5:04 PM
Herald added a subscriber: wdng. · View Herald TranscriptOct 20 2021, 5:04 PM
aeubanks added a comment.Oct 20 2021, 5:05 PM
In D112184#3076661, @jdoerfert wrote:
In D112184#3076635, @aeubanks wrote:

createAttributorLegacyPass() and createAttributorCGSCCLegacyPass() are only used in PassManagerBuilder, which is the legacy PM's optimization pipeline (not codegen pipeline), which is deprecated

AMDGPU backend creates an Attributor instance explicitly: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp

Ah I see. Would it make sense to move this into the optimization pipeline? e.g. add it into AMDGPUTargetMachine::registerPassBuilderCallbacks(), probably as a PB.registerOptimizerLastEPCallback().
+@arsenm

aeubanks mentioned this in D112178: [LazyCallGraph] Skip blockaddresses.Oct 21 2021, 9:06 AM
aeubanks added a comment.Oct 21 2021, 10:21 AM
In D112184#3076718, @aeubanks wrote:
In D112184#3076661, @jdoerfert wrote:
In D112184#3076635, @aeubanks wrote:

createAttributorLegacyPass() and createAttributorCGSCCLegacyPass() are only used in PassManagerBuilder, which is the legacy PM's optimization pipeline (not codegen pipeline), which is deprecated

AMDGPU backend creates an Attributor instance explicitly: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp

Ah I see. Would it make sense to move this into the optimization pipeline? e.g. add it into AMDGPUTargetMachine::registerPassBuilderCallbacks(), probably as a PB.registerOptimizerLastEPCallback().
+@arsenm

Seems like it's not so easy, I tried this and it breaks a bunch of llc tests.
Would it be ok to keep the amdgpu-attributor tests running against the legacy PM and the other attributor tests against the new PM?

ormris removed a subscriber: ormris.Jan 24 2022, 11:33 AM
aeubanks abandoned this revision.Sep 27 2022, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 10:54 AM

Large Diff

This large diff affects 107 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
llvm/
test/
Transforms/
Attributor/
ArgumentPromotion/
118 lines
83 lines
40 lines
64 lines
X86/
244 lines
1006 lines
7 lines
40 lines
286 lines
142 lines
193 lines
176 lines
168 lines
256 lines
41 lines
78 lines
120 lines
140 lines
26 lines
157 lines
132 lines
1 line
98 lines
122 lines
214 lines
6 lines
6 lines
6 lines
72 lines
74 lines
62 lines
84 lines
125 lines
98 lines
6 lines
IPConstantProp/
6 lines
425 lines
135 lines
247 lines
54 lines
163 lines
53 lines
28 lines
104 lines
34 lines
119 lines
66 lines
125 lines
125 lines
6 lines
254 lines
146 lines
34 lines
56 lines
226 lines
98 lines
176 lines
70 lines
63 lines
1447 lines
59 lines
408 lines
14 lines
17 lines
106 lines
100 lines
6 lines
2 lines
976 lines
828 lines
828 lines
542 lines
179 lines
389 lines
99 lines
2308 lines
30 lines
61 lines
299 lines
128 lines
633 lines
146 lines
3 lines
618 lines
948 lines
454 lines
72 lines
291 lines
1464 lines
400 lines
251 lines
19 lines
19 lines
440 lines
20 lines
65 lines
887 lines
1940 lines
437 lines
469 lines
reduced/
2 lines
1661 lines
1323 lines
189 lines
3729 lines
1150 lines
2546 lines

Diff 381101

llvm/test/Transforms/Attributor/ArgumentPromotion/2008-02-01-ReturnAttrs.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/2008-07-02-array-indexing.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/2008-09-07-CGUpdate.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/2008-09-08-CGUpdateSelfEdge.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/X86/attributes.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/X86/min-legal-vector-width.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/X86/thiscall.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/aggregate-promote.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/alignment.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/array.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/attrs.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/basictest.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/byval-2.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/byval.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/chained.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/control-flow.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/control-flow2.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/crash.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/dbg.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/fp80.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/inalloca.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/invalidation.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/live_called_from_dead.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/live_called_from_dead_2.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/musttail.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/naked_functions.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/nonzero-address-spaces.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/pr27568.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/pr32917.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/pr33641_remove_arg_dbgvalue.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/profile.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/reserve-tbaa.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/sret.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/tail.ll

llvm/test/Transforms/Attributor/ArgumentPromotion/variadic.ll

llvm/test/Transforms/Attributor/IPConstantProp/2008-06-09-WeakProp.ll

llvm/test/Transforms/Attributor/IPConstantProp/2009-09-24-byval-ptr.ll

llvm/test/Transforms/Attributor/IPConstantProp/PR16052.ll

llvm/test/Transforms/Attributor/IPConstantProp/PR26044.ll

llvm/test/Transforms/Attributor/IPConstantProp/PR43857.ll

llvm/test/Transforms/Attributor/IPConstantProp/arg-count-mismatch.ll

llvm/test/Transforms/Attributor/IPConstantProp/arg-type-mismatch.ll

llvm/test/Transforms/Attributor/IPConstantProp/comdat-ipo.ll

llvm/test/Transforms/Attributor/IPConstantProp/dangling-block-address.ll

llvm/test/Transforms/Attributor/IPConstantProp/deadarg.ll

llvm/test/Transforms/Attributor/IPConstantProp/fp-bc-icmp-const-fold.ll

llvm/test/Transforms/Attributor/IPConstantProp/global.ll

llvm/test/Transforms/Attributor/IPConstantProp/multiple_callbacks.ll

llvm/test/Transforms/Attributor/IPConstantProp/musttail-call.ll

llvm/test/Transforms/Attributor/IPConstantProp/naked-return.ll

llvm/test/Transforms/Attributor/IPConstantProp/openmp_parallel_for.ll

llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll

llvm/test/Transforms/Attributor/IPConstantProp/recursion.ll

llvm/test/Transforms/Attributor/IPConstantProp/remove-call-inst.ll

llvm/test/Transforms/Attributor/IPConstantProp/return-argument.ll

llvm/test/Transforms/Attributor/IPConstantProp/return-constant.ll

llvm/test/Transforms/Attributor/IPConstantProp/return-constants.ll

llvm/test/Transforms/Attributor/IPConstantProp/solve-after-each-resolving-undefs-for-function.ll

llvm/test/Transforms/Attributor/IPConstantProp/thread_local_acs.ll

llvm/test/Transforms/Attributor/align.ll

llvm/test/Transforms/Attributor/alwaysinline.ll

llvm/test/Transforms/Attributor/callbacks.ll

llvm/test/Transforms/Attributor/cb_liveness_disabled.ll

llvm/test/Transforms/Attributor/cb_liveness_enabled.ll

llvm/test/Transforms/Attributor/cb_range_disabled.ll

llvm/test/Transforms/Attributor/cb_range_enabled.ll

llvm/test/Transforms/Attributor/cgscc_bugs.ll

llvm/test/Transforms/Attributor/chain.ll

llvm/test/Transforms/Attributor/dereferenceable-1.ll

llvm/test/Transforms/Attributor/dereferenceable-2-inseltpoison.ll

llvm/test/Transforms/Attributor/dereferenceable-2.ll

llvm/test/Transforms/Attributor/heap_to_stack.ll

llvm/test/Transforms/Attributor/heap_to_stack_gpu.ll

llvm/test/Transforms/Attributor/internal-noalias.ll

llvm/test/Transforms/Attributor/internalize.ll

llvm/test/Transforms/Attributor/liveness.ll

llvm/test/Transforms/Attributor/liveness_chains.ll

llvm/test/Transforms/Attributor/lowerheap.ll

llvm/test/Transforms/Attributor/lvi-after-jumpthreading.ll

llvm/test/Transforms/Attributor/lvi-for-ashr.ll

llvm/test/Transforms/Attributor/memory_locations.ll

llvm/test/Transforms/Attributor/misc.ll

llvm/test/Transforms/Attributor/misc_crash.ll

llvm/test/Transforms/Attributor/noalias.ll

llvm/test/Transforms/Attributor/nocapture-1.ll

llvm/test/Transforms/Attributor/nocapture-2.ll

llvm/test/Transforms/Attributor/nodelete.ll

llvm/test/Transforms/Attributor/nofree.ll

llvm/test/Transforms/Attributor/nonnull.ll

llvm/test/Transforms/Attributor/norecurse.ll

llvm/test/Transforms/Attributor/noreturn.ll

llvm/test/Transforms/Attributor/noreturn_async.ll

llvm/test/Transforms/Attributor/noreturn_sync.ll

llvm/test/Transforms/Attributor/nosync.ll

llvm/test/Transforms/Attributor/noundef.ll

llvm/test/Transforms/Attributor/nounwind.ll

llvm/test/Transforms/Attributor/potential.ll

llvm/test/Transforms/Attributor/range.ll

llvm/test/Transforms/Attributor/read_write_returned_arguments_scc.ll

llvm/test/Transforms/Attributor/readattrs.ll

llvm/test/Transforms/Attributor/reduced/register_benchmark_test.ll

llvm/test/Transforms/Attributor/returned.ll

llvm/test/Transforms/Attributor/undefined_behavior.ll

llvm/test/Transforms/Attributor/value-simplify-instances.ll

llvm/test/Transforms/Attributor/value-simplify-pointer-info.ll

llvm/test/Transforms/Attributor/value-simplify.ll

llvm/test/Transforms/Attributor/willreturn.ll