Page MenuHomePhabricator
Differential D110882

[mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params
ClosedPublic
Actions

Authored by wrengr on Sep 30 2021, 1:51 PM.

Details

Reviewers
aartbik
bixia
penpornk
Commits
rGca010347145d: [mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params
Summary

This is preliminary work towards D110790

Diff Detail

Event Timeline

wrengr created this revision.Sep 30 2021, 1:51 PM
Herald added subscribers: wenzhicui, Chia-hungDuan, dcaballe and 17 others. · View Herald TranscriptSep 30 2021, 1:51 PM
wrengr requested review of this revision.Sep 30 2021, 1:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:51 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B126632: Diff 376352.Sep 30 2021, 1:51 PM
wrengr updated this revision to Diff 376354.Sep 30 2021, 1:54 PM

(No changes, just uploaded as an artifact of Fig workflow)

Harbormaster completed remote builds in B126633: Diff 376354.Sep 30 2021, 1:54 PM
wrengr mentioned this in D110790: [mlir][sparse] Implementing sparse=>dense conversion..Sep 30 2021, 1:55 PM
wrengr added a child revision: D110790: [mlir][sparse] Implementing sparse=>dense conversion..Sep 30 2021, 1:59 PM
wrengr added a child revision: D110883: [mlir][sparse] Factoring out allocaIndices().Sep 30 2021, 2:11 PM
wrengr edited the summary of this revision. (Show Details)Sep 30 2021, 2:16 PM
aartbik added inline comments.Sep 30 2021, 4:45 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
185

appropriate type -> given type

186

please spell out rewriter, we are pretty consistent about that naming

wrengr updated this revision to Diff 376401.Sep 30 2021, 5:23 PM
wrengr marked 2 inline comments as done.

Addressing comments

Harbormaster completed remote builds in B126654: Diff 376401.Sep 30 2021, 5:23 PM
aartbik accepted this revision.Oct 1 2021, 9:50 AM
This revision is now accepted and ready to land.Oct 1 2021, 9:50 AM
Closed by commit rGca010347145d: [mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params (authored by wrengr). · Explain WhyOct 1 2021, 2:18 PM
This revision was automatically updated to reflect the committed changes.
wrengr added a commit: rGca010347145d: [mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params.

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
SparseTensor/
Transforms/
21 lines

Diff 376401

View Options

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp

Loading...