Page MenuHomePhabricator
People penpornk

penpornk (Penporn Koanantakool)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 5 2020, 4:43 PM (127 w, 6 d)

Recent Activity
View All

Oct 28 2021

penpornk accepted D112779: [mlir][sparse] fix broken asan test.
Oct 28 2021, 10:15 PM · Restricted Project
penpornk reopened D112779: [mlir][sparse] fix broken asan test.
Oct 28 2021, 10:15 PM · Restricted Project

Jun 3 2021

penpornk accepted D103566: [mlir][sparse] add more type combinations to sparse storage scheme.
Jun 3 2021, 8:30 AM · Restricted Project

May 25 2021

penpornk accepted D102960: [sparse][mlir] simplify sparse runtime support library.
May 25 2021, 9:29 AM · Restricted Project

Apr 26 2021

penpornk accepted D101008: [mlir][tensors] Introduce attribute interface/attribute for tensor encoding.

(Not a compiler expert.)
SparseTensorEncodingAttr looks good to me. It follows the TACO format and is sufficient for what TFLite and TF are using/plan to use.

Apr 26 2021, 4:50 PM · Restricted Project

Jan 20 2021

penpornk accepted D95072: [mlir][sparse] add asserts on reading in tensor data.

Thank you for the changes!

Jan 20 2021, 2:26 PM · Restricted Project

Jan 19 2021

penpornk accepted D95015: [mlir][sparse] add narrower choices for pointers/indices.

Thank you for adding this, Aart! :)

Jan 19 2021, 7:26 PM · Restricted Project

Jan 14 2021

penpornk accepted D94709: [mlir][sparse] retry sparse-only for cyclic iteration graphs.

Smart! :)
The generated code looks correct to me.

Jan 14 2021, 9:54 PM · Restricted Project

Jan 12 2021

penpornk accepted D94551: [mlir][sparse] add vectorization strategies to sparse compiler.

Yay for vectorization! :D

Jan 12 2021, 10:06 PM · Restricted Project

Jan 5 2021

penpornk accepted D94119: [mlir][sparse] adjust output shape inference to new tensor abstraction.
Jan 5 2021, 3:09 PM · Restricted Project

Dec 17 2020

penpornk added inline comments to D93143: [mlir][sparse] scalarize reductions in for-loops during sparse codegen.
Dec 17 2020, 4:07 PM · Restricted Project
penpornk accepted D93143: [mlir][sparse] scalarize reductions in for-loops during sparse codegen.

I'm so sorry for the delay!

Dec 17 2020, 3:24 PM · Restricted Project

Dec 7 2020

penpornk accepted D92534: [mlir][sparse] hoist loop invariant tensor loads in sparse compiler.

I'm sorry for the delay! The generated MLIR code looks good to me.

Dec 7 2020, 1:13 AM · Restricted Project

Nov 25 2020

penpornk added inline comments to D92126: [mlir][sparse] add ability to select pointer/index storage type.
Nov 25 2020, 5:30 PM · Restricted Project
penpornk added inline comments to D92126: [mlir][sparse] add ability to select pointer/index storage type.
Nov 25 2020, 5:28 PM · Restricted Project
penpornk accepted D92126: [mlir][sparse] add ability to select pointer/index storage type.

Thank you, Aart!

Nov 25 2020, 4:23 PM · Restricted Project

Nov 24 2020

penpornk accepted D91978: [mlir][sparse] add parallelization strategies to sparse compiler.
Nov 24 2020, 4:41 PM · Restricted Project
penpornk accepted D91985: [mlir][sparse] generalize invariant expression handling in sparse compiler.

Thank you for the CL! The generated MLIR code looks good to me.

Nov 24 2020, 1:36 PM · Restricted Project
penpornk added inline comments to D91978: [mlir][sparse] add parallelization strategies to sparse compiler.
Nov 24 2020, 1:21 PM · Restricted Project

Nov 20 2020

penpornk accepted D91818: [mlir][sparse] refine optimization, add few more test cases.

The generated MLIR code looks good to me. Thank you for the tests / examples! :D

Nov 20 2020, 4:19 PM · Restricted Project

Nov 18 2020

penpornk accepted D91748: [mlir][sparse] remove a few rewriting failures.
Nov 18 2020, 4:16 PM · Restricted Project

Nov 11 2020

penpornk accepted D91316: [mlir][sparse] export sparse tensor runtime support through header file.
Nov 11 2020, 8:21 PM · Restricted Project

Oct 7 2020

penpornk accepted D89005: [mlir] [sparse] Rename getSparseMatrix to getMatrix.

Sounds good! :)

Oct 7 2020, 2:18 PM · Restricted Project

Oct 6 2020

penpornk accepted D88856: [mlir] [sparse] convenience runtime support to read Matrix Market format.

Thank you for the clarifications!

Oct 6 2020, 1:12 PM · Restricted Project
penpornk added a comment to D88856: [mlir] [sparse] convenience runtime support to read Matrix Market format.

I'm new to MLIR, so sorry in advance for noob MLIR comments!

Oct 6 2020, 11:09 AM · Restricted Project