Page MenuHomePhabricator

[mlir][sparse] Factoring out allocaIndices()
ClosedPublic

Authored by wrengr on Sep 30 2021, 2:11 PM.

Details

Summary

This is preliminary work towards D110790. Depends On D110882.

Diff Detail

Event Timeline

wrengr created this revision.Sep 30 2021, 2:11 PM
wrengr requested review of this revision.Sep 30 2021, 2:11 PM
wrengr edited the summary of this revision. (Show Details)Sep 30 2021, 2:16 PM

LG, but two nits before accepting

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
374

Please move this into the "Helper methods" section (L32-297), don't intersperse with conversion methods.

Also, please add a one line /// Doc comment on method.

wrengr updated this revision to Diff 376404.Sep 30 2021, 5:48 PM
wrengr marked an inline comment as done.

Addressing comments

aartbik accepted this revision.Oct 1 2021, 9:49 AM
This revision is now accepted and ready to land.Oct 1 2021, 9:49 AM
This revision was automatically updated to reflect the committed changes.