Page MenuHomePhabricator

[mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params
ClosedPublic

Authored by wrengr on Sep 30 2021, 1:51 PM.

Event Timeline

wrengr created this revision.Sep 30 2021, 1:51 PM
wrengr requested review of this revision.Sep 30 2021, 1:51 PM
wrengr updated this revision to Diff 376354.Sep 30 2021, 1:54 PM

(No changes, just uploaded as an artifact of Fig workflow)

wrengr edited the summary of this revision. (Show Details)Sep 30 2021, 2:16 PM
aartbik added inline comments.Sep 30 2021, 4:45 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
185

appropriate type -> given type

186

please spell out rewriter, we are pretty consistent about that naming

wrengr updated this revision to Diff 376401.Sep 30 2021, 5:23 PM
wrengr marked 2 inline comments as done.

Addressing comments

aartbik accepted this revision.Oct 1 2021, 9:50 AM
This revision is now accepted and ready to land.Oct 1 2021, 9:50 AM