This is an archive of the discontinued LLVM Phabricator instance.

[fir] Update fir.array_update, fir.array_fetch and fir.array_merge_store
ClosedPublic

Authored by clementval on Sep 29 2021, 5:46 AM.

Details

Summary

Add typeparams to fir.array_update, fir.array_fetch and
fir.array_merge_store operations. Add optional slice operands to
fir.array_merge_store op.
Move verifiers to cpp file.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Sep 29 2021, 5:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 5:46 AM
clementval requested review of this revision.Sep 29 2021, 5:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 5:46 AM

Add missing new file

A few Nits.
-> The commit message does not mention moving the verifier to cpp file.
-> Are there additional verify tests?

flang/include/flang/Optimizer/Support/Utils.h
27 ↗(On Diff #375858)

Nit: Newline

Add couple of invalid tests

clementval edited the summary of this revision. (Show Details)Sep 29 2021, 1:04 PM

A few Nits.
-> The commit message does not mention moving the verifier to cpp file.
-> Are there additional verify tests?

Thanks for the comments. I updated the message and added couple of invalid tests for the verifiers,

This revision is now accepted and ready to land.Sep 29 2021, 1:56 PM

Remove duplicated test

This revision was landed with ongoing or failed builds.Sep 30 2021, 1:14 AM
This revision was automatically updated to reflect the committed changes.