This is an archive of the discontinued LLVM Phabricator instance.

[fir][NFC] Move parser/printer/builder to cpp file
ClosedPublic

Authored by clementval on Sep 28 2021, 7:02 AM.

Details

Summary

Move the parsers, printers and builders from the TableGen file
to the .cpp file. Remaining parsers, printers and builders will be
moved when we update the operations.

This patch is part of the upstreaming effort from fir-dev branch.

Diff Detail

Event Timeline

clementval created this revision.Sep 28 2021, 7:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 7:02 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Sep 28 2021, 7:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 7:02 AM

Could more parser be using the declarative assembly syntax?

Could more parser be using the declarative assembly syntax?

There is some parsers that could be move to the assemblyFormat. I guess it would be better to do it in a follow up patch since here we are just moving existing parsers out of the td file.

schweitz accepted this revision.Sep 29 2021, 12:43 PM
This revision is now accepted and ready to land.Sep 29 2021, 12:43 PM
This revision was automatically updated to reflect the committed changes.