This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)
ClosedPublic

Authored by hyeongyukim on Sep 22 2021, 1:19 AM.

Details

Summary

This patch is for fixing potential shufflevector-related bugs like D93818.
As D93818, this patch change shufflevector's default placeholder to poison.
To reduce risk, it was divided into several patches, and this patch is for InstCombineCasts.

Diff Detail

Event Timeline

hyeongyukim created this revision.Sep 22 2021, 1:19 AM
hyeongyukim requested review of this revision.Sep 22 2021, 1:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2021, 1:19 AM
hyeongyukim retitled this revision from [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/4) to [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/3).Sep 22 2021, 1:50 AM
hyeongyukim retitled this revision from [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/3) to [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).Sep 22 2021, 2:03 AM
hyeongyukim edited the summary of this revision. (Show Details)
spatel accepted this revision.Sep 22 2021, 5:00 AM

LGTM - see inline reply about updating a code comment.

llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
2147 ↗(On Diff #374150)

use undef -> use poison

This revision is now accepted and ready to land.Sep 22 2021, 5:00 AM

Fix comment, update test file(wasm.c)

Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2021, 6:42 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Correct the wrong rebase.

This revision was landed with ongoing or failed builds.Sep 22 2021, 7:19 AM
This revision was automatically updated to reflect the committed changes.