This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Use attributor to propagate amdgpu-flat-work-group-size
ClosedPublic

Authored by arsenm on Sep 17 2021, 1:00 PM.

Details

Summary

This can merge the acceptable ranges based on the call graph, rather
than the simple application of the attribute. Remove the handling from
the old pass.

Diff Detail

Event Timeline

arsenm created this revision.Sep 17 2021, 1:00 PM
arsenm requested review of this revision.Sep 17 2021, 1:00 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
jdoerfert accepted this revision.Sep 17 2021, 1:56 PM

Only one minor oversight, otherwise LGTM.

llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
523
llvm/test/CodeGen/AMDGPU/propagate-flat-work-group-size.ll
151

Be careful with such tests. If you don't explicitly disable liveness (as you do now) this will all be deleted.

This revision is now accepted and ready to land.Sep 17 2021, 1:56 PM
llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp