This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] NFC: Use 'asm' in SIMDScalarCPY
ClosedPublic

Authored by c-rhodes on Sep 10 2021, 12:47 AM.

Details

Summary

Fixes a warning identified in D109359. The mnemonic is also mov, not
cpy.

Diff Detail

Event Timeline

c-rhodes created this revision.Sep 10 2021, 12:47 AM
c-rhodes requested review of this revision.Sep 10 2021, 12:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 12:47 AM
dmgreen added inline comments.Sep 11 2021, 10:59 AM
llvm/lib/Target/AArch64/AArch64InstrFormats.td
7661–7662

Would it be better for this to always be "mov" and remove the parameter?

c-rhodes added inline comments.Sep 13 2021, 3:08 AM
llvm/lib/Target/AArch64/AArch64InstrFormats.td
7661–7662

Would it be better for this to always be "mov" and remove the parameter?

I think being able to search for the mnemonic in AArch64InstrInfo.td might be useful

dmgreen accepted this revision.Sep 13 2021, 3:42 AM

OK I don't have a strong opinion either way

This revision is now accepted and ready to land.Sep 13 2021, 3:42 AM
This revision was automatically updated to reflect the committed changes.