Page MenuHomePhabricator

[Transforms] Remove dead ModuleLevelChanges parameters from CloneAndPrune functions
AcceptedPublic

Authored by scott.linder on Sep 2 2021, 1:21 PM.

Details

Summary

This appears to be dead within the codebase, and adding trivial tests of it expose issues around debug information cloning which were (at least partially) resolved as part of https://reviews.llvm.org/D96531.

The patch would be NFC if not for the API/ABI break, but again I believe this is just removing a dead parameter. If there are cases where the CloneAndPrune* functions do make sense in a context where there may be module level changes then something like https://reviews.llvm.org/D96531 is needed instead.

Diff Detail

Event Timeline

scott.linder created this revision.Sep 2 2021, 1:21 PM
scott.linder requested review of this revision.Sep 2 2021, 1:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 1:21 PM
scott.linder retitled this revision from [Transforms] Remove ModuleLevelChanges parameter from Clone functions to [Transforms] Remove dead ModuleLevelChanges parameters from CloneAndPrune functions.Sep 2 2021, 1:30 PM
scott.linder edited the summary of this revision. (Show Details)
hans accepted this revision.Sep 3 2021, 5:33 AM

lgtm, nice cleanup

This revision is now accepted and ready to land.Sep 3 2021, 5:33 AM