Adds patterns for f64 ds_min/ds_max. Shrinks HasLDSFPAtomics
scope to enable f32.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Shrinks HasLDSFPAtomics scope to enable f32.
"... to enable f32 add"? Maybe update the description of the feature to reflect this?
llvm/test/CodeGen/AMDGPU/lds-atomic-add.ll | ||
---|---|---|
1 ↗ | (On Diff #369691) | This file looks like a subset of the existing test/CodeGen/AMDGPU/lds_atomic_f32.ll? |
Comment Actions
Agreed
llvm/test/CodeGen/AMDGPU/lds-atomic-add.ll | ||
---|---|---|
1 ↗ | (On Diff #369691) | I split the test because the lds_atomic_fadd is only on gfx8 and gfx9, but the min/max are available on all architectures |
llvm/test/CodeGen/AMDGPU/lds-atomic-add.ll | ||
---|---|---|
1 ↗ | (On Diff #369691) | Oh, I hadn't even noticed that your patch deletes lds_atomic_f32.ll. OK then. The new files should probably be called lds-atomic-fadd.ll and lds-atomic-fmin-fmax.ll. |